From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.1553.1573633147498377774 for ; Wed, 13 Nov 2019 00:19:07 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Nov 2019 00:19:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,299,1569308400"; d="scan'208";a="202680618" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga008.fm.intel.com with ESMTP; 13 Nov 2019 00:19:05 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 Nov 2019 00:19:05 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 Nov 2019 00:19:04 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.149]) with mapi id 14.03.0439.000; Wed, 13 Nov 2019 16:17:14 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Wang, Jian J" CC: "Kinney, Michael D" , Laszlo Ersek , Ard Biesheuvel , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH v2] MdePkg: add null version of RngLib Thread-Topic: [edk2-devel] [PATCH v2] MdePkg: add null version of RngLib Thread-Index: AQHVmeQt2kzkyBTp8UuXYpQN+pEOO6eIwbOA Date: Wed, 13 Nov 2019 08:17:14 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E53F1FB@SHSMSX104.ccr.corp.intel.com> References: <20191113053529.7768-1-jian.j.wang@intel.com> In-Reply-To: <20191113053529.7768-1-jian.j.wang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The change is good. Reviewed-by: Liming Gao >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Wang, Jian J >Sent: Wednesday, November 13, 2019 1:35 PM >To: devel@edk2.groups.io >Cc: Kinney, Michael D ; Gao, Liming >; Laszlo Ersek ; Ard Biesheuvel >; Ni, Ray >Subject: [edk2-devel] [PATCH v2] MdePkg: add null version of RngLib > >>v2: >> - Change the name from RngLibNull to BaseRngLibNull according to Laszl= o's >> comments >> - Move the module from SecurityPkg to MdePkg according to Laszlo's >comments >> - Update commit message according to Laszlo and Ray's comments > >This is null version of RngLib which should be used with modules that >inherit an (indirect) dependency on the RngLib class, but never actually >call RngLib APIs for consuming randomness. > > >Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1871 >Cc: Michael D Kinney >Cc: Liming Gao >Cc: Laszlo Ersek >Cc: Ard Biesheuvel >Cc: Ray Ni >Signed-off-by: Jian J Wang >--- > .../Library/BaseRngLibNull/BaseRngLibNull.c | 95 +++++++++++++++++++ > .../Library/BaseRngLibNull/BaseRngLibNull.inf | 31 ++++++ > .../Library/BaseRngLibNull/BaseRngLibNull.uni | 14 +++ > MdePkg/MdePkg.dsc | 1 + > 4 files changed, 141 insertions(+) > create mode 100644 MdePkg/Library/BaseRngLibNull/BaseRngLibNull.c > create mode 100644 MdePkg/Library/BaseRngLibNull/BaseRngLibNull.inf > create mode 100644 MdePkg/Library/BaseRngLibNull/BaseRngLibNull.uni > >diff --git a/MdePkg/Library/BaseRngLibNull/BaseRngLibNull.c >b/MdePkg/Library/BaseRngLibNull/BaseRngLibNull.c >new file mode 100644 >index 0000000000..13677abc84 >--- /dev/null >+++ b/MdePkg/Library/BaseRngLibNull/BaseRngLibNull.c >@@ -0,0 +1,95 @@ >+/** @file >+ Null version of Random number generator services. >+ >+Copyright (c) 2019, Intel Corporation. All rights reserved.
>+SPDX-License-Identifier: BSD-2-Clause-Patent >+ >+**/ >+ >+#include >+#include >+#include >+ >+/** >+ Generates a 16-bit random number. >+ >+ if Rand is NULL, then ASSERT(). >+ >+ @param[out] Rand Buffer pointer to store the 16-bit random value. >+ >+ @retval TRUE Random number generated successfully. >+ @retval FALSE Failed to generate the random number. >+ >+**/ >+BOOLEAN >+EFIAPI >+GetRandomNumber16 ( >+ OUT UINT16 *Rand >+ ) >+{ >+ ASSERT (FALSE); >+ return FALSE; >+} >+ >+/** >+ Generates a 32-bit random number. >+ >+ if Rand is NULL, then ASSERT(). >+ >+ @param[out] Rand Buffer pointer to store the 32-bit random value. >+ >+ @retval TRUE Random number generated successfully. >+ @retval FALSE Failed to generate the random number. >+ >+**/ >+BOOLEAN >+EFIAPI >+GetRandomNumber32 ( >+ OUT UINT32 *Rand >+ ) >+{ >+ ASSERT (FALSE); >+ return FALSE; >+} >+ >+/** >+ Generates a 64-bit random number. >+ >+ if Rand is NULL, then ASSERT(). >+ >+ @param[out] Rand Buffer pointer to store the 64-bit random value. >+ >+ @retval TRUE Random number generated successfully. >+ @retval FALSE Failed to generate the random number. >+ >+**/ >+BOOLEAN >+EFIAPI >+GetRandomNumber64 ( >+ OUT UINT64 *Rand >+ ) >+{ >+ ASSERT (FALSE); >+ return FALSE; >+} >+ >+/** >+ Generates a 128-bit random number. >+ >+ if Rand is NULL, then ASSERT(). >+ >+ @param[out] Rand Buffer pointer to store the 128-bit random value. >+ >+ @retval TRUE Random number generated successfully. >+ @retval FALSE Failed to generate the random number. >+ >+**/ >+BOOLEAN >+EFIAPI >+GetRandomNumber128 ( >+ OUT UINT64 *Rand >+ ) >+{ >+ ASSERT (FALSE); >+ return FALSE; >+} >diff --git a/MdePkg/Library/BaseRngLibNull/BaseRngLibNull.inf >b/MdePkg/Library/BaseRngLibNull/BaseRngLibNull.inf >new file mode 100644 >index 0000000000..f456df1dae >--- /dev/null >+++ b/MdePkg/Library/BaseRngLibNull/BaseRngLibNull.inf >@@ -0,0 +1,31 @@ >+## @file >+# Null instance of RNG (Random Number Generator) Library. >+# >+# Copyright (c) 2019, Intel Corporation. All rights reserved.
>+# >+# SPDX-License-Identifier: BSD-2-Clause-Patent >+# >+## >+ >+[Defines] >+ INF_VERSION =3D 0x00010005 >+ BASE_NAME =3D BaseRngLibNull >+ MODULE_UNI_FILE =3D BaseRngLibNull.uni >+ FILE_GUID =3D CD8991F8-2061-4084-8C9E-9C6F352DC58= D >+ MODULE_TYPE =3D BASE >+ VERSION_STRING =3D 1.0 >+ LIBRARY_CLASS =3D RngLib >+ >+# >+# VALID_ARCHITECTURES =3D IA32 X64 ARM AARCH64 >+# >+ >+[Sources] >+ BaseRngLibNull.c >+ >+[Packages] >+ MdePkg/MdePkg.dec >+ >+[LibraryClasses] >+ BaseLib >+ DebugLib >diff --git a/MdePkg/Library/BaseRngLibNull/BaseRngLibNull.uni >b/MdePkg/Library/BaseRngLibNull/BaseRngLibNull.uni >new file mode 100644 >index 0000000000..f32be6a617 >--- /dev/null >+++ b/MdePkg/Library/BaseRngLibNull/BaseRngLibNull.uni >@@ -0,0 +1,14 @@ >+// /** @file >+// Null Instance of RNG (Random Number Generator) Library. >+// >+// Copyright (c) 2019, Intel Corporation. All rights reserved.
>+// >+// SPDX-License-Identifier: BSD-2-Clause-Patent >+// >+// **/ >+ >+ >+#string STR_MODULE_ABSTRACT #language en-US "Null Instance o= f >RNG Library" >+ >+#string STR_MODULE_DESCRIPTION #language en-US "This library >instance should be used with modules that inherit an (indirect) dependenc= y >on the RngLib class, but never actually call RngLib APIs for consuming >randomness." >+ >diff --git a/MdePkg/MdePkg.dsc b/MdePkg/MdePkg.dsc >index c1278e7907..0aeafaaacc 100644 >--- a/MdePkg/MdePkg.dsc >+++ b/MdePkg/MdePkg.dsc >@@ -61,6 +61,7 @@ > >MdePkg/Library/BaseUefiDecompressLib/BaseUefiTianoCustomDecompressL >ib.inf > MdePkg/Library/BaseSmbusLibNull/BaseSmbusLibNull.inf > MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf >+ MdePkg/Library/BaseRngLibNull/BaseRngLibNull.inf > > MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf > MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf >-- >2.17.1.windows.2 > > >