From: "Liming Gao" <liming.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Liu, Zhiguang" <zhiguang.liu@intel.com>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>, "Wu, Hao A" <hao.a.wu@intel.com>
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Unify the definitions of size_t
Date: Thu, 14 Nov 2019 01:00:39 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E5406AA@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20191112084744.19132-1-zhiguang.liu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Zhiguang Liu
>Sent: Tuesday, November 12, 2019 4:48 PM
>To: devel@edk2.groups.io
>Cc: Wang, Jian J <jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
>Subject: [edk2-devel] [PATCH] MdeModulePkg: Unify the definitions of size_t
>
>REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2338
>
>Cc: Jian J Wang <jian.j.wang@intel.com>
>
>Cc: Hao A Wu <hao.a.wu@intel.com>
>
>Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
>---
> MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/types.h | 6 +-----
> MdeModulePkg/Library/LzmaCustomDecompressLib/UefiLzma.h | 6 +-----
> 2 files changed, 2 insertions(+), 10 deletions(-)
>
>diff --git
>a/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/types.h
>b/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/types.h
>index 2867d206f7..35c9569642 100644
>--- a/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/types.h
>+++ b/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/types.h
>@@ -13,11 +13,7 @@
> #define BROTLI_COMMON_TYPES_H_
>
> //#include <stddef.h> /* for size_t */
>-#ifndef _SIZE_T_DEFINED
>-#if !defined(_WIN64) || defined(__GNUC__)
>-typedef unsigned int size_t;
>-#endif
>-#endif
>+typedef UINTN size_t;
>
> #if defined(_MSC_VER) && (_MSC_VER < 1600)
> typedef __int8 int8_t;
>diff --git a/MdeModulePkg/Library/LzmaCustomDecompressLib/UefiLzma.h
>b/MdeModulePkg/Library/LzmaCustomDecompressLib/UefiLzma.h
>index cbdecd377b..e1315b6ec3 100644
>--- a/MdeModulePkg/Library/LzmaCustomDecompressLib/UefiLzma.h
>+++ b/MdeModulePkg/Library/LzmaCustomDecompressLib/UefiLzma.h
>@@ -18,11 +18,7 @@
> #undef _WIN32
> #endif
>
>-#ifndef _SIZE_T_DEFINED
>-#if !defined(_WIN64) || defined(__GNUC__)
>-typedef unsigned int size_t;
>-#endif
>-#endif
>+typedef UINTN size_t;
>
> #ifdef _WIN64
> #undef _WIN64
>--
>2.16.2.windows.1
>
>
>
prev parent reply other threads:[~2019-11-14 1:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 8:47 [PATCH] MdeModulePkg: Unify the definitions of size_t Zhiguang Liu
2019-11-14 1:00 ` Liming Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E5406AA@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox