From: "Liming Gao" <liming.gao@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH] MdePkg: Update the comments of IsLanguageSupported
Date: Thu, 14 Nov 2019 15:42:47 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E540F95@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20191114114644.5504-3-shenglei.zhang@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
> -----Original Message-----
> From: Zhang, Shenglei <shenglei.zhang@intel.com>
> Sent: Thursday, November 14, 2019 7:47 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Shenglei <shenglei.zhang@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] MdePkg: Update the comments of IsLanguageSupported
>
> From: Shenglei Zhang <shenglei.zhang@intel.com>
>
> Keep the comment style of IsLanguageSupported align with
> other functions.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> MdePkg/Library/UefiLib/UefiLib.c | 18 +++++++++---------
> MdePkg/Include/Library/UefiLib.h | 19 ++++++++++---------
> 2 files changed, 19 insertions(+), 18 deletions(-)
>
> diff --git a/MdePkg/Library/UefiLib/UefiLib.c b/MdePkg/Library/UefiLib/UefiLib.c
> index cc03be84c2d8..07c45d1e91ff 100644
> --- a/MdePkg/Library/UefiLib/UefiLib.c
> +++ b/MdePkg/Library/UefiLib/UefiLib.c
> @@ -641,15 +641,15 @@ EfiTestChildHandle (
> }
>
> /**
> - * This function checks the supported languages list for a target language,
> - * This only supports RFC 4646 Languages.
> - *
> - * @param SupportedLanguages The supported languages
> - * @param TargetLanguage The target language
> - *
> - * @return Returns EFI_SUCCESS if the language is supported,
> - * EFI_UNSUPPORTED otherwise
> - */
> + This function checks the supported languages list for a target language,
> + This only supports RFC 4646 Languages.
> +
> + @param SupportedLanguages The supported languages
> + @param TargetLanguage The target language
> +
> + @retval Returns EFI_SUCCESS if the language is supported,
> + EFI_UNSUPPORTED otherwise
> +**/
> EFI_STATUS
> EFIAPI
> IsLanguageSupported (
> diff --git a/MdePkg/Include/Library/UefiLib.h b/MdePkg/Include/Library/UefiLib.h
> index 67c6f96747ca..0abb40d6ecbd 100644
> --- a/MdePkg/Include/Library/UefiLib.h
> +++ b/MdePkg/Include/Library/UefiLib.h
> @@ -462,15 +462,16 @@ EfiTestChildHandle (
> );
>
> /**
> - * This function checks the supported languages list for a target language,
> - * This only supports RFC 4646 Languages.
> - *
> - * @param SupportedLanguages The supported languages
> - * @param TargetLanguage The target language
> - *
> - * @return Returns EFI_SUCCESS if the language is supported,
> - * EFI_UNSUPPORTED otherwise
> - */
> + This function checks the supported languages list for a target language,
> + This only supports RFC 4646 Languages.
> +
> + @param SupportedLanguages The supported languages
> + @param TargetLanguage The target language
> +
> + @retval Returns EFI_SUCCESS if the language is supported,
> + EFI_UNSUPPORTED otherwise
> +
> +**/
> EFI_STATUS
> EFIAPI
> IsLanguageSupported (
> --
> 2.18.0.windows.1
next prev parent reply other threads:[~2019-11-14 15:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 11:46 [PATCH 0/3] Add missing strings for uni files Zhang, Shenglei
2019-11-14 11:46 ` [PATCH 1/3] MdeModulePkg/MdeModulePkg.uni: Add missing strings for PCD Zhang, Shenglei
2019-11-19 8:00 ` Wang, Jian J
2019-11-14 11:46 ` [PATCH] MdePkg: Update the comments of IsLanguageSupported Zhang, Shenglei
2019-11-14 15:42 ` Liming Gao [this message]
2019-11-14 11:46 ` [PATCH] UefiCpuPkg: Update the coding styles Zhang, Shenglei
2019-11-19 5:22 ` Dong, Eric
2019-11-19 17:30 ` [edk2-devel] " Laszlo Ersek
2019-11-14 11:46 ` [PATCH 2/3] NetworkPkg/NetworkPkg.uni: Add missing strings for PCD Zhang, Shenglei
2019-11-19 7:13 ` Wu, Jiaxin
2019-11-14 11:46 ` [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: " Zhang, Shenglei
2019-11-19 7:22 ` Dong, Eric
2019-11-14 12:02 ` [edk2-devel] [PATCH 0/3] Add missing strings for uni files Laszlo Ersek
2019-11-16 14:34 ` Zhang, Shenglei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E540F95@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox