From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.6060.1573746192861121341 for ; Thu, 14 Nov 2019 07:43:13 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Nov 2019 07:43:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,304,1569308400"; d="scan'208";a="405012168" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 14 Nov 2019 07:43:11 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 Nov 2019 07:43:11 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 14 Nov 2019 07:43:11 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.2]) with mapi id 14.03.0439.000; Thu, 14 Nov 2019 23:42:48 +0800 From: "Liming Gao" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Kinney, Michael D" Subject: Re: [PATCH] MdePkg: Update the comments of IsLanguageSupported Thread-Topic: [PATCH] MdePkg: Update the comments of IsLanguageSupported Thread-Index: AQHVmuFDA/Kqbxk4MkmlJvVkPX1M86eKzosQ Date: Thu, 14 Nov 2019 15:42:47 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E540F95@SHSMSX104.ccr.corp.intel.com> References: <20191114114644.5504-1-shenglei.zhang@intel.com> <20191114114644.5504-3-shenglei.zhang@intel.com> In-Reply-To: <20191114114644.5504-3-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDhlZTg4Y2ItODkwOC00OTQwLTg1ZGYtNjcxZjBiYTg4NjA0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoib250azMzUDZFalwvVnFpdUlOWjlxdjZQNFJYYlZvWUk3MFRnYVwvUzBXRTVDbzNSYVRrUldxdFRaODhOR1Q3RmN5In0= dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Zhang, Shenglei > Sent: Thursday, November 14, 2019 7:47 PM > To: devel@edk2.groups.io > Cc: Zhang, Shenglei ; Kinney, Michael D ; Gao, Liming > Subject: [PATCH] MdePkg: Update the comments of IsLanguageSupported >=20 > From: Shenglei Zhang >=20 > Keep the comment style of IsLanguageSupported align with > other functions. >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- > MdePkg/Library/UefiLib/UefiLib.c | 18 +++++++++--------- > MdePkg/Include/Library/UefiLib.h | 19 ++++++++++--------- > 2 files changed, 19 insertions(+), 18 deletions(-) >=20 > diff --git a/MdePkg/Library/UefiLib/UefiLib.c b/MdePkg/Library/UefiLib/Ue= fiLib.c > index cc03be84c2d8..07c45d1e91ff 100644 > --- a/MdePkg/Library/UefiLib/UefiLib.c > +++ b/MdePkg/Library/UefiLib/UefiLib.c > @@ -641,15 +641,15 @@ EfiTestChildHandle ( > } >=20 > /** > - * This function checks the supported languages list for a target langua= ge, > - * This only supports RFC 4646 Languages. > - * > - * @param SupportedLanguages The supported languages > - * @param TargetLanguage The target language > - * > - * @return Returns EFI_SUCCESS if the language is supported, > - * EFI_UNSUPPORTED otherwise > - */ > + This function checks the supported languages list for a target languag= e, > + This only supports RFC 4646 Languages. > + > + @param SupportedLanguages The supported languages > + @param TargetLanguage The target language > + > + @retval Returns EFI_SUCCESS if the language is supported, > + EFI_UNSUPPORTED otherwise > +**/ > EFI_STATUS > EFIAPI > IsLanguageSupported ( > diff --git a/MdePkg/Include/Library/UefiLib.h b/MdePkg/Include/Library/Ue= fiLib.h > index 67c6f96747ca..0abb40d6ecbd 100644 > --- a/MdePkg/Include/Library/UefiLib.h > +++ b/MdePkg/Include/Library/UefiLib.h > @@ -462,15 +462,16 @@ EfiTestChildHandle ( > ); >=20 > /** > - * This function checks the supported languages list for a target langua= ge, > - * This only supports RFC 4646 Languages. > - * > - * @param SupportedLanguages The supported languages > - * @param TargetLanguage The target language > - * > - * @return Returns EFI_SUCCESS if the language is supported, > - * EFI_UNSUPPORTED otherwise > - */ > + This function checks the supported languages list for a target languag= e, > + This only supports RFC 4646 Languages. > + > + @param SupportedLanguages The supported languages > + @param TargetLanguage The target language > + > + @retval Returns EFI_SUCCESS if the language is supported, > + EFI_UNSUPPORTED otherwise > + > +**/ > EFI_STATUS > EFIAPI > IsLanguageSupported ( > -- > 2.18.0.windows.1