From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web12.6494.1574090751071123987 for ; Mon, 18 Nov 2019 07:25:51 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2019 07:25:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,320,1569308400"; d="scan'208";a="406123555" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 18 Nov 2019 07:25:50 -0800 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 18 Nov 2019 07:25:49 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 18 Nov 2019 07:25:49 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.149]) with mapi id 14.03.0439.000; Mon, 18 Nov 2019 23:25:47 +0800 From: "Liming Gao" To: "Chang, Abner (HPS SW/FW Technologist)" , "devel@edk2.groups.io" CC: "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/Include: Add missing definitions of SMBIOS type 42h in SmBios.h Thread-Topic: [edk2-devel] [PATCH 1/1] MdePkg/Include: Add missing definitions of SMBIOS type 42h in SmBios.h Thread-Index: AQHVmQS5DLhN9m5IbUeEhVnmD+/7B6eHATuAgAoSYGCAAADk4A== Date: Mon, 18 Nov 2019 15:25:47 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E5429E5@SHSMSX104.ccr.corp.intel.com> References: <20191112025548.23632-1-abner.chang@hpe.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E53D0E9@SHSMSX104.ccr.corp.intel.com> <15D6538392FBC3E1.27853@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYTM5OTQ3YTUtMDY4YS00Zjk1LThmNDItMmEyNmRkYTczODNjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYVVYMWVib0VoMFF2U0I2eHZ0dEh6TmNnN1IxcFV2WWhUQWR4REFcL0hTbXIzdUVzeGVORTR4VGdxbjlscE5nN3YifQ== dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Abner: Sorry for the late response. I have no comments for this patch. Reviewed= -by: Liming Gao Besides, does this patch plan to catch 201911 stable tag? Thanks Liming > -----Original Message----- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Monday, November 18, 2019 11:16 PM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) ; Gao, Liming > Cc: Kinney, Michael D > Subject: RE: [edk2-devel] [PATCH 1/1] MdePkg/Include: Add missing defini= tions of SMBIOS type 42h in SmBios.h >=20 > Hi Liming, any other concerns of this patch? If no , could we have this = fix in edk2 master? >=20 > Thanks > Abner >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Abner Chang > > Sent: Tuesday, November 12, 2019 1:36 PM > > To: devel@edk2.groups.io; liming.gao@intel.com > > Cc: Kinney, Michael D > > Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/Include: Add missing > > definitions of SMBIOS type 42h in SmBios.h > > > > This definitions was defined in SMBIOS 3.2a and we miss to have the > > corresponding definition for this in SmBios.h. > > > > Abner > > > > > -----Original Message----- > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf O= f > > > Liming Gao > > > Sent: Tuesday, November 12, 2019 12:43 PM > > > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > > > > > Cc: Kinney, Michael D > > > Subject: Re: [edk2-devel] [PATCH 1/1] MdePkg/Include: Add missing > > > definitions of SMBIOS type 42h in SmBios.h > > > > > > Hi, is this a new definition in SmBios 3.3? Or is this a missing > > > definition in previous SmBios version? > > > > > > >-----Original Message----- > > > >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf = Of > > > >Abner Chang > > > >Sent: Tuesday, November 12, 2019 10:56 AM > > > >To: devel@edk2.groups.io > > > >Cc: abner.chang@hpe.com; Kinney, Michael D > > > >; Gao, Liming > > > >Subject: [edk2-devel] [PATCH 1/1] MdePkg/Include: Add missing > > > >definitions of SMBIOS type 42h in SmBios.h > > > > > > > >Add host interface Protocol Type Data Format structure in SmBios.h > > > > > > > >BZ link, > > > >INVALID URI REMOVED > > > >.org_show-5Fbug.cgi-3Fid- > > > 3D2328&d=3DDwIFAg&c=3DC5b8zRQO1miGmBeVZ2LFWg&r=3D_SN > > > > > >6FZBN4Vgi4Ulkskz6qU3NYRO03nHp9P7Z5q59A3E&m=3DnqCVIRL9hVAaMUSX > > > QUQXjFwJWv39 > > > >I6U90eR54obtRSM&s=3Dp7ENdrSPY3KJNnhX8zR5S1D8ZkjtYzhhhe-ki9- > > > 2mTQ&e=3D > > > > > > > >Signed-off-by: Abner Chang > > > > > > > >Cc: Michael D Kinney > > > >Cc: Liming Gao > > > >Signed-off-by: Abner Chang > > > >--- > > > > MdePkg/Include/IndustryStandard/SmBios.h | 9 +++++++++ > > > > 1 file changed, 9 insertions(+) > > > > > > > >diff --git a/MdePkg/Include/IndustryStandard/SmBios.h > > > >b/MdePkg/Include/IndustryStandard/SmBios.h > > > >index f504cc84e7..c0144c9c8f 100644 > > > >--- a/MdePkg/Include/IndustryStandard/SmBios.h > > > >+++ b/MdePkg/Include/IndustryStandard/SmBios.h > > > >@@ -2483,6 +2483,15 @@ typedef struct { > > > > UINT8 DevFuncNum; > > > > } SMBIOS_TABLE_TYPE41; > > > > > > > >+/// > > > >+/// Management Controller Host Interface - Protocol Record Data > > Format. > > > >+/// > > > >+typedef struct { > > > >+ UINT8 ProtocolType; > > > >+ UINT8 ProtocolTypeDataLen; > > > >+ UINT8 ProtocolTypeData[1]; > > > >+} MC_HOST_INTERFACE_PROTOCOL_RECORD; > > > >+ > > > > /// > > > > /// Management Controller Host Interface - Interface Types. > > > > /// 00h - 3Fh: MCTP Host Interfaces > > > >-- > > > >2.21.0.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 >=20