From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.15530.1574128496454523373 for ; Mon, 18 Nov 2019 17:54:56 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Nov 2019 17:54:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,322,1569308400"; d="scan'208";a="200177558" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga008.jf.intel.com with ESMTP; 18 Nov 2019 17:54:55 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 18 Nov 2019 17:54:55 -0800 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 18 Nov 2019 17:54:54 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.63]) with mapi id 14.03.0439.000; Tue, 19 Nov 2019 09:54:52 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Bi, Dandan" , "Wang, Jian J" , "Wu, Hao A" Subject: Re: [edk2-devel] [PATCH V1 1/1] MdeModulePkg PeiCore: Improve PeiInstallPeiMemory() description Thread-Topic: [edk2-devel] [PATCH V1 1/1] MdeModulePkg PeiCore: Improve PeiInstallPeiMemory() description Thread-Index: AQHVneDDJTw3snLz0kGknFeJqckPV6eRu5ZQ Date: Tue, 19 Nov 2019 01:54:51 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E542C6F@SHSMSX104.ccr.corp.intel.com> References: <20191118072103.2436-1-michael.a.kubacki@intel.com> In-Reply-To: <20191118072103.2436-1-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Michael: Will you also plan to update EFI_PEI_INSTALL_PEI_MEMORY definition in Md= ePkg\Include\Pi\PiPeiCis.h based on PI1.7? Thanks Liming >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Kubacki, Michael A >Sent: Monday, November 18, 2019 3:21 PM >To: devel@edk2.groups.io >Cc: Bi, Dandan ; Gao, Liming ; >Wang, Jian J ; Wu, Hao A >Subject: [edk2-devel] [PATCH V1 1/1] MdeModulePkg PeiCore: Improve >PeiInstallPeiMemory() description > >Updates the function description for PeiInstallPeiMemory () to be >more helpful. The description is based on that given in the PI >Specification Version 1.7. > >Cc: Dandan Bi >Cc: Liming Gao >Cc: Jian J Wang >Cc: Hao A Wu >Signed-off-by: Michael Kubacki >--- > MdeModulePkg/Core/Pei/PeiMain.h | 23 ++++++++++++++---- > MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 25 >+++++++++++++------- > 2 files changed, 35 insertions(+), 13 deletions(-) > >diff --git a/MdeModulePkg/Core/Pei/PeiMain.h >b/MdeModulePkg/Core/Pei/PeiMain.h >index f2aa97c664..14dfb20d05 100644 >--- a/MdeModulePkg/Core/Pei/PeiMain.h >+++ b/MdeModulePkg/Core/Pei/PeiMain.h >@@ -898,13 +898,26 @@ InitializeMemoryServices ( > ); > > /** >+ Registers the found memory configuration with the PEI Foundation. > >- Install the permanent memory is now available. >- Creates HOB (PHIT and Stack). >+ This service enables PEIMs to register the permanent memory >configuration that has been initialized >+ with the PEI Foundation. The result of this call-set is the creation o= f the >appropriate Hand-Off Block >+ (HOB) describing the physical memory. > >- @param PeiServices An indirect pointer to the EFI_PEI_SERVICES tab= le >published by the PEI Foundation. >- @param MemoryBegin Start of memory address. >- @param MemoryLength Length of memory. >+ The usage model is that the PEIM that discovers the permanent memory >shall invoke this service. >+ This routine will store discovered memory information in the PeiCore's >private data, and set the >+ SwitchStackSignal flag. After the PEIM who discovered memory is >dispatched, the PeiDispatcher will >+ migrate temporary memory to permanent memory. >+ >+ The memory reported is a single contiguous run. It should be enough to >allocate a PEI stack and >+ some HOB list. The full memory map will be reported using the appropri= ate >memory HOBs. The >+ PEI Foundation will follow up with an installation of >EFI_PEI_PERMANENT_MEMORY_INSTALLED_PPI. >+ >+ Any invocations of this service after the first invocation which retur= ns >EFI_SUCCESS will be ignored. >+ >+ @param[in] PeiServices An indirect pointer to the EFI_PEI_SERVICES= table >published by the PEI Foundation. >+ @param[in] MemoryBegin Start of memory address. >+ @param[in] MemoryLength Length of memory. > > @return EFI_SUCCESS Always success. > >diff --git a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c >b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c >index 706837890f..b6ac876145 100644 >--- a/MdeModulePkg/Core/Pei/Memory/MemoryServices.c >+++ b/MdeModulePkg/Core/Pei/Memory/MemoryServices.c >@@ -1,7 +1,7 @@ > /** @file > EFI PEI Core memory services > >-Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
>+Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ >@@ -55,17 +55,26 @@ InitializeMemoryServices ( > } > > /** >+ Registers the found memory configuration with the PEI Foundation. > >- This function registers the found memory configuration with the PEI >Foundation. >+ This service enables PEIMs to register the permanent memory >configuration that has been initialized >+ with the PEI Foundation. The result of this call-set is the creation o= f the >appropriate Hand-Off Block >+ (HOB) describing the physical memory. > > The usage model is that the PEIM that discovers the permanent memory >shall invoke this service. >- This routine will hold discoveried memory information into PeiCore's p= rivate >data, >- and set SwitchStackSignal flag. After PEIM who discovery memory is >dispatched, >- PeiDispatcher will migrate temporary memory to permenement memory. >+ This routine will store discovered memory information in the PeiCore's >private data, and set the >+ SwitchStackSignal flag. After the PEIM who discovered memory is >dispatched, the PeiDispatcher will >+ migrate temporary memory to permanent memory. > >- @param PeiServices An indirect pointer to the EFI_PEI_SERVICES = table >published by the PEI Foundation. >- @param MemoryBegin Start of memory address. >- @param MemoryLength Length of memory. >+ The memory reported is a single contiguous run. It should be enough to >allocate a PEI stack and >+ some HOB list. The full memory map will be reported using the appropri= ate >memory HOBs. The >+ PEI Foundation will follow up with an installation of >EFI_PEI_PERMANENT_MEMORY_INSTALLED_PPI. >+ >+ Any invocations of this service after the first invocation which retur= ns >EFI_SUCCESS will be ignored. >+ >+ @param[in] PeiServices An indirect pointer to the EFI_PEI_SERVICES= table >published by the PEI Foundation. >+ @param[in] MemoryBegin Start of memory address. >+ @param[in] MemoryLength Length of memory. > > @return EFI_SUCCESS Always success. > >-- >2.16.2.windows.1 > > >