From: "Liming Gao" <liming.gao@intel.com>
To: "Liu, Zhiguang" <zhiguang.liu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Wang, Jian J" <jian.j.wang@intel.com>, "Wu, Hao A" <hao.a.wu@intel.com>
Subject: Re: [PATCH] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore
Date: Wed, 20 Nov 2019 07:58:38 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E544060@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20191120063443.30604-1-zhiguang.liu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
>-----Original Message-----
>From: Liu, Zhiguang
>Sent: Wednesday, November 20, 2019 2:35 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Wang, Jian J
><jian.j.wang@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
>Subject: [PATCH] MdeModulePkg: LzmaCustomDecompressLib.inf don't
>support EBC anymore
>
>After unifying the definition of size_t, EBC compiler has failure.
>So don't compile this inf file for EBC
>
>REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2338
>
>Cc: Liming Gao <liming.gao@intel.com>
>Cc: Jian J Wang <jian.j.wang@intel.com>
>Cc: Hao A Wu <hao.a.wu@intel.com>
>
>Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
>---
>
>MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompre
>ssLib.inf | 2 +-
> MdeModulePkg/MdeModulePkg.dsc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git
>a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompr
>essLib.inf
>b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecomp
>ressLib.inf
>index 42b741c64b..e8061f54f9 100644
>---
>a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompr
>essLib.inf
>+++
>b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecomp
>ressLib.inf
>@@ -25,7 +25,7 @@
> #
> # The following information is for reference only and not required by the
>build tools.
> #
>-# VALID_ARCHITECTURES = IA32 X64 EBC
>+# VALID_ARCHITECTURES = IA32 X64
> #
>
> [Sources]
>diff --git a/MdeModulePkg/MdeModulePkg.dsc
>b/MdeModulePkg/MdeModulePkg.dsc
>index 4320839abf..f7dbb27ce2 100644
>--- a/MdeModulePkg/MdeModulePkg.dsc
>+++ b/MdeModulePkg/MdeModulePkg.dsc
>@@ -299,7 +299,6 @@
> MdeModulePkg/Library/PeiDebugPrintHobLib/PeiDebugPrintHobLib.inf
>
>MdeModulePkg/Library/CpuExceptionHandlerLibNull/CpuExceptionHandlerLi
>bNull.inf
>
>MdeModulePkg/Library/PlatformHookLibSerialPortPpi/PlatformHookLibSerial
>PortPpi.inf
>-
>MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompre
>ssLib.inf
>
>MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLib
>ReportStatusCode.inf
> MdeModulePkg/Library/PeiDebugLibDebugPpi/PeiDebugLibDebugPpi.inf
> MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
>@@ -433,6 +432,7 @@
>
> [Components.IA32, Components.X64, Components.ARM,
>Components.AARCH64]
>
>MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompre
>ssLib.inf
>+
>MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompre
>ssLib.inf
> MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
> MdeModulePkg/Core/Dxe/DxeMain.inf {
> <LibraryClasses>
>--
>2.16.2.windows.1
next prev parent reply other threads:[~2019-11-20 7:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 6:34 [PATCH] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore Zhiguang Liu
2019-11-20 7:58 ` Liming Gao [this message]
2019-11-21 11:05 ` [edk2-devel] " Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E544060@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox