From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web12.18585.1574304741380199311 for ; Wed, 20 Nov 2019 18:52:21 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 18:52:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,224,1571727600"; d="scan'208";a="209756424" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 20 Nov 2019 18:52:20 -0800 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 Nov 2019 18:52:20 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 20 Nov 2019 18:52:20 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.213]) with mapi id 14.03.0439.000; Thu, 21 Nov 2019 10:52:17 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Kubacki, Michael A" CC: "Kinney, Michael D" , "Wang, Jian J" , "Wu, Hao A" Subject: Re: [edk2-devel] [PATCH V1 1/1] MdeModulePkg/Variable: Initialize local variable Thread-Topic: [edk2-devel] [PATCH V1 1/1] MdeModulePkg/Variable: Initialize local variable Thread-Index: AQHVoBQMVsH7WGVFB0mI+IcRU+efuaeU7TCA Date: Thu, 21 Nov 2019 02:52:16 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E544730@SHSMSX104.ccr.corp.intel.com> References: <20191121023256.24820-1-michael.a.kubacki@intel.com> In-Reply-To: <20191121023256.24820-1-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Kubacki, Michael A >Sent: Thursday, November 21, 2019 10:33 AM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Kinney, Michael D >; Wang, Jian J ; Wu, >Hao A >Subject: [edk2-devel] [PATCH V1 1/1] MdeModulePkg/Variable: Initialize lo= cal >variable > >REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2364 > >Fixes a new build warning in VS2012 introduced in f8ff4cca7c. > >This patch initializes the local variable "Variable" in >VariableServiceGetNextVariableInternal () and the local >variable "RtPtrTrack" in FindVariableInRuntimeCache (). >This enusres the pointers in the structures are initialized >in the case no variable stores exist in the list of variable >stores. > >Cc: Liming Gao >Cc: Michael D Kinney >Cc: Jian J Wang >Cc: Hao A Wu >Signed-off-by: Michael Kubacki >--- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c | 2 += + > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c >| 2 ++ > 2 files changed, 4 insertions(+) > >diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c >b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c >index d458f1c608..f6d187543d 100644 >--- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c >+++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c >@@ -551,6 +551,8 @@ VariableServiceGetNextVariableInternal ( > return EFI_INVALID_PARAMETER; > } > >+ ZeroMem (&Variable, sizeof (Variable)); >+ > // Check if the variable exists in the given variable store list > for (StoreType =3D (VARIABLE_STORE_TYPE) 0; StoreType < >VariableStoreTypeMax; StoreType++) { > if (VariableStoreList[StoreType] =3D=3D NULL) { >diff --git >a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe >.c >b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDx >e.c >index d525998ae3..2cf0ed32ae 100644 >--- >a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe >.c >+++ >b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDx >e.c >@@ -590,6 +590,8 @@ FindVariableInRuntimeCache ( > return EFI_INVALID_PARAMETER; > } > >+ ZeroMem (&RtPtrTrack, sizeof (RtPtrTrack)); >+ > // > // The UEFI specification restricts Runtime Services callers from invo= king the >same or certain other Runtime Service > // functions prior to completion and return from a previous Runtime Se= rvice >call. These restrictions prevent >-- >2.16.2.windows.1 > > >