Re: [PATCH v1 1/1] StandaloneMmPkg: Fix build failure - Bug 2253

["Liming Gao" <liming.gao@intel.com>]

Laszlo:

>-----Original Message-----
>From: Laszlo Ersek [mailto:lersek@redhat.com]
>Sent: Friday, November 22, 2019 12:04 AM
>To: Sami Mujawar <sami.mujawar@arm.com>; devel@edk2.groups.io
>Cc: achin.gupta@arm.com; Yao, Jiewen <jiewen.yao@intel.com>;
>supreeth.venkatesh@arm.com; Matteo.Carlini@arm.com;
>Laura.Moretta@arm.com; nd@arm.com; Gao, Liming <liming.gao@intel.com>;
>Leif Lindholm <leif.lindholm@linaro.org>
>Subject: Re: [PATCH v1 1/1] StandaloneMmPkg: Fix build failure - Bug 2253
>
>On 11/21/19 16:06, Sami Mujawar wrote:
>> The StandaloneMmPkg currently has code for supporting
>> Arm architecture only. Support for X64 and IA32 is
>> currently under development on a separate branch.
>>
>> However, StandaloneMmPkg/StandaloneMmPkg.dsc is
>> indicating that support for X64 and IA32 is
>> available which is causing build failures.
>> This has been reported in
>> https://bugzilla.tianocore.org/show_bug.cgi?id=2253
>>
>> This issue has been discussed earlier on the list:
>> (1) https://edk2.groups.io/g/devel/message/47276
>>
>> (2) https://edk2.groups.io/g/devel/message/47283
>>
>> In light of the above, this patch removes IA32 and X64
>> from SUPPORTED_ARCHITECTURES, until support for the
>> respective architectures is merged into StandaloneMmPkg.
>>
>> CC: Achin Gupta <achin.gupta@arm.com>
>> CC: Jiewen Yao <jiewen.yao@intel.com>
>> CC: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
>> CC: Laszlo Ersek <lersek@redhat.com>
>> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
>>
>> ---
>> The changes can be seen at:
>>
>https://github.com/samimujawar/edk2/tree/697_stmm_disable_unsupporte
>d_arch_v1
>>
>> Notes:
>>     v1:
>>       - Fix for Bug 2253                                            [SAMI]
>>         (https://bugzilla.tianocore.org/show_bug.cgi?id=2253)
>>
>>  StandaloneMmPkg/StandaloneMmPkg.dsc | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc
>b/StandaloneMmPkg/StandaloneMmPkg.dsc
>> index
>8a68d397469bdb83586bfeaebedcd52fd528b20f..f9546e182e25fbcd253de0986
>a1bb554dae1e975 100644
>> --- a/StandaloneMmPkg/StandaloneMmPkg.dsc
>> +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc
>> @@ -2,7 +2,7 @@
>>  # Standalone MM Platform.
>>  #
>>  # Copyright (c) 2015, Intel Corporation. All rights reserved.<BR>
>> -# Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.<BR>
>> +# Copyright (c) 2016 - 2019, ARM Limited. All rights reserved.<BR>
>>  #
>>  #    SPDX-License-Identifier: BSD-2-Clause-Patent
>>  #
>> @@ -19,7 +19,7 @@ [Defines]
>>    PLATFORM_VERSION               = 1.0
>>    DSC_SPECIFICATION              = 0x00010011
>>    OUTPUT_DIRECTORY               = Build/StandaloneMm
>> -  SUPPORTED_ARCHITECTURES        = IA32|X64|AARCH64
>> +  SUPPORTED_ARCHITECTURES        = AARCH64
>>    BUILD_TARGETS                  = DEBUG|RELEASE
>>    SKUID_IDENTIFIER               = DEFAULT
>>
>>
>
>Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
>This should be included in edk2-stable201911 -- it fixes obscure build
>failures.
>

Agree. If no objection, I will create pull request for this patch to push it. 

Thanks
Liming

>Thanks
>Laszlo