From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.1171.1574389255893854633 for ; Thu, 21 Nov 2019 18:20:55 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2019 18:20:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,228,1571727600"; d="scan'208";a="232531498" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 21 Nov 2019 18:20:55 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 18:20:55 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 21 Nov 2019 18:20:54 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.41]) with mapi id 14.03.0439.000; Fri, 22 Nov 2019 10:20:53 +0800 From: "Liming Gao" To: Laszlo Ersek , Sami Mujawar , "devel@edk2.groups.io" CC: "achin.gupta@arm.com" , "Yao, Jiewen" , "supreeth.venkatesh@arm.com" , "Matteo.Carlini@arm.com" , "Laura.Moretta@arm.com" , "nd@arm.com" , Leif Lindholm Subject: Re: [PATCH v1 1/1] StandaloneMmPkg: Fix build failure - Bug 2253 Thread-Topic: [PATCH v1 1/1] StandaloneMmPkg: Fix build failure - Bug 2253 Thread-Index: AQHVoIVXjLgJwmZYNEKFdodLXwHdVKeWdZAQ Date: Fri, 22 Nov 2019 02:20:52 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E5470D8@SHSMSX104.ccr.corp.intel.com> References: <20191121150631.20096-1-sami.mujawar@arm.com> <69536bde-e2e7-ae34-79ac-09768a835e06@redhat.com> In-Reply-To: <69536bde-e2e7-ae34-79ac-09768a835e06@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Laszlo: >-----Original Message----- >From: Laszlo Ersek [mailto:lersek@redhat.com] >Sent: Friday, November 22, 2019 12:04 AM >To: Sami Mujawar ; devel@edk2.groups.io >Cc: achin.gupta@arm.com; Yao, Jiewen ; >supreeth.venkatesh@arm.com; Matteo.Carlini@arm.com; >Laura.Moretta@arm.com; nd@arm.com; Gao, Liming ; >Leif Lindholm >Subject: Re: [PATCH v1 1/1] StandaloneMmPkg: Fix build failure - Bug 2253 > >On 11/21/19 16:06, Sami Mujawar wrote: >> The StandaloneMmPkg currently has code for supporting >> Arm architecture only. Support for X64 and IA32 is >> currently under development on a separate branch. >> >> However, StandaloneMmPkg/StandaloneMmPkg.dsc is >> indicating that support for X64 and IA32 is >> available which is causing build failures. >> This has been reported in >> https://bugzilla.tianocore.org/show_bug.cgi?id=3D2253 >> >> This issue has been discussed earlier on the list: >> (1) https://edk2.groups.io/g/devel/message/47276 >> >> (2) https://edk2.groups.io/g/devel/message/47283 >> >> In light of the above, this patch removes IA32 and X64 >> from SUPPORTED_ARCHITECTURES, until support for the >> respective architectures is merged into StandaloneMmPkg. >> >> CC: Achin Gupta >> CC: Jiewen Yao >> CC: Supreeth Venkatesh >> CC: Laszlo Ersek >> Signed-off-by: Sami Mujawar >> >> --- >> The changes can be seen at: >> >https://github.com/samimujawar/edk2/tree/697_stmm_disable_unsupporte >d_arch_v1 >> >> Notes: >> v1: >> - Fix for Bug 2253 [SAM= I] >> (https://bugzilla.tianocore.org/show_bug.cgi?id=3D2253) >> >> StandaloneMmPkg/StandaloneMmPkg.dsc | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc >b/StandaloneMmPkg/StandaloneMmPkg.dsc >> index >8a68d397469bdb83586bfeaebedcd52fd528b20f..f9546e182e25fbcd253de0986 >a1bb554dae1e975 100644 >> --- a/StandaloneMmPkg/StandaloneMmPkg.dsc >> +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc >> @@ -2,7 +2,7 @@ >> # Standalone MM Platform. >> # >> # Copyright (c) 2015, Intel Corporation. All rights reserved.
>> -# Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.
>> +# Copyright (c) 2016 - 2019, ARM Limited. All rights reserved.
>> # >> # SPDX-License-Identifier: BSD-2-Clause-Patent >> # >> @@ -19,7 +19,7 @@ [Defines] >> PLATFORM_VERSION =3D 1.0 >> DSC_SPECIFICATION =3D 0x00010011 >> OUTPUT_DIRECTORY =3D Build/StandaloneMm >> - SUPPORTED_ARCHITECTURES =3D IA32|X64|AARCH64 >> + SUPPORTED_ARCHITECTURES =3D AARCH64 >> BUILD_TARGETS =3D DEBUG|RELEASE >> SKUID_IDENTIFIER =3D DEFAULT >> >> > >Reviewed-by: Laszlo Ersek > >This should be included in edk2-stable201911 -- it fixes obscure build >failures. > Agree. If no objection, I will create pull request for this patch to push i= t.=20 Thanks Liming >Thanks >Laszlo