From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.3762.1574687268973544173 for ; Mon, 25 Nov 2019 05:07:49 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Nov 2019 05:07:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,241,1571727600"; d="scan'208";a="408301297" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 25 Nov 2019 05:07:48 -0800 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 25 Nov 2019 05:07:48 -0800 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 25 Nov 2019 05:07:47 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.248]) with mapi id 14.03.0439.000; Mon, 25 Nov 2019 21:07:46 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "lersek@redhat.com" , Sami Mujawar CC: Achin Gupta , "Yao, Jiewen" , Supreeth Venkatesh , Matteo Carlini , Laura Moretta , nd Subject: Re: [edk2-devel] [PATCH v2 1/1] StandaloneMmPkg: Fix build failure - Bug 2253 Thread-Topic: [edk2-devel] [PATCH v2 1/1] StandaloneMmPkg: Fix build failure - Bug 2253 Thread-Index: AQHVo3N+EFZBQIqOWUSnM52rsMNULaebNN8AgAAfqACAAIcMMA== Date: Mon, 25 Nov 2019 13:07:46 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E548267@SHSMSX104.ccr.corp.intel.com> References: <20191125090604.2076-1-sami.mujawar@arm.com> <50b01cb2-d30c-106f-3297-6f4f5c624f8a@redhat.com> In-Reply-To: <50b01cb2-d30c-106f-3297-6f4f5c624f8a@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWEzYmZiMmUtODU2Ny00ZjhhLWExN2MtMTExMmJhMmI3ZDAyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiV1YxVTNxcDMwTVp4QUFOR01WU2R2alhvSGdsRDlxbDNSRFBmNjNYYUZud05MVUlhRENYT2U5WFJzMnlTMUlUYyJ9 dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Just create PR https://github.com/tianocore/edk2/pull/195, and push@290a485= d6043a049b611aab30f450c74b8591f35 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Laszlo Er= sek > Sent: Monday, November 25, 2019 9:04 PM > To: Sami Mujawar ; devel@edk2.groups.io > Cc: Achin Gupta ; Yao, Jiewen ; Supreeth Venkatesh ; > Matteo Carlini ; Laura Moretta ; nd > Subject: Re: [edk2-devel] [PATCH v2 1/1] StandaloneMmPkg: Fix build fail= ure - Bug 2253 >=20 > On 11/25/19 12:10, Sami Mujawar wrote: > > Apologies, I missed #28 'Pick up the tags that you got on the list', f= rom Laszlo's guide. > > > > This patch has also received a Reviewed-by from: > > Reviewed-by: jiewen.yao@intel.com > > Reviewed-by: Laszlo Ersek >=20 > Right, I noticed, but I figured I wouldn't obsess about it. :) >=20 > Thank you though! > Laszlo >=20 > > -----Original Message----- > > From: Sami Mujawar > > Sent: 25 November 2019 09:06 AM > > To: devel@edk2.groups.io > > Cc: Sami Mujawar ; Achin Gupta ; jiewen.yao@intel.com; Supreeth Venkatesh > ; lersek@redhat.com; Matteo Carlini ; Laura Moretta > ; nd > > Subject: [PATCH v2 1/1] StandaloneMmPkg: Fix build failure - Bug 2253 > > > > The StandaloneMmPkg currently has code for supporting Arm architecture= only. Support for X64 and IA32 is currently under > development on a separate branch. > > > > However, StandaloneMmPkg/StandaloneMmPkg.dsc is indicating that suppor= t for X64 and IA32 is available which is causing build > failures. > > This has been reported in > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D2253 > > > > This issue has been discussed earlier on the list: > > (1) https://edk2.groups.io/g/devel/message/47276 > > > > (2) https://edk2.groups.io/g/devel/message/47283 > > > > In light of the above, this patch removes IA32 and X64 from SUPPORTED_= ARCHITECTURES, until support for the respective > architectures is merged into StandaloneMmPkg. > > > > Cc: Achin Gupta > > Cc: Jiewen Yao > > Cc: Supreeth Venkatesh > > Cc: Laszlo Ersek > > Signed-off-by: Sami Mujawar > > > > --- > > The changes can be seen at: > > https://github.com/samimujawar/edk2/tree/697_stmm_disable_unsupported_= arch_v1 > > > > Notes: > > v2: > > - Fixed patch check failure in commit message, [S= AMI] > > changed 'CC' to 'Cc'. No code change. > > v1: > > - Fix for Bug 2253 [S= AMI] > > (https://bugzilla.tianocore.org/show_bug.cgi?id=3D2253) > > > > StandaloneMmPkg/StandaloneMmPkg.dsc | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc b/StandaloneMmPkg/Sta= ndaloneMmPkg.dsc > > index 8a68d397469bdb83586bfeaebedcd52fd528b20f..f9546e182e25fbcd253de0= 986a1bb554dae1e975 100644 > > --- a/StandaloneMmPkg/StandaloneMmPkg.dsc > > +++ b/StandaloneMmPkg/StandaloneMmPkg.dsc > > @@ -2,7 +2,7 @@ > > # Standalone MM Platform. > > # > > # Copyright (c) 2015, Intel Corporation. All rights reserved.
-# = Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.
> > +# Copyright (c) 2016 - 2019, ARM Limited. All rights reserved.
> > # > > # SPDX-License-Identifier: BSD-2-Clause-Patent > > # > > @@ -19,7 +19,7 @@ [Defines] > > PLATFORM_VERSION =3D 1.0 > > DSC_SPECIFICATION =3D 0x00010011 > > OUTPUT_DIRECTORY =3D Build/StandaloneMm > > - SUPPORTED_ARCHITECTURES =3D IA32|X64|AARCH64 > > + SUPPORTED_ARCHITECTURES =3D AARCH64 > > BUILD_TARGETS =3D DEBUG|RELEASE > > SKUID_IDENTIFIER =3D DEFAULT > > > > -- > > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > > > >=20 >=20 >=20