From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web09.4578.1574691676898268636 for ; Mon, 25 Nov 2019 06:21:17 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Nov 2019 06:21:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,241,1571727600"; d="scan'208";a="409633356" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga006.fm.intel.com with ESMTP; 25 Nov 2019 06:21:18 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 25 Nov 2019 06:21:16 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 25 Nov 2019 06:21:15 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.60]) with mapi id 14.03.0439.000; Mon, 25 Nov 2019 22:21:14 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "ard.biesheuvel@linaro.org" CC: "leif.lindholm@linaro.org" , "piwg@uefi.org" , "kimon.berlin@hp.com" , "eugene@hp.com" Subject: Re: [edk2-devel] [PATCH 0/6] PIWG M1993 - implement EFI_MM_COMMUNICATE2_PROTOCOL Thread-Topic: [edk2-devel] [PATCH 0/6] PIWG M1993 - implement EFI_MM_COMMUNICATE2_PROTOCOL Thread-Index: AQHVoQ9w2/VJ2wpII0igAPZmebutYaeb9AxQ Date: Mon, 25 Nov 2019 14:21:14 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E5483A3@SHSMSX104.ccr.corp.intel.com> References: <20191122083234.12756-1-ard.biesheuvel@linaro.org> In-Reply-To: <20191122083234.12756-1-ard.biesheuvel@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTUyZTAzNmItMGE2MS00NDg1LWE0ZGItOTdlNDdhN2JkMDNjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMFJsNVc0WnJlVFZ0blBzVFcwdzYzSkNxaUpoRWZucnJEY1R1MGNLRmNWSzRFd1ZzR01UVXpDVFRlN0h2UGtiOCJ9 dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ard: This change is about new protocol in 1.7 errata A of the PI spec. But, P= I 1.7 errata A is not published yet. So, this patch set is for edk2-staging= first? I review the code logic. For SMM part, SmmIpl still installs current Smm= Communication protocol. So, this change is totally compatible. Right? Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ard Biesh= euvel > Sent: Friday, November 22, 2019 4:32 PM > To: devel@edk2.groups.io > Cc: leif.lindholm@linaro.org; Ard Biesheuvel = ; piwg@uefi.org; kimon.berlin@hp.com; eugene@hp.com > Subject: [edk2-devel] [PATCH 0/6] PIWG M1993 - implement EFI_MM_COMMUNIC= ATE2_PROTOCOL >=20 > As discussed in the PIWG call on 21 November, I am sending out my > implementation of the MM communicate 2 protocol for review. It is > intended to work around the impedance mismatch between traditional > SMM (which uses physical addresses in the communication between DXE > components) and standalone MM (which uses virtual addresses) >=20 > The solution presented here is to introduce a new protocol that takes > both addresses, forcing the clients to pass both, but freeing them > from the responsibility to reason about which kind of address to pass: > this becomes the responsibility of the MM_COMMUNICATE implementation, > which is where it belongs. >=20 > Cc: piwg@uefi.org > Cc: kimon.berlin@hp.com > Cc: eugene@hp.com >=20 > Ard Biesheuvel (6): > MdePkg: introduce MM communicate 2 protocol > MdeModulePkg/SmmIpl: expose MM communicate 2 protocol > ArmPkg/MmCommunicationDxe: expose MM Communicate 2 protocol > MdeModulePkg/VariableInfo: switch to MM communicate 2 protocol > MdeModulePkg/FaultTolerantWriteSmmDxe: switch to MM communicate 2 > protocol > MdeModulePkg/VariableSmmRuntimeDxe: switch to MM communicate 2 > protocol >=20 > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c = | 83 +++++++++----------- > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf = | 6 +- > MdeModulePkg/Application/VariableInfo/VariableInfo.c = | 19 +++-- > MdeModulePkg/Application/VariableInfo/VariableInfo.inf = | 2 +- > MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c = | 79 +++++++++++++++++++ > MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf = | 1 + > MdeModulePkg/Include/Guid/SmmVariableCommon.h = | 6 +- > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmCommo= n.h | 2 +- > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmDxe.c= | 25 +++--- > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmDxe.h= | 2 +- > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmDxe.i= nf | 4 +- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c = | 39 ++++----- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.inf = | 4 +- > MdePkg/Include/Protocol/MmCommunication2.h = | 69 ++++++++++++++++ > MdePkg/MdePkg.dec = | 7 ++ > 15 files changed, 254 insertions(+), 94 deletions(-) > create mode 100644 MdePkg/Include/Protocol/MmCommunication2.h >=20 > -- > 2.20.1 >=20 >=20 >=20