From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.4881.1574692597079271676 for ; Mon, 25 Nov 2019 06:36:37 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Nov 2019 06:36:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,241,1571727600"; d="scan'208";a="239555866" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 25 Nov 2019 06:36:35 -0800 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 25 Nov 2019 06:36:35 -0800 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 25 Nov 2019 06:36:35 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.127]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.200]) with mapi id 14.03.0439.000; Mon, 25 Nov 2019 22:36:32 +0800 From: "Liming Gao" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Wang, Jian J" , "Wu, Hao A" Subject: Re: [PATCH V2 1/2] MdeModulePkg/Variable: Initialize local variable "Variable" Thread-Topic: [PATCH V2 1/2] MdeModulePkg/Variable: Initialize local variable "Variable" Thread-Index: AQHVoL/Ui/0E2HyhpkWt8vc4CApw9aeb+WsA Date: Mon, 25 Nov 2019 14:36:32 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E5483E4@SHSMSX104.ccr.corp.intel.com> References: <20191121230236.29668-1-michael.a.kubacki@intel.com> <20191121230236.29668-2-michael.a.kubacki@intel.com> In-Reply-To: <20191121230236.29668-2-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOThmNWI4ZTYtNGUyYy00MDdkLTllNzktYThmMmFhNjM0NDFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUXRFTHRzRlJnS3FIdzJiMHk5S3d1XC95aFwvRkxTQVwvdTk0ekJsWlN0UjB4V2RhaFV0SGNEQ3dzdWszempjcVwvSzgifQ== dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Create PR https://github.com/tianocore/edk2/pull/197, and=20 push @290a485d6043a049b611aab30f450c74b8591f35..bd85bf54c268204c7a698a96f3c= cd96cd77952cd Thanks Liming > -----Original Message----- > From: Kubacki, Michael A > Sent: Friday, November 22, 2019 7:03 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D ; Wang, Jian J ; Wu, > Hao A > Subject: [PATCH V2 1/2] MdeModulePkg/Variable: Initialize local variable = "Variable" >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2364 >=20 > Fixes a new build warning in VS2012 introduced in f8ff4cca7c. >=20 > This patch initializes the local variable "Variable" in > VariableServiceGetNextVariableInternal (). >=20 > This ensures the pointers in the structure are initialized > in the case no variable stores exist in the list of variable > stores. >=20 > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Michael Kubacki > Reviewed-by: Liming Gao > Reviewed-by: Philippe Mathieu-Daude > Reviewed-by: Jian J Wang > --- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c > b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c > index d458f1c608..f6d187543d 100644 > --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c > +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableParsing.c > @@ -551,6 +551,8 @@ VariableServiceGetNextVariableInternal ( > return EFI_INVALID_PARAMETER; > } >=20 > + ZeroMem (&Variable, sizeof (Variable)); > + > // Check if the variable exists in the given variable store list > for (StoreType =3D (VARIABLE_STORE_TYPE) 0; StoreType < VariableStoreT= ypeMax; StoreType++) { > if (VariableStoreList[StoreType] =3D=3D NULL) { > -- > 2.16.2.windows.1