Re: [edk2-devel] [PATCH v2 1/3] MdePkg-UefiSpec.h: Add UEFI 2.8 RuntimeServicesSuppported definations

["Liming Gao" <liming.gao@intel.com>]

The change is good. And, please remove Change-Id: in the commit message. 
Last, have you submitted BZ for it? 

Thanks
Liming
>-----Original Message-----
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Jeff Brasen
>Sent: Thursday, November 28, 2019 7:25 AM
>To: devel@edk2.groups.io
>Cc: Gao, Liming <liming.gao@intel.com>; Kinney, Michael D
><michael.d.kinney@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray
><ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>;
>jbrasen@nvidia.com
>Subject: [edk2-devel] [PATCH v2 1/3] MdePkg-UefiSpec.h: Add UEFI 2.8
>RuntimeServicesSuppported definations
>
>Add bitmask values for the value of the RuntimeServicesSupported
>variable defined in the UEFI 2.8 specification. This is used to describe
>what services the platform supports while in runtime.
>
>Change-Id: I7ff0fcdb856b4d2e4ba90a08291f8980e2f66375
>Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
>---
> MdePkg/Include/Uefi/UefiSpec.h | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
>diff --git a/MdePkg/Include/Uefi/UefiSpec.h
>b/MdePkg/Include/Uefi/UefiSpec.h
>index 444aa35..7e2b719 100644
>--- a/MdePkg/Include/Uefi/UefiSpec.h
>+++ b/MdePkg/Include/Uefi/UefiSpec.h
>@@ -1783,6 +1783,24 @@ EFI_STATUS
> #define EFI_OS_INDICATIONS_START_PLATFORM_RECOVERY
>0x0000000000000040
>
> //
>+// Bitmasks of supported runtime functions for RuntimeServicesSupported
>variable
>+//
>+#define EFI_RT_SUPPORTED_GET_TIME                           0x0001
>+#define EFI_RT_SUPPORTED_SET_TIME                           0x0002
>+#define EFI_RT_SUPPORTED_GET_WAKEUP_TIME                    0x0004
>+#define EFI_RT_SUPPORTED_SET_WAKEUP_TIME                    0x0008
>+#define EFI_RT_SUPPORTED_GET_VARIABLE                       0x0010
>+#define EFI_RT_SUPPORTED_GET_NEXT_VARIABLE_NAME             0x0020
>+#define EFI_RT_SUPPORTED_SET_VARIABLE                       0x0040
>+#define EFI_RT_SUPPORTED_SET_VIRTUAL_ADDRESS_MAP            0x0080
>+#define EFI_RT_SUPPORTED_CONVERT_POINTER                    0x0100
>+#define EFI_RT_SUPPORTED_GET_NEXT_HIGH_MONOTONIC_COUNT
>0x0200
>+#define EFI_RT_SUPPORTED_RESET_SYSTEM                       0x0400
>+#define EFI_RT_SUPPORTED_UPDATE_CAPSULE                     0x0800
>+#define EFI_RT_SUPPORTED_QUERY_CAPSULE_CAPABILITIES         0x1000
>+#define EFI_RT_SUPPORTED_QUERY_VARIABLE_INFO                0x2000
>+
>+//
> // EFI Runtime Services Table
> //
> #define EFI_SYSTEM_TABLE_SIGNATURE      SIGNATURE_64 ('I','B','I','
>','S','Y','S','T')
>--
>2.7.4
>
>
>