From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.4121.1575848109789855701 for ; Sun, 08 Dec 2019 15:35:10 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Dec 2019 15:35:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,293,1571727600"; d="scan'208";a="209952590" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga008.fm.intel.com with ESMTP; 08 Dec 2019 15:35:08 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 8 Dec 2019 15:35:08 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 8 Dec 2019 15:35:08 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.72]) with mapi id 14.03.0439.000; Mon, 9 Dec 2019 07:35:06 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Feng, Bob C" Subject: Re: [edk2-devel] [Patch 0/4 V6] Enhance Incremental Build Thread-Topic: [edk2-devel] [Patch 0/4 V6] Enhance Incremental Build Thread-Index: AQHVrEms0i+agcTYwk2OemFjs04AWKew55/w Date: Sun, 8 Dec 2019 23:35:06 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E55D9C8@SHSMSX104.ccr.corp.intel.com> References: <20191206152658.26476-1-bob.c.feng@intel.com> In-Reply-To: <20191206152658.26476-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMjFmZWRhZGUtMGI2Zi00YmJiLTgyYjMtMzZlZDY3YjY4ZGYzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUWJvMjVES21KZWYrTjJreFdrSThMWldUM1pHdmttXC9FaG9rMEorTU9qYWpmTzVFODNJRFBwbHJ6RDFBZ095eFkifQ== dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Bob Feng > Sent: Friday, December 6, 2019 11:27 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch 0/4 V6] Enhance Incremental Build >=20 > V6: Add notes for RVCT tool chain that it is not enabled incremental bui= ld feature > V5: Document how to enable or disable dependency file list generation > for a tool chain. > V4: Move .deps files to where corresponding .obj file locate > V3: Change CLANG9 to CLANGPDB according to commit 14672c34bd > V2: Fixed a bug in patch 4/4. >=20 > Incremental build reduces the build time by only building > the module that need to update. Edk2 Build system is a Makefile > based build system. The incrememtal build ability is provided by > the Make program. But Edk2 build tool need to generate correct makefile > to have Make program do incremental build correctly. >=20 > The current solution in build tool to support incremental build is that = build > tool find out the include file list for each source file of a module, an= d in module's > makefile, build tool add the include file list as the source file's depe= ndency. > In this way Make program can decide if it need to rebuild a source code = by checking > its dependency. This solution has 2 shortcommings, one is the process of= finding > include list is slow, the other is this method can't handle case that > a MACRO in #include statement so the related source file is always built= . >=20 > This patch provides another method to support incremental build. That is= to use > c preprocessor and trim tool to generate dependency files for the source= file. > This method will save much time in AutoGen phase and handle MACRO in #in= clude correctly. >=20 > For C files: > 1. MSVS. > cl.exe has a build option /showIncludes to display include files= on stdout. Build tool captures > that messages and generate dependency files, .deps files. > 2. CLANG and GCC > -MMD -MF build option are used to generate dependency files by p= reprocessor. Build tool updates the > .deps files. >=20 > For ASL files: > 1. Trim find out all the included files, which are asl specific incl= ude format, and generate .trim.deps file. > 2. ASL PP use c preprocessor to find out all included files with #in= clude format and generate a .deps file > 3. build tool updates the .deps file >=20 > For ASM files (.asm, .s or .nasm): > 1. Trim find out all the included files, which are asm specific incl= ude format, and generate .trim.deps file. > 2. ASM PP use c preprocessor to find out all included files with #in= clude format and generate a deps file > 3. build tool updates the .deps file >=20 > Build tool add "include" instruction for those deps files in the Makefil= e. >=20 > This patch does not support RVCT tool chain for the BZ https://bugzilla.= tianocore.org/show_bug.cgi?id=3D1750 >=20 > Feng, Bob C (4): > BaseTools: Add build option for dependency file generation > BaseTools: Generate dependent files for ASL and ASM files > BaseTools: Update build_rule.txt to generate dependent files. > BaseTools: Enhance Basetool for incremental build >=20 > BaseTools/Conf/build_rule.template | 94 ++++--- > BaseTools/Conf/tools_def.template | 173 ++++++------ > BaseTools/Source/Python/AutoGen/GenMake.py | 83 ++---- > .../Source/Python/AutoGen/IncludesAutoGen.py | 255 ++++++++++++++++++ > .../Source/Python/AutoGen/ModuleAutoGen.py | 23 ++ > BaseTools/Source/Python/Trim/Trim.py | 115 ++++++-- > BaseTools/Source/Python/build/build.py | 63 ++++- > 7 files changed, 588 insertions(+), 218 deletions(-) > create mode 100644 BaseTools/Source/Python/AutoGen/IncludesAutoGen.py >=20 > -- > 2.20.1.windows.1 >=20 >=20 >=20