From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.362.1576046394968614474 for ; Tue, 10 Dec 2019 22:39:55 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Dec 2019 22:39:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,301,1571727600"; d="scan'208";a="264753292" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 10 Dec 2019 22:39:54 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 10 Dec 2019 22:39:54 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 10 Dec 2019 22:39:11 -0800 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 10 Dec 2019 22:39:10 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.236]) with mapi id 14.03.0439.000; Wed, 11 Dec 2019 14:38:50 +0800 From: "Liming Gao" To: "Kubacki, Michael A" , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Wang, Jian J" , "Wu, Hao A" Subject: Re: [PATCH V2 0/2] MdeModulePkg PeiCore: Fix grammatical errors Thread-Topic: [PATCH V2 0/2] MdeModulePkg PeiCore: Fix grammatical errors Thread-Index: AQHVpV1nAGzQS9PkWEmBQptGP1N6Kae0kIyg Date: Wed, 11 Dec 2019 06:38:49 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E56442B@SHSMSX104.ccr.corp.intel.com> References: <20191127195747.3192-1-michael.a.kubacki@intel.com> In-Reply-To: <20191127195747.3192-1-michael.a.kubacki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao >-----Original Message----- >From: Kubacki, Michael A >Sent: Thursday, November 28, 2019 3:58 AM >To: devel@edk2.groups.io >Cc: Bi, Dandan ; Gao, Liming ; >Wang, Jian J ; Wu, Hao A >Subject: [PATCH V2 0/2] MdeModulePkg PeiCore: Fix grammatical errors > >V2 Changes: > * "The index of the FV to search." to "Index of the FV to search" > in the "Instance" parameter of ProcessFvFile () > * Removed "in this FV format" in the function description of > AddUnknownFormatFvInfo () > * Explicitly stated the implied subject noun in the commit message > of patch 2/2 > >This patch series fixes grammatical errors in the PeiCore module. > >Originally, this was sent as a single patch which received two >Reviewed-by responses: >https://edk2.groups.io/g/devel/message/50841 > >However, a suggestion was made to split the patch into syntactical >and semantical changes. That suggestion is implemented in this >series. > >The Reviewed-by responses were not carried forward so the maintainers >can evaluate this series as a whole. The previous patch has been >dropped. > >Cc: Dandan Bi >Cc: Liming Gao >Cc: Jian J Wang >Cc: Hao A Wu >Signed-off-by: Michael Kubacki > >Michael Kubacki (2): > MdeModulePkg PeiCore: Fix typos > MdeModulePkg PeiCore: Improve comment semantics > > MdeModulePkg/Core/Pei/PeiMain.inf | 10 +-- > MdeModulePkg/Core/Pei/FwVol/FwVol.h | 23 +++---- > MdeModulePkg/Core/Pei/PeiMain.h | 49 +++++++-------- > MdeModulePkg/Core/Pei/Dependency/Dependency.c | 12 ++-- > MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 52 ++++++++-------- > MdeModulePkg/Core/Pei/FwVol/FwVol.c | 64 ++++++++++---------- > MdeModulePkg/Core/Pei/Hob/Hob.c | 4 +- > MdeModulePkg/Core/Pei/Image/Image.c | 10 +-- > MdeModulePkg/Core/Pei/Memory/MemoryServices.c | 18 +++--- > MdeModulePkg/Core/Pei/PeiMain/PeiMain.c | 2 +- > MdeModulePkg/Core/Pei/Ppi/Ppi.c | 4 +- > MdeModulePkg/Core/Pei/Security/Security.c | 12 ++-- > 12 files changed, 132 insertions(+), 128 deletions(-) > >-- >2.16.2.windows.1