From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.4948.1576148612100530227 for ; Thu, 12 Dec 2019 03:03:32 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Dec 2019 03:03:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,305,1571727600"; d="scan'208";a="220669957" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 12 Dec 2019 03:03:30 -0800 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 12 Dec 2019 03:03:30 -0800 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 12 Dec 2019 03:03:30 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.164]) with mapi id 14.03.0439.000; Thu, 12 Dec 2019 19:03:28 +0800 From: "Liming Gao" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , Vitaly Cheptsov Subject: Re: [edk2-devel] [PATCH V2 0/2] MdePkg/UefiDevicePathLib: Separate the lib instances Thread-Topic: [edk2-devel] [PATCH V2 0/2] MdePkg/UefiDevicePathLib: Separate the lib instances Thread-Index: AQHVsJFtAsQcHkGstkyXy62X5jj7nqe18j8wgAAEvYCAAD+KcIAAH8jA Date: Thu, 12 Dec 2019 11:03:28 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E564EF8@SHSMSX104.ccr.corp.intel.com> References: <20191212020922.14620-1-zhichao.gao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E564B61@SHSMSX104.ccr.corp.intel.com> <15DF888FBF57C8A4.14754@groups.io> <3CE959C139B4C44DBEA1810E3AA6F9000B8936F5@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B8936F5@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODM2N2I3NmUtZDczZS00ODMzLWExN2YtMTM5NWM4MTY0NDRhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZU5sbzFzcGJpUTlsU0hoNGJtRzBTT2Q1a2N4anJGRXJ2ZmZuYmdGNlRpdFpST2xTMW90TTl1TTZieE5UMkdzcCJ9 dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for your test. Reviewed-by: Liming Gao > -----Original Message----- > From: Gao, Zhichao > Sent: Thursday, December 12, 2019 5:15 PM > To: devel@edk2.groups.io; Gao, Zhichao ; Gao, Lim= ing > Cc: Kinney, Michael D ; Vitaly Cheptsov > Subject: RE: [edk2-devel] [PATCH V2 0/2] MdePkg/UefiDevicePathLib: Separ= ate the lib instances >=20 > I have ported a test case from SCT to test the interfaces in UefiDeviceP= athLibMandatoryDevicePathProtocol.c and > UefiDevicePathLibOptionalDevicePathProtocol.c only. > And I do the test on Ovmf environment for two configuration: one is incl= ude DevicePathDxe, and the other is not. > Optional one lib test cases would always passed. > Mandatory one lib test case would passed with Ovmf with DevicePathDxe, a= nd ASSERT with the other. >=20 > The test result is expected. > Tested-by: Zhichao Gao >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Gao, Zhichao > > Sent: Thursday, December 12, 2019 1:29 PM > > To: Gao, Liming ; devel@edk2.groups.io > > Cc: Kinney, Michael D ; Vitaly Cheptsov > > > > Subject: Re: [edk2-devel] [PATCH V2 0/2] MdePkg/UefiDevicePathLib: > > Separate the lib instances > > > > Actually I didn't do the functionality test of Mandatory one, only do = the build > > test and logic check. It is part of the Optional one. I assume the opt= ional one > > is working fine. Then there would be no problem with Mandatory one. > > I would write a test for both of them to make sure they are both fine. > > > > Thanks, > > Zhichao > > > > > -----Original Message----- > > > From: Gao, Liming > > > Sent: Thursday, December 12, 2019 1:05 PM > > > To: Gao, Zhichao ; devel@edk2.groups.io > > > Cc: Kinney, Michael D ; Vitaly Cheptsov > > > > > > Subject: RE: [PATCH V2 0/2] MdePkg/UefiDevicePathLib: Separate the l= ib > > > instances > > > > > > Zhichao: > > > The change is good. What functionality test is done? > > > > > > Thanks > > > Liming > > > >-----Original Message----- > > > >From: Gao, Zhichao > > > >Sent: Thursday, December 12, 2019 10:09 AM > > > >To: devel@edk2.groups.io > > > >Cc: Kinney, Michael D ; Gao, Liming > > > >; Vitaly Cheptsov > > > >Subject: [PATCH V2 0/2] MdePkg/UefiDevicePathLib: Separate the lib > > > >instances > > > > > > > >REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2298 > > > > > > > >The UefiDevicePathLibOptionalDevicePathProtocolConstructor's > > > >implementation > > > >isn't match with its instance name. > > > >Remove the ASSERT and depex of the > > > >gEfiDevicePathUtilitiesProtocolGuid > > > >because of "Optional". > > > > > > > >Add a mandatory instance to force using the DevicePathUtilities, > > > >DevicePathToText and DevicePathFromText protocol with the ASSERT an= d > > > >depex. > > > > > > > >V2: > > > >The optional lib instance's construction should return success all > > > >the time. > > > >Change the desciption of the optional lib uni file. > > > >Change the copyright date of the mandatory one's uni file. > > > > > > > >Cc: Michael D Kinney > > > >Cc: Liming Gao > > > >Cc: Vitaly Cheptsov > > > >Signed-off-by: Zhichao Gao > > > > > > > >Zhichao Gao (2): > > > > MdePkg/UefiDevicePathLib: Separate the device path lib > > > > MdePkg/dsc: Add UefiDevicePathLibMandatoryDevicePathProtocol for > > > >build > > > > > > > > ...DevicePathLibMandatoryDevicePathProtocol.c | 469 > > > >++++++++++++++++++ > > > > ...vicePathLibMandatoryDevicePathProtocol.inf | 86 ++++ > > > >...vicePathLibMandatoryDevicePathProtocol.uni | 18 + > > > > ...iDevicePathLibOptionalDevicePathProtocol.c | 9 +- > > > > ...evicePathLibOptionalDevicePathProtocol.inf | 5 +- > > > > ...evicePathLibOptionalDevicePathProtocol.uni | 6 +- > > > > MdePkg/MdePkg.dsc | 3 +- > > > > 7 files changed, 582 insertions(+), 14 deletions(-) create mode > > > >100644 > > > > > >MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibMandatoryDevicePa > > > th > > > >Protocol.c > > > > create mode 100644 > > > > > >MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibMandatoryDevicePa > > > th > > > >Protocol.inf > > > > create mode 100644 > > > > > >MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibMandatoryDevicePa > > > th > > > >Protocol.uni > > > > > > > >-- > > > >2.21.0.windows.1 > > > > > >=20