From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.5621.1576635312334729789 for ; Tue, 17 Dec 2019 18:15:12 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2019 18:15:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,327,1571727600"; d="scan'208";a="212567402" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga007.fm.intel.com with ESMTP; 17 Dec 2019 18:15:12 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 17 Dec 2019 18:15:11 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.46]) with mapi id 14.03.0439.000; Wed, 18 Dec 2019 10:15:10 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Feng, Bob C" CC: "Shi, Steven" Subject: Re: [edk2-devel] [Patch 1/1] BaseTools: Remove PCD_TOKEN define for FixedAtBuild PCD Thread-Topic: [edk2-devel] [Patch 1/1] BaseTools: Remove PCD_TOKEN define for FixedAtBuild PCD Thread-Index: AQHVtUgh/z942PfQy02QWXCbiHEtPae/Jyvw Date: Wed, 18 Dec 2019 02:15:09 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E567451@SHSMSX104.ccr.corp.intel.com> References: <20191218020854.49000-1-bob.c.feng@intel.com> In-Reply-To: <20191218020854.49000-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Bob: PatchInModule and FeaturePcd don't use Token. Does this patch remove the= token generation for them? Thanks Liming >-----Original Message----- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Bob Feng >Sent: Wednesday, December 18, 2019 10:09 AM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Shi, Steven >Subject: [edk2-devel] [Patch 1/1] BaseTools: Remove PCD_TOKEN define for >FixedAtBuild PCD > >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2426 > >Build tool generate PCD_TOKEN_xxx Macro for FixedAtBuild Pcd >in Autogen.c and Autogen.h but there is no code use that Macro, >so this patch is going to remove this Macro from autogen files. > >This change can improve incremental build function. > >Cc: Liming Gao >Cc: Steven Shi >Signed-off-by: Bob Feng >--- > BaseTools/Source/Python/AutoGen/GenC.py | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > >diff --git a/BaseTools/Source/Python/AutoGen/GenC.py >b/BaseTools/Source/Python/AutoGen/GenC.py >index 5e0d11e165a3..3ec1a950fadc 100755 >--- a/BaseTools/Source/Python/AutoGen/GenC.py >+++ b/BaseTools/Source/Python/AutoGen/GenC.py >@@ -911,11 +911,12 @@ def CreateModulePcdCode(Info, AutoGenC, >AutoGenH, Pcd): > EdkLogger.error("build", AUTOGEN_ERROR, > "No generated token number for %s.%s\n" = % >(Pcd.TokenSpaceGuidCName, TokenCName), > ExtraData=3D"[%s]" % str(Info)) > else: > TokenNumber =3D PcdTokenNumber[Pcd.TokenCName, >Pcd.TokenSpaceGuidCName] >- AutoGenH.Append('\n#define %s %dU\n' % (PcdTokenName, >TokenNumber)) >+ if Pcd.Type in PCD_DYNAMIC_TYPE_SET: >+ AutoGenH.Append('\n#define %s %dU\n' % (PcdTokenName, >TokenNumber)) > > EdkLogger.debug(EdkLogger.DEBUG_3, "Creating code for " + TokenCName >+ "." + Pcd.TokenSpaceGuidCName) > if Pcd.Type not in gItemTypeStringDatabase: > EdkLogger.error("build", AUTOGEN_ERROR, > "Unknown PCD type [%s] of PCD %s.%s" % (Pcd.Type= , >Pcd.TokenSpaceGuidCName, TokenCName), >@@ -1236,11 +1237,12 @@ def CreateLibraryPcdCode(Info, AutoGenC, >AutoGenH, Pcd): > AutoGenH.Append('#define %s(SizeOfBuffer, Buffer) >LibPcdSetEx%sS(&%s, %s, (SizeOfBuffer), (Buffer))\n' % >(SetModeStatusName, DatumSizeLib, Pcd.TokenSpaceGuidCName, >PcdTokenName)) > else: > AutoGenH.Append('#define %s(Value) LibPcdSetEx%s(&%s, %= s, >(Value))\n' % (SetModeName, DatumSizeLib, Pcd.TokenSpaceGuidCName, >PcdTokenName)) > AutoGenH.Append('#define %s(Value) LibPcdSetEx%sS(&%s, = %s, >(Value))\n' % (SetModeStatusName, DatumSizeLib, >Pcd.TokenSpaceGuidCName, PcdTokenName)) > else: >- AutoGenH.Append('#define _PCD_TOKEN_%s %dU\n' % (TokenCName, >TokenNumber)) >+ if Pcd.Type in PCD_DYNAMIC_TYPE_SET: >+ AutoGenH.Append('#define _PCD_TOKEN_%s %dU\n' % >(TokenCName, TokenNumber)) > if PcdItemType in PCD_DYNAMIC_TYPE_SET: > PcdList =3D [] > PcdCNameList =3D [] > PcdList.extend(Info.LibraryPcdList) > PcdList.extend(Info.ModulePcdList) >-- >2.20.1.windows.1 > > >