From: "Liming Gao" <liming.gao@intel.com>
To: "Banaszek, Daniel Pawel" <daniel.pawel.banaszek@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>
Subject: Re: ASAP Issue in PciExpress21.h
Date: Wed, 18 Dec 2019 14:29:32 +0000 [thread overview]
Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E567B7A@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <F5F808F35CD2604094D883EDBD44909B5556A82E@irsmsx112.ger.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1954 bytes --]
I just send the patch mail to the mail list https://edk2.groups.io/g/devel/message/52350. Please review this one.
Thanks
Liming
From: Banaszek, Daniel Pawel <daniel.pawel.banaszek@intel.com>
Sent: Wednesday, December 18, 2019 4:37 PM
To: devel@edk2.groups.io
Cc: Gao, Liming <liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
Subject: RE: ASAP Issue in PciExpress21.h
Importance: High
I attached a patch witch change that is needed in EDK2 code as it is described.
PCI_REG_PCIE_DEVICE_CONTROL2 struct is UINT16 but has 17 bits !!
Issue is UINT16 LtrMechanism
There is 2 instead of 1.
- UINT16 LtrMechanism : 2;
+ UINT16 LtrMechanism : 1;
Daniel Banaszek
BIOS Engineer - IGK1-245
Intel Server UEFI Firmware Development Team
______________________________________________________________________________
From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>
Sent: Monday, 2 December, 2019 15:45
To: Banaszek, Daniel Pawel <daniel.pawel.banaszek@intel.com<mailto:daniel.pawel.banaszek@intel.com>>
Cc: Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>
Subject: RE: ASAP Issue in PciExpress21.h
Daniel,
thank you for finding such a critical issue.
Can you please submit an open source patch for this?
Thanks,
Ray
From: Banaszek, Daniel Pawel <daniel.pawel.banaszek@intel.com<mailto:daniel.pawel.banaszek@intel.com>>
Sent: Monday, December 2, 2019 6:54 PM
To: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>
Subject: ASAP Issue in PciExpress21.h
Hi
There I an issue in
MdePkg/Include/IndustryStandard/PciExpress21.h
PCI_REG_PCIE_DEVICE_CONTROL2 struct is UINT16 but has 17 bits !!
Issue is UINT16 LtrMechanism
There is 2 instead of 1.
- UINT16 LtrMechanism : 2;
+ UINT16 LtrMechanism : 1;
Who can commit the change?
Thanks
Daniel Banaszek
BIOS Engineer - IGK1-245
Intel Server UEFI Firmware Development Team
Intel Technology Poland Sp. z o.o.
[-- Attachment #2: Type: text/html, Size: 9329 bytes --]
prev parent reply other threads:[~2019-12-18 14:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <F5F808F35CD2604094D883EDBD44909B5553F073@irsmsx112.ger.corp.intel.com>
[not found] ` <734D49CCEBEEF84792F5B80ED585239D5C389063@SHSMSX104.ccr.corp.intel.com>
2019-12-18 8:36 ` ASAP Issue in PciExpress21.h Banaszek, Daniel Pawel
2019-12-18 14:29 ` Liming Gao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A89E2EF3DFEDB4C8BFDE51014F606A14E567B7A@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox