I just send the patch mail to the mail list https://edk2.groups.io/g/devel/message/52350. Please review this one.

 

Thanks

Liming

From: Banaszek, Daniel Pawel <daniel.pawel.banaszek@intel.com>
Sent: Wednesday, December 18, 2019 4:37 PM
To: devel@edk2.groups.io
Cc: Gao, Liming <liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
Subject: RE: ASAP Issue in PciExpress21.h
Importance: High

 

I attached a patch witch change that is needed in EDK2 code as it is described.

 

PCI_REG_PCIE_DEVICE_CONTROL2 struct is UINT16 but has 17 bits !!

 

Issue is UINT16 LtrMechanism

There is 2 instead of 1.

-    UINT16 LtrMechanism : 2;

+    UINT16 LtrMechanism : 1;

 

 

 

Daniel Banaszek

BIOS Engineer – IGK1-245

Intel Server UEFI Firmware Development Team

______________________________________________________________________________

 

From: Ni, Ray <ray.ni@intel.com>
Sent: Monday, 2 December, 2019 15:45
To: Banaszek, Daniel Pawel <daniel.pawel.banaszek@intel.com>
Cc: Gao, Liming <liming.gao@intel.com>
Subject: RE: ASAP Issue in PciExpress21.h

 

Daniel,

thank you for finding such a critical issue.

Can you please submit an open source patch for this?

 

Thanks,

Ray

 

 

From: Banaszek, Daniel Pawel <daniel.pawel.banaszek@intel.com>
Sent: Monday, December 2, 2019 6:54 PM
To: Ni, Ray <ray.ni@intel.com>
Subject: ASAP Issue in PciExpress21.h

 

Hi

There I an issue in

MdePkg/Include/IndustryStandard/PciExpress21.h

 

PCI_REG_PCIE_DEVICE_CONTROL2 struct is UINT16 but has 17 bits !!

 

Issue is UINT16 LtrMechanism

There is 2 instead of 1.

-    UINT16 LtrMechanism : 2;

+    UINT16 LtrMechanism : 1;

 

Who can commit the change?

 

Thanks

Daniel Banaszek

BIOS Engineer – IGK1-245

Intel Server UEFI Firmware Development Team

Intel Technology Poland Sp. z o.o.