From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web12.11193.1576679377324385338 for ; Wed, 18 Dec 2019 06:29:37 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2019 06:29:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,329,1571727600"; d="scan'208,217";a="365760492" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga004.jf.intel.com with ESMTP; 18 Dec 2019 06:29:36 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Dec 2019 06:29:35 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Dec 2019 06:29:34 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by shsmsx102.ccr.corp.intel.com ([169.254.2.109]) with mapi id 14.03.0439.000; Wed, 18 Dec 2019 22:29:32 +0800 From: "Liming Gao" To: "Banaszek, Daniel Pawel" , "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: ASAP Issue in PciExpress21.h Thread-Topic: ASAP Issue in PciExpress21.h Thread-Index: AdWo/dsoRNStWlG3RdynV5VYlDmDbwAIMMVgAxe/25AADHgz0A== Date: Wed, 18 Dec 2019 14:29:32 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E567B7A@SHSMSX104.ccr.corp.intel.com> References: <734D49CCEBEEF84792F5B80ED585239D5C389063@SHSMSX104.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODM0YzU1NTMtZmYxYy00M2FlLTg1OTUtM2NlMWFiOTZmM2I4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibFNscEZuZTdiUTNTYzBDajZDcGV5TFdHWlVMd0pGM3VvQ2dcL012TEcxS0dvdTZPU0dFMExTRkoxUWpJSVwvYVwvVyJ9 dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_4A89E2EF3DFEDB4C8BFDE51014F606A14E567B7ASHSMSX104ccrcor_" --_000_4A89E2EF3DFEDB4C8BFDE51014F606A14E567B7ASHSMSX104ccrcor_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I just send the patch mail to the mail list https://edk2.groups.io/g/devel/= message/52350. Please review this one. Thanks Liming From: Banaszek, Daniel Pawel Sent: Wednesday, December 18, 2019 4:37 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Ni, Ray Subject: RE: ASAP Issue in PciExpress21.h Importance: High I attached a patch witch change that is needed in EDK2 code as it is descri= bed. PCI_REG_PCIE_DEVICE_CONTROL2 struct is UINT16 but has 17 bits !! Issue is UINT16 LtrMechanism There is 2 instead of 1. - UINT16 LtrMechanism : 2; + UINT16 LtrMechanism : 1; Daniel Banaszek BIOS Engineer - IGK1-245 Intel Server UEFI Firmware Development Team ___________________________________________________________________________= ___ From: Ni, Ray > Sent: Monday, 2 December, 2019 15:45 To: Banaszek, Daniel Pawel > Cc: Gao, Liming > Subject: RE: ASAP Issue in PciExpress21.h Daniel, thank you for finding such a critical issue. Can you please submit an open source patch for this? Thanks, Ray From: Banaszek, Daniel Pawel > Sent: Monday, December 2, 2019 6:54 PM To: Ni, Ray > Subject: ASAP Issue in PciExpress21.h Hi There I an issue in MdePkg/Include/IndustryStandard/PciExpress21.h PCI_REG_PCIE_DEVICE_CONTROL2 struct is UINT16 but has 17 bits !! Issue is UINT16 LtrMechanism There is 2 instead of 1. - UINT16 LtrMechanism : 2; + UINT16 LtrMechanism : 1; Who can commit the change? Thanks Daniel Banaszek BIOS Engineer - IGK1-245 Intel Server UEFI Firmware Development Team Intel Technology Poland Sp. z o.o. --_000_4A89E2EF3DFEDB4C8BFDE51014F606A14E567B7ASHSMSX104ccrcor_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

I ju= st send the patch mail to the mail list https://edk2.groups.io/g/devel/message/52350. Please review t= his one.

 

Thanks

Liming

From: Banaszek, Daniel Pawel <da= niel.pawel.banaszek@intel.com>
Sent: Wednesday, December 18, 2019 4:37 PM
To: devel@edk2.groups.io
Cc: Gao, Liming <liming.gao@intel.com>; Ni, Ray <ray.ni@int= el.com>
Subject: RE: ASAP Issue in PciExpress21.h
Importance: High

 

I attached a patch witch change= that is needed in EDK2 code as it is described.

 

PCI_REG_PCIE_DEVICE_CONTROL2= struct is UINT16 but has 17 bits !!

 

Issue is UINT16 LtrMechanism

There is 2 instead of 1.

-    UINT16 LtrM= echanism : 2;

+    UINT16 = LtrMechanism : 1;

 

 

 

Daniel Banaszek

BIOS Engineer – IGK1-245

Intel Server UEFI Firmware Development Team

_______________________________= _______________________________________________

 

From: Ni, Ray <ray.ni@intel.co= m>
Sent: Monday, 2 December, 2019 15:45
To: Banaszek, Daniel Pawel <daniel.pawel.banaszek@intel.com>
Cc: Gao, Liming <liming.g= ao@intel.com>
Subject: RE: ASAP Issue in PciExpress21.h

 

Daniel,

thank you for finding such a cr= itical issue.

Can you please submit an open s= ource patch for this?

 

Thanks,

Ray

 

 

From: Banaszek, Daniel Pawel <daniel.pawel.banaszek@intel.com>
Sent: Monday, December 2, 2019 6:54 PM
To: Ni, Ray <ray.ni@intel.com= >
Subject: ASAP Issue in PciExpress21.h

 

Hi

There I an issue in =

MdePkg/Include/IndustryStandard= /PciExpress21.h

 

PCI_REG_PCIE_DEVICE_CONTROL2 st= ruct is UINT16 but has 17 bits !!

 

Issue is UINT16 LtrMechanism

There is 2 instead of 1.

-    UINT16 LtrM= echanism : 2;

+    UINT16 = LtrMechanism : 1;

 

Who can commit the change?=

 

Thanks

Daniel Banaszek

BIOS Engineer – IGK1-245

Intel Server UEFI Firmware Development Team

Intel Technology Poland Sp. z o.o.

 

--_000_4A89E2EF3DFEDB4C8BFDE51014F606A14E567B7ASHSMSX104ccrcor_--