Re: ASAP Issue in PciExpress21.h

Re: ASAP Issue in PciExpress21.h

[Banaszek, Daniel Pawel]

[-- Attachment #1.1: Type: text/plain, Size: 2308 bytes --]

I attached a patch witch change that is needed in EDK2 code as it is described.

PCI_REG_PCIE_DEVICE_CONTROL2 struct is UINT16 but has 17 bits !!

Issue is UINT16 LtrMechanism
There is 2 instead of 1.
-    UINT16 LtrMechanism : 2;
+    UINT16 LtrMechanism : 1;



Daniel Banaszek
BIOS Engineer - IGK1-245
Intel Server UEFI Firmware Development Team
______________________________________________________________________________

From: Ni, Ray <ray.ni@intel.com>
Sent: Monday, 2 December, 2019 15:45
To: Banaszek, Daniel Pawel <daniel.pawel.banaszek@intel.com>
Cc: Gao, Liming <liming.gao@intel.com>
Subject: RE: ASAP Issue in PciExpress21.h

Daniel,
thank you for finding such a critical issue.
Can you please submit an open source patch for this?

Thanks,
Ray


From: Banaszek, Daniel Pawel <daniel.pawel.banaszek@intel.com<mailto:daniel.pawel.banaszek@intel.com>>
Sent: Monday, December 2, 2019 6:54 PM
To: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>
Subject: ASAP Issue in PciExpress21.h

Hi
There I an issue in
MdePkg/Include/IndustryStandard/PciExpress21.h

PCI_REG_PCIE_DEVICE_CONTROL2 struct is UINT16 but has 17 bits !!

Issue is UINT16 LtrMechanism
There is 2 instead of 1.
-    UINT16 LtrMechanism : 2;
+    UINT16 LtrMechanism : 1;

Who can commit the change?

Thanks
Daniel Banaszek
BIOS Engineer - IGK1-245
Intel Server UEFI Firmware Development Team
Intel Technology Poland Sp. z o.o.

--------------------------------------------------------------------

Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.

[-- Attachment #1.2: Type: text/html, Size: 8029 bytes --]

[-- Attachment #2: 18c9006.diff.zip --]
[-- Type: application/x-zip-compressed, Size: 690 bytes --]

Re: ASAP Issue in PciExpress21.h

[Liming Gao]

[-- Attachment #1: Type: text/plain, Size: 1954 bytes --]

I just send the patch mail to the mail list https://edk2.groups.io/g/devel/message/52350. Please review this one.

Thanks
Liming
From: Banaszek, Daniel Pawel <daniel.pawel.banaszek@intel.com>
Sent: Wednesday, December 18, 2019 4:37 PM
To: devel@edk2.groups.io
Cc: Gao, Liming <liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
Subject: RE: ASAP Issue in PciExpress21.h
Importance: High

I attached a patch witch change that is needed in EDK2 code as it is described.

PCI_REG_PCIE_DEVICE_CONTROL2 struct is UINT16 but has 17 bits !!

Issue is UINT16 LtrMechanism
There is 2 instead of 1.
-    UINT16 LtrMechanism : 2;
+    UINT16 LtrMechanism : 1;



Daniel Banaszek
BIOS Engineer - IGK1-245
Intel Server UEFI Firmware Development Team
______________________________________________________________________________

From: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>
Sent: Monday, 2 December, 2019 15:45
To: Banaszek, Daniel Pawel <daniel.pawel.banaszek@intel.com<mailto:daniel.pawel.banaszek@intel.com>>
Cc: Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>
Subject: RE: ASAP Issue in PciExpress21.h

Daniel,
thank you for finding such a critical issue.
Can you please submit an open source patch for this?

Thanks,
Ray


From: Banaszek, Daniel Pawel <daniel.pawel.banaszek@intel.com<mailto:daniel.pawel.banaszek@intel.com>>
Sent: Monday, December 2, 2019 6:54 PM
To: Ni, Ray <ray.ni@intel.com<mailto:ray.ni@intel.com>>
Subject: ASAP Issue in PciExpress21.h

Hi
There I an issue in
MdePkg/Include/IndustryStandard/PciExpress21.h

PCI_REG_PCIE_DEVICE_CONTROL2 struct is UINT16 but has 17 bits !!

Issue is UINT16 LtrMechanism
There is 2 instead of 1.
-    UINT16 LtrMechanism : 2;
+    UINT16 LtrMechanism : 1;

Who can commit the change?

Thanks
Daniel Banaszek
BIOS Engineer - IGK1-245
Intel Server UEFI Firmware Development Team
Intel Technology Poland Sp. z o.o.


[-- Attachment #2: Type: text/html, Size: 9329 bytes --]