* [PATCH] MdePkg/Spdm: fix Nonce structure error.
@ 2019-12-18 3:00 Yao, Jiewen
2019-12-18 14:31 ` Liming Gao
0 siblings, 1 reply; 4+ messages in thread
From: Yao, Jiewen @ 2019-12-18 3:00 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2427
Align to SPDM 1.0.0 specification.
Fix Nonce data structure error.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <liming.gao@intel.com>
Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
---
MdePkg/Include/IndustryStandard/Spdm.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/MdePkg/Include/IndustryStandard/Spdm.h b/MdePkg/Include/IndustryStandard/Spdm.h
index c05395fea7..38ec7748a7 100644
--- a/MdePkg/Include/IndustryStandard/Spdm.h
+++ b/MdePkg/Include/IndustryStandard/Spdm.h
@@ -1,6 +1,6 @@
/** @file
Definitions of Security Protocol & Data Model Specification (SPDM)
- version 0.99a in Distributed Management Task Force (DMTF).
+ version 1.0.0 in Distributed Management Task Force (DMTF).
Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
@@ -215,7 +215,7 @@ typedef struct {
///
typedef struct {
SPDM_MESSAGE_HEADER Header;
- UINT32 Nonce;
+ UINT8 Nonce[32];
} SPDM_CHALLENGE_REQUEST;
///
@@ -224,7 +224,7 @@ typedef struct {
typedef struct {
SPDM_MESSAGE_HEADER Header;
//UINT8 CertChainHash[DigestSize];
-//UINT32 Nonce;
+//UINT8 Nonce[32];
//UINT8 MeasurementSummaryHash[DigestSize];
//UINT16 OpaqueLength;
//UINT8 OpaqueData[OpaqueLength];
@@ -236,7 +236,7 @@ typedef struct {
///
typedef struct {
SPDM_MESSAGE_HEADER Header;
- UINT32 Nonce;
+ UINT8 Nonce[32];
} SPDM_GET_MEASUREMENTS_REQUEST;
///
@@ -277,7 +277,7 @@ typedef struct {
UINT8 NumberOfBlocks;
UINT8 MeasurementRecordLength[3];
//UINT8 MeasurementRecord[MeasurementRecordLength];
-//UINT32 Nonce;
+//UINT8 Nonce[32];
//UINT16 OpaqueLength;
//UINT8 OpaqueData[OpaqueLength];
//UINT8 Signature[KeySize];
--
2.19.2.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] MdePkg/Spdm: fix Nonce structure error.
2019-12-18 3:00 [PATCH] MdePkg/Spdm: fix Nonce structure error Yao, Jiewen
@ 2019-12-18 14:31 ` Liming Gao
2019-12-18 22:31 ` Yao, Jiewen
0 siblings, 1 reply; 4+ messages in thread
From: Liming Gao @ 2019-12-18 14:31 UTC (permalink / raw)
To: Yao, Jiewen, devel@edk2.groups.io; +Cc: Kinney, Michael D
Jiewen:
The change is good. Have you found any impact in the existing code?
Reviewed-by: Liming Gao <liming.gao@intel.com>
Thanks
Liming
> -----Original Message-----
> From: Yao, Jiewen <jiewen.yao@intel.com>
> Sent: Wednesday, December 18, 2019 11:00 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] MdePkg/Spdm: fix Nonce structure error.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2427
>
> Align to SPDM 1.0.0 specification.
> Fix Nonce data structure error.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
> ---
> MdePkg/Include/IndustryStandard/Spdm.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/MdePkg/Include/IndustryStandard/Spdm.h b/MdePkg/Include/IndustryStandard/Spdm.h
> index c05395fea7..38ec7748a7 100644
> --- a/MdePkg/Include/IndustryStandard/Spdm.h
> +++ b/MdePkg/Include/IndustryStandard/Spdm.h
> @@ -1,6 +1,6 @@
> /** @file
> Definitions of Security Protocol & Data Model Specification (SPDM)
> - version 0.99a in Distributed Management Task Force (DMTF).
> + version 1.0.0 in Distributed Management Task Force (DMTF).
>
> Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -215,7 +215,7 @@ typedef struct {
> ///
> typedef struct {
> SPDM_MESSAGE_HEADER Header;
> - UINT32 Nonce;
> + UINT8 Nonce[32];
> } SPDM_CHALLENGE_REQUEST;
>
> ///
> @@ -224,7 +224,7 @@ typedef struct {
> typedef struct {
> SPDM_MESSAGE_HEADER Header;
> //UINT8 CertChainHash[DigestSize];
> -//UINT32 Nonce;
> +//UINT8 Nonce[32];
> //UINT8 MeasurementSummaryHash[DigestSize];
> //UINT16 OpaqueLength;
> //UINT8 OpaqueData[OpaqueLength];
> @@ -236,7 +236,7 @@ typedef struct {
> ///
> typedef struct {
> SPDM_MESSAGE_HEADER Header;
> - UINT32 Nonce;
> + UINT8 Nonce[32];
> } SPDM_GET_MEASUREMENTS_REQUEST;
>
> ///
> @@ -277,7 +277,7 @@ typedef struct {
> UINT8 NumberOfBlocks;
> UINT8 MeasurementRecordLength[3];
> //UINT8 MeasurementRecord[MeasurementRecordLength];
> -//UINT32 Nonce;
> +//UINT8 Nonce[32];
> //UINT16 OpaqueLength;
> //UINT8 OpaqueData[OpaqueLength];
> //UINT8 Signature[KeySize];
> --
> 2.19.2.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MdePkg/Spdm: fix Nonce structure error.
2019-12-18 14:31 ` Liming Gao
@ 2019-12-18 22:31 ` Yao, Jiewen
2019-12-19 1:16 ` Liming Gao
0 siblings, 1 reply; 4+ messages in thread
From: Yao, Jiewen @ 2019-12-18 22:31 UTC (permalink / raw)
To: Gao, Liming, devel@edk2.groups.io; +Cc: Kinney, Michael D
No impact.
Current code does not use Nonce.
I just find the issue when I review the final 1.0 spec.
Thank you
Yao Jiewen
> -----Original Message-----
> From: Gao, Liming <liming.gao@intel.com>
> Sent: Wednesday, December 18, 2019 10:32 PM
> To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: RE: [PATCH] MdePkg/Spdm: fix Nonce structure error.
>
> Jiewen:
> The change is good. Have you found any impact in the existing code?
>
> Reviewed-by: Liming Gao <liming.gao@intel.com>
>
> Thanks
> Liming
> > -----Original Message-----
> > From: Yao, Jiewen <jiewen.yao@intel.com>
> > Sent: Wednesday, December 18, 2019 11:00 AM
> > To: devel@edk2.groups.io
> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>
> > Subject: [PATCH] MdePkg/Spdm: fix Nonce structure error.
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2427
> >
> > Align to SPDM 1.0.0 specification.
> > Fix Nonce data structure error.
> >
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
> > ---
> > MdePkg/Include/IndustryStandard/Spdm.h | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/MdePkg/Include/IndustryStandard/Spdm.h
> b/MdePkg/Include/IndustryStandard/Spdm.h
> > index c05395fea7..38ec7748a7 100644
> > --- a/MdePkg/Include/IndustryStandard/Spdm.h
> > +++ b/MdePkg/Include/IndustryStandard/Spdm.h
> > @@ -1,6 +1,6 @@
> > /** @file
> > Definitions of Security Protocol & Data Model Specification (SPDM)
> > - version 0.99a in Distributed Management Task Force (DMTF).
> > + version 1.0.0 in Distributed Management Task Force (DMTF).
> >
> > Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> > SPDX-License-Identifier: BSD-2-Clause-Patent
> > @@ -215,7 +215,7 @@ typedef struct {
> > ///
> > typedef struct {
> > SPDM_MESSAGE_HEADER Header;
> > - UINT32 Nonce;
> > + UINT8 Nonce[32];
> > } SPDM_CHALLENGE_REQUEST;
> >
> > ///
> > @@ -224,7 +224,7 @@ typedef struct {
> > typedef struct {
> > SPDM_MESSAGE_HEADER Header;
> > //UINT8 CertChainHash[DigestSize];
> > -//UINT32 Nonce;
> > +//UINT8 Nonce[32];
> > //UINT8 MeasurementSummaryHash[DigestSize];
> > //UINT16 OpaqueLength;
> > //UINT8 OpaqueData[OpaqueLength];
> > @@ -236,7 +236,7 @@ typedef struct {
> > ///
> > typedef struct {
> > SPDM_MESSAGE_HEADER Header;
> > - UINT32 Nonce;
> > + UINT8 Nonce[32];
> > } SPDM_GET_MEASUREMENTS_REQUEST;
> >
> > ///
> > @@ -277,7 +277,7 @@ typedef struct {
> > UINT8 NumberOfBlocks;
> > UINT8 MeasurementRecordLength[3];
> > //UINT8 MeasurementRecord[MeasurementRecordLength];
> > -//UINT32 Nonce;
> > +//UINT8 Nonce[32];
> > //UINT16 OpaqueLength;
> > //UINT8 OpaqueData[OpaqueLength];
> > //UINT8 Signature[KeySize];
> > --
> > 2.19.2.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] MdePkg/Spdm: fix Nonce structure error.
2019-12-18 22:31 ` Yao, Jiewen
@ 2019-12-19 1:16 ` Liming Gao
0 siblings, 0 replies; 4+ messages in thread
From: Liming Gao @ 2019-12-19 1:16 UTC (permalink / raw)
To: Yao, Jiewen, devel@edk2.groups.io; +Cc: Kinney, Michael D
That's good. Thanks!
>-----Original Message-----
>From: Yao, Jiewen
>Sent: Thursday, December 19, 2019 6:32 AM
>To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io
>Cc: Kinney, Michael D <michael.d.kinney@intel.com>
>Subject: RE: [PATCH] MdePkg/Spdm: fix Nonce structure error.
>
>No impact.
>Current code does not use Nonce.
>I just find the issue when I review the final 1.0 spec.
>
>Thank you
>Yao Jiewen
>
>> -----Original Message-----
>> From: Gao, Liming <liming.gao@intel.com>
>> Sent: Wednesday, December 18, 2019 10:32 PM
>> To: Yao, Jiewen <jiewen.yao@intel.com>; devel@edk2.groups.io
>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>
>> Subject: RE: [PATCH] MdePkg/Spdm: fix Nonce structure error.
>>
>> Jiewen:
>> The change is good. Have you found any impact in the existing code?
>>
>> Reviewed-by: Liming Gao <liming.gao@intel.com>
>>
>> Thanks
>> Liming
>> > -----Original Message-----
>> > From: Yao, Jiewen <jiewen.yao@intel.com>
>> > Sent: Wednesday, December 18, 2019 11:00 AM
>> > To: devel@edk2.groups.io
>> > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
>> <liming.gao@intel.com>
>> > Subject: [PATCH] MdePkg/Spdm: fix Nonce structure error.
>> >
>> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2427
>> >
>> > Align to SPDM 1.0.0 specification.
>> > Fix Nonce data structure error.
>> >
>> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
>> > Cc: Liming Gao <liming.gao@intel.com>
>> > Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
>> > ---
>> > MdePkg/Include/IndustryStandard/Spdm.h | 10 +++++-----
>> > 1 file changed, 5 insertions(+), 5 deletions(-)
>> >
>> > diff --git a/MdePkg/Include/IndustryStandard/Spdm.h
>> b/MdePkg/Include/IndustryStandard/Spdm.h
>> > index c05395fea7..38ec7748a7 100644
>> > --- a/MdePkg/Include/IndustryStandard/Spdm.h
>> > +++ b/MdePkg/Include/IndustryStandard/Spdm.h
>> > @@ -1,6 +1,6 @@
>> > /** @file
>> > Definitions of Security Protocol & Data Model Specification (SPDM)
>> > - version 0.99a in Distributed Management Task Force (DMTF).
>> > + version 1.0.0 in Distributed Management Task Force (DMTF).
>> >
>> > Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
>> > SPDX-License-Identifier: BSD-2-Clause-Patent
>> > @@ -215,7 +215,7 @@ typedef struct {
>> > ///
>> > typedef struct {
>> > SPDM_MESSAGE_HEADER Header;
>> > - UINT32 Nonce;
>> > + UINT8 Nonce[32];
>> > } SPDM_CHALLENGE_REQUEST;
>> >
>> > ///
>> > @@ -224,7 +224,7 @@ typedef struct {
>> > typedef struct {
>> > SPDM_MESSAGE_HEADER Header;
>> > //UINT8 CertChainHash[DigestSize];
>> > -//UINT32 Nonce;
>> > +//UINT8 Nonce[32];
>> > //UINT8 MeasurementSummaryHash[DigestSize];
>> > //UINT16 OpaqueLength;
>> > //UINT8 OpaqueData[OpaqueLength];
>> > @@ -236,7 +236,7 @@ typedef struct {
>> > ///
>> > typedef struct {
>> > SPDM_MESSAGE_HEADER Header;
>> > - UINT32 Nonce;
>> > + UINT8 Nonce[32];
>> > } SPDM_GET_MEASUREMENTS_REQUEST;
>> >
>> > ///
>> > @@ -277,7 +277,7 @@ typedef struct {
>> > UINT8 NumberOfBlocks;
>> > UINT8 MeasurementRecordLength[3];
>> > //UINT8 MeasurementRecord[MeasurementRecordLength];
>> > -//UINT32 Nonce;
>> > +//UINT8 Nonce[32];
>> > //UINT16 OpaqueLength;
>> > //UINT8 OpaqueData[OpaqueLength];
>> > //UINT8 Signature[KeySize];
>> > --
>> > 2.19.2.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-19 1:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-18 3:00 [PATCH] MdePkg/Spdm: fix Nonce structure error Yao, Jiewen
2019-12-18 14:31 ` Liming Gao
2019-12-18 22:31 ` Yao, Jiewen
2019-12-19 1:16 ` Liming Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox