From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web09.11025.1576679498713167757 for ; Wed, 18 Dec 2019 06:31:38 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2019 06:31:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,329,1571727600"; d="scan'208";a="205859186" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga007.jf.intel.com with ESMTP; 18 Dec 2019 06:31:37 -0800 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Dec 2019 06:31:37 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Dec 2019 06:31:36 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.72]) with mapi id 14.03.0439.000; Wed, 18 Dec 2019 22:31:35 +0800 From: "Liming Gao" To: "Yao, Jiewen" , "devel@edk2.groups.io" CC: "Kinney, Michael D" Subject: Re: [PATCH] MdePkg/Spdm: fix Nonce structure error. Thread-Topic: [PATCH] MdePkg/Spdm: fix Nonce structure error. Thread-Index: AQHVtU9dd2bYlZ7Y/02wckVDAh6hs6e/9Nvg Date: Wed, 18 Dec 2019 14:31:35 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E567B89@SHSMSX104.ccr.corp.intel.com> References: <20191218030018.18560-1-jiewen.yao@intel.com> In-Reply-To: <20191218030018.18560-1-jiewen.yao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDk1YzBjOTctMzhhNy00Y2RjLTlmN2EtOGM2Mzc2NWIyNDU2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTDdIT0R4VzFvWk50OUFTR2hNYUNvM2NkWUp1OU9ZVVpUTlwvbUxvd3Y3Z0NRamFLaXFpWnZRK0htcGREMHMrY1YifQ== dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jiewen: The change is good. Have you found any impact in the existing code? Reviewed-by: Liming Gao Thanks Liming > -----Original Message----- > From: Yao, Jiewen > Sent: Wednesday, December 18, 2019 11:00 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > Subject: [PATCH] MdePkg/Spdm: fix Nonce structure error. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2427 >=20 > Align to SPDM 1.0.0 specification. > Fix Nonce data structure error. >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Signed-off-by: Jiewen Yao > --- > MdePkg/Include/IndustryStandard/Spdm.h | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/MdePkg/Include/IndustryStandard/Spdm.h b/MdePkg/Include/Indu= stryStandard/Spdm.h > index c05395fea7..38ec7748a7 100644 > --- a/MdePkg/Include/IndustryStandard/Spdm.h > +++ b/MdePkg/Include/IndustryStandard/Spdm.h > @@ -1,6 +1,6 @@ > /** @file > Definitions of Security Protocol & Data Model Specification (SPDM) > - version 0.99a in Distributed Management Task Force (DMTF). > + version 1.0.0 in Distributed Management Task Force (DMTF). >=20 > Copyright (c) 2019, Intel Corporation. All rights reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -215,7 +215,7 @@ typedef struct { > /// > typedef struct { > SPDM_MESSAGE_HEADER Header; > - UINT32 Nonce; > + UINT8 Nonce[32]; > } SPDM_CHALLENGE_REQUEST; >=20 > /// > @@ -224,7 +224,7 @@ typedef struct { > typedef struct { > SPDM_MESSAGE_HEADER Header; > //UINT8 CertChainHash[DigestSize]; > -//UINT32 Nonce; > +//UINT8 Nonce[32]; > //UINT8 MeasurementSummaryHash[DigestSize]; > //UINT16 OpaqueLength; > //UINT8 OpaqueData[OpaqueLength]; > @@ -236,7 +236,7 @@ typedef struct { > /// > typedef struct { > SPDM_MESSAGE_HEADER Header; > - UINT32 Nonce; > + UINT8 Nonce[32]; > } SPDM_GET_MEASUREMENTS_REQUEST; >=20 > /// > @@ -277,7 +277,7 @@ typedef struct { > UINT8 NumberOfBlocks; > UINT8 MeasurementRecordLength[3]; > //UINT8 MeasurementRecord[MeasurementRecordLength]; > -//UINT32 Nonce; > +//UINT8 Nonce[32]; > //UINT16 OpaqueLength; > //UINT8 OpaqueData[OpaqueLength]; > //UINT8 Signature[KeySize]; > -- > 2.19.2.windows.1