From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.4261.1576718177337897201 for ; Wed, 18 Dec 2019 17:16:17 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2019 17:16:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,330,1571727600"; d="scan'208";a="218326196" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga003.jf.intel.com with ESMTP; 18 Dec 2019 17:16:16 -0800 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Dec 2019 17:16:07 -0800 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Dec 2019 17:16:07 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.236]) with mapi id 14.03.0439.000; Thu, 19 Dec 2019 09:16:05 +0800 From: "Liming Gao" To: "Yao, Jiewen" , "devel@edk2.groups.io" CC: "Kinney, Michael D" Subject: Re: [PATCH] MdePkg/Spdm: fix Nonce structure error. Thread-Topic: [PATCH] MdePkg/Spdm: fix Nonce structure error. Thread-Index: AQHVtU9dd2bYlZ7Y/02wckVDAh6hs6e/9NvggACGF2CAAC4rUA== Date: Thu, 19 Dec 2019 01:16:05 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E567F16@SHSMSX104.ccr.corp.intel.com> References: <20191218030018.18560-1-jiewen.yao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E567B89@SHSMSX104.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F8AB313@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503F8AB313@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable That's good. Thanks! >-----Original Message----- >From: Yao, Jiewen >Sent: Thursday, December 19, 2019 6:32 AM >To: Gao, Liming ; devel@edk2.groups.io >Cc: Kinney, Michael D >Subject: RE: [PATCH] MdePkg/Spdm: fix Nonce structure error. > >No impact. >Current code does not use Nonce. >I just find the issue when I review the final 1.0 spec. > >Thank you >Yao Jiewen > >> -----Original Message----- >> From: Gao, Liming >> Sent: Wednesday, December 18, 2019 10:32 PM >> To: Yao, Jiewen ; devel@edk2.groups.io >> Cc: Kinney, Michael D >> Subject: RE: [PATCH] MdePkg/Spdm: fix Nonce structure error. >> >> Jiewen: >> The change is good. Have you found any impact in the existing code? >> >> Reviewed-by: Liming Gao >> >> Thanks >> Liming >> > -----Original Message----- >> > From: Yao, Jiewen >> > Sent: Wednesday, December 18, 2019 11:00 AM >> > To: devel@edk2.groups.io >> > Cc: Kinney, Michael D ; Gao, Liming >> >> > Subject: [PATCH] MdePkg/Spdm: fix Nonce structure error. >> > >> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2427 >> > >> > Align to SPDM 1.0.0 specification. >> > Fix Nonce data structure error. >> > >> > Cc: Michael D Kinney >> > Cc: Liming Gao >> > Signed-off-by: Jiewen Yao >> > --- >> > MdePkg/Include/IndustryStandard/Spdm.h | 10 +++++----- >> > 1 file changed, 5 insertions(+), 5 deletions(-) >> > >> > diff --git a/MdePkg/Include/IndustryStandard/Spdm.h >> b/MdePkg/Include/IndustryStandard/Spdm.h >> > index c05395fea7..38ec7748a7 100644 >> > --- a/MdePkg/Include/IndustryStandard/Spdm.h >> > +++ b/MdePkg/Include/IndustryStandard/Spdm.h >> > @@ -1,6 +1,6 @@ >> > /** @file >> > Definitions of Security Protocol & Data Model Specification (SPDM) >> > - version 0.99a in Distributed Management Task Force (DMTF). >> > + version 1.0.0 in Distributed Management Task Force (DMTF). >> > >> > Copyright (c) 2019, Intel Corporation. All rights reserved.
>> > SPDX-License-Identifier: BSD-2-Clause-Patent >> > @@ -215,7 +215,7 @@ typedef struct { >> > /// >> > typedef struct { >> > SPDM_MESSAGE_HEADER Header; >> > - UINT32 Nonce; >> > + UINT8 Nonce[32]; >> > } SPDM_CHALLENGE_REQUEST; >> > >> > /// >> > @@ -224,7 +224,7 @@ typedef struct { >> > typedef struct { >> > SPDM_MESSAGE_HEADER Header; >> > //UINT8 CertChainHash[DigestSize]; >> > -//UINT32 Nonce; >> > +//UINT8 Nonce[32]; >> > //UINT8 MeasurementSummaryHash[DigestSize]; >> > //UINT16 OpaqueLength; >> > //UINT8 OpaqueData[OpaqueLength]; >> > @@ -236,7 +236,7 @@ typedef struct { >> > /// >> > typedef struct { >> > SPDM_MESSAGE_HEADER Header; >> > - UINT32 Nonce; >> > + UINT8 Nonce[32]; >> > } SPDM_GET_MEASUREMENTS_REQUEST; >> > >> > /// >> > @@ -277,7 +277,7 @@ typedef struct { >> > UINT8 NumberOfBlocks; >> > UINT8 MeasurementRecordLength[3]; >> > //UINT8 MeasurementRecord[MeasurementRecordLength]; >> > -//UINT32 Nonce; >> > +//UINT8 Nonce[32]; >> > //UINT16 OpaqueLength; >> > //UINT8 OpaqueData[OpaqueLength]; >> > //UINT8 Signature[KeySize]; >> > -- >> > 2.19.2.windows.1