* [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits
@ 2019-12-18 14:27 Liming Gao
2019-12-18 14:48 ` [edk2-devel] " Javeed, Ashraf
2019-12-19 2:21 ` Ni, Ray
0 siblings, 2 replies; 6+ messages in thread
From: Liming Gao @ 2019-12-18 14:27 UTC (permalink / raw)
To: devel; +Cc: Daniel Pawel Banaszek, Ray Ni
From: Daniel Pawel Banaszek <daniel.pawel.banaszek@intel.com>
Device Control 2 Structure have an issue.
LtrMechanism - there is 2 bits instead of 1.
Signed-off-by: Daniel Pawel Banaszek <daniel.pawel.banaszek@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
---
MdePkg/Include/IndustryStandard/PciExpress21.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdePkg/Include/IndustryStandard/PciExpress21.h b/MdePkg/Include/IndustryStandard/PciExpress21.h
index f17f570775..2c07cb560e 100644
--- a/MdePkg/Include/IndustryStandard/PciExpress21.h
+++ b/MdePkg/Include/IndustryStandard/PciExpress21.h
@@ -304,7 +304,7 @@ typedef union {
UINT16 AtomicOpEgressBlocking : 1;
UINT16 IdoRequest : 1;
UINT16 IdoCompletion : 1;
- UINT16 LtrMechanism : 2;
+ UINT16 LtrMechanism : 1;
UINT16 EmergencyPowerReductionRequest : 1;
UINT16 TenBitTagRequesterEnable : 1;
UINT16 Obff : 2;
--
2.13.0.windows.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits
2019-12-18 14:27 [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits Liming Gao
@ 2019-12-18 14:48 ` Javeed, Ashraf
2019-12-18 14:54 ` Javeed, Ashraf
2019-12-19 2:21 ` Ni, Ray
1 sibling, 1 reply; 6+ messages in thread
From: Javeed, Ashraf @ 2019-12-18 14:48 UTC (permalink / raw)
To: Gao, Liming, devel
[-- Attachment #1: Type: text/plain, Size: 117 bytes --]
Good catch!
Please rename the LtrMechanism to LtrMechanismEnable to match with the PCI Base Specification.
Thanks
[-- Attachment #2: Type: text/html, Size: 125 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits
2019-12-18 14:48 ` [edk2-devel] " Javeed, Ashraf
@ 2019-12-18 14:54 ` Javeed, Ashraf
2019-12-18 14:56 ` Liming Gao
0 siblings, 1 reply; 6+ messages in thread
From: Javeed, Ashraf @ 2019-12-18 14:54 UTC (permalink / raw)
To: Javeed, Ashraf, devel
[-- Attachment #1: Type: text/plain, Size: 136 bytes --]
I want to withdraw my request as by renaming it would cause build failures in the code that is already using this register definition.
[-- Attachment #2: Type: text/html, Size: 136 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits
2019-12-18 14:54 ` Javeed, Ashraf
@ 2019-12-18 14:56 ` Liming Gao
0 siblings, 0 replies; 6+ messages in thread
From: Liming Gao @ 2019-12-18 14:56 UTC (permalink / raw)
To: devel@edk2.groups.io, Javeed, Ashraf
[-- Attachment #1: Type: text/plain, Size: 523 bytes --]
Yes. We keep the same name to avoid the incompatible issue.
Thanks
Liming
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Javeed, Ashraf
Sent: Wednesday, December 18, 2019 10:55 PM
To: Javeed; Javeed, Ashraf <ashraf.javeed@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits
I want to withdraw my request as by renaming it would cause build failures in the code that is already using this register definition.
[-- Attachment #2: Type: text/html, Size: 3885 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits
2019-12-18 14:27 [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits Liming Gao
2019-12-18 14:48 ` [edk2-devel] " Javeed, Ashraf
@ 2019-12-19 2:21 ` Ni, Ray
2019-12-19 14:57 ` Liming Gao
1 sibling, 1 reply; 6+ messages in thread
From: Ni, Ray @ 2019-12-19 2:21 UTC (permalink / raw)
To: Gao, Liming, devel
[-- Attachment #1: Type: text/plain, Size: 40 bytes --]
Reviewed-by: Ray Ni <ray.ni@intel.com>
[-- Attachment #2: Type: text/html, Size: 99 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [edk2-devel] [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits
2019-12-19 2:21 ` Ni, Ray
@ 2019-12-19 14:57 ` Liming Gao
0 siblings, 0 replies; 6+ messages in thread
From: Liming Gao @ 2019-12-19 14:57 UTC (permalink / raw)
To: Ni, Ray, devel@edk2.groups.io
[-- Attachment #1: Type: text/plain, Size: 367 bytes --]
Merge @665afccc52e1a02ee329147e02f04b8e9cf1d571
From: Ni, Ray <ray.ni@intel.com>
Sent: Thursday, December 19, 2019 10:22 AM
To: Gao; Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io
Subject: Re: [edk2-devel] [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits
Reviewed-by: Ray Ni ray.ni@intel.com<mailto:ray.ni@intel.com>
[-- Attachment #2: Type: text/html, Size: 3410 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-19 14:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-18 14:27 [Patch] MdePkg PciExpress21: PCI_REG_PCIE_DEVICE_CONTROL2 struct has 17 bits Liming Gao
2019-12-18 14:48 ` [edk2-devel] " Javeed, Ashraf
2019-12-18 14:54 ` Javeed, Ashraf
2019-12-18 14:56 ` Liming Gao
2019-12-19 2:21 ` Ni, Ray
2019-12-19 14:57 ` Liming Gao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox