From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.4675.1577061938200587930 for ; Sun, 22 Dec 2019 16:45:38 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Dec 2019 16:45:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,345,1571727600"; d="scan'208";a="214098487" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga008.fm.intel.com with ESMTP; 22 Dec 2019 16:45:37 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 22 Dec 2019 16:45:37 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 22 Dec 2019 16:45:36 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 22 Dec 2019 16:45:36 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.90]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.222]) with mapi id 14.03.0439.000; Mon, 23 Dec 2019 08:45:35 +0800 From: "Liming Gao" To: "Feng, Bob C" , "devel@edk2.groups.io" CC: Kilian Kegel Subject: Re: [Patch] GenBiosId: Fixed a regression bug introduced by 8b72f720d53e Thread-Topic: [Patch] GenBiosId: Fixed a regression bug introduced by 8b72f720d53e Thread-Index: AQHVtxFVX8nt5rXF70eFHU4jO8DQC6fG5mdg Date: Mon, 23 Dec 2019 00:45:34 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E56925C@SHSMSX104.ccr.corp.intel.com> References: <20191220084130.18488-1-bob.c.feng@intel.com> In-Reply-To: <20191220084130.18488-1-bob.c.feng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODUwNzcyMTItYTA0ZC00YTNiLThkMmMtMWEwNDkwYzI4MjUxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiT2lESGUySUZwZE94NWdxSjV6T0VjUHppUlBhNVNiRExweHhnUlpyV0VSRW1Hb0NQaFJ6dDU1K3dPUHphTjM4RSJ9 dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao > -----Original Message----- > From: Feng, Bob C > Sent: Friday, December 20, 2019 4:42 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kilian Kegel > Subject: [Patch] GenBiosId: Fixed a regression bug introduced by 8b72f720= d53e >=20 > 8b72f720d53e introduced a regression bug that make GenBiosId > failed if -ot is passed to this tool. >=20 > This patch is going to fix it. >=20 > Cc: Liming Gao > Cc: Kilian Kegel > Signed-off-by: Bob Feng > --- > Platform/Intel/Tools/GenBiosId/GenBiosId.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/Tools/GenBiosId/GenBiosId.py b/Platform/Intel= /Tools/GenBiosId/GenBiosId.py > index 8cecb1c76f..f823fdcad1 100644 > --- a/Platform/Intel/Tools/GenBiosId/GenBiosId.py > +++ b/Platform/Intel/Tools/GenBiosId/GenBiosId.py > @@ -107,11 +107,11 @@ def MyOptionParser(): > return Options >=20 >=20 > # Check the Tool for missing variables > def CheckOptions(Options): > - if len(sys.argv) not in [5,6] and not (len(sys.argv) not in [7,8] an= d Options.OutputTextFile): > + if len(sys.argv) not in [5,6] and not (len(sys.argv) in [7,8] and Op= tions.OutputTextFile): > EdkLogger("GenBiosId", OPTION_MISSING, ExtraData=3D_Usage) > elif not Options.InputFile or not Options.OutputFile: > EdkLogger("GenBiosId", OPTION_MISSING, ExtraData=3D_Usage) > InputFile =3D Options.InputFile > OutputFile =3D Options.OutputFile > -- > 2.20.1.windows.1