From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.197.1578290734483572446 for ; Sun, 05 Jan 2020 22:05:34 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jan 2020 22:05:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,401,1571727600"; d="scan'208";a="422028756" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 05 Jan 2020 22:05:33 -0800 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 5 Jan 2020 22:05:33 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 5 Jan 2020 22:05:32 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.197]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.30]) with mapi id 14.03.0439.000; Mon, 6 Jan 2020 14:05:31 +0800 From: "Liming Gao" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Ni, Ray" , Laszlo Ersek Subject: Re: [Patch V2] edksetup.bat: Simplify the step to use CLANGPDB Thread-Topic: [Patch V2] edksetup.bat: Simplify the step to use CLANGPDB Thread-Index: AQHVtxAQUfdauofwBEuZpJhB1q03AafdQHfw Date: Mon, 6 Jan 2020 06:05:31 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E58A56D@SHSMSX104.ccr.corp.intel.com> References: <20191220083226.130036-1-zhiguang.liu@intel.com> In-Reply-To: <20191220083226.130036-1-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Reviewed-by: Liming Gao -----Original Message----- From: Liu, Zhiguang =20 Sent: 2019=1B$BG/=1B(B12=1B$B7n=1B(B20=1B$BF|=1B(B 16:32 To: devel@edk2.groups.io Cc: Gao, Liming ; Ni, Ray ; Laszlo = Ersek Subject: [Patch V2] edksetup.bat: Simplify the step to use CLANGPDB REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2404 Set the below two environment variables in edksetup.bat: set CLANG_HOST_BIN=3Dn set CLANG_BIN=3DC:\Program Files\LLVM\bin\ In Windows, set CLANG_HOST_BIN= =3Dn to use nmake command The CLANG_BIN is only be set if it is not defined= . Cc: Liming Gao Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Zhiguang Liu --- edksetup.bat | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/edksetup.bat b/edksetup.bat index 024f57a4b7..7b9377aaa5 10075= 5 --- a/edksetup.bat +++ b/edksetup.bat @@ -113,6 +113,18 @@ if not defined NASM_PREFIX ( @if not exist "C:\nasm\nasm.exe" echo Attempting to build modules th= at require NASM will fail. ) =20 +:check_CLANGPDB +@REM In Windows, set CLANG_HOST_BIN=3Dn to use nmake command @set=20 +CLANG_HOST_BIN=3Dn if not defined CLANG_BIN ( + @echo. + @echo !!! WARNING !!! CLANG_BIN environment variable is not set + @if exist "C:\Program Files\LLVM\bin\clang.exe" ( + @set CLANG_BIN=3DC:\Program Files\LLVM\bin\ + @echo Found LLVM, setting CLANG_BIN environment variable to C:\P= rogram Files\LLVM\bin\ + ) +) + :check_cygwin if defined CYGWIN_HOME ( if not exist "%CYGWIN_HOME%" ( -- 2.16.2.windows.1