From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.5703.1578629831184040857 for ; Thu, 09 Jan 2020 20:17:11 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2020 20:17:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,415,1571727600"; d="scan'208";a="224081655" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 09 Jan 2020 20:17:10 -0800 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 20:17:09 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 20:17:09 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.197]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.203]) with mapi id 14.03.0439.000; Fri, 10 Jan 2020 12:17:07 +0800 From: "Liming Gao" To: "Javeed, Ashraf" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Ni, Ray" Subject: Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V8] MdePkg/Protocols: New PCI Express Platform Protocol, EFI encodings Thread-Topic: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V8] MdePkg/Protocols: New PCI Express Platform Protocol, EFI encodings Thread-Index: AQHVx2nHlppc5A2PLUaXqgPOvkU+mKfjRTqQgAADDoA= Date: Fri, 10 Jan 2020 04:17:07 +0000 Message-ID: <4A89E2EF3DFEDB4C8BFDE51014F606A14E58F804@SHSMSX104.ccr.corp.intel.com> References: <15E86A3985A56934.20149@groups.io> <95C5C2B113DE604FB208120C742E98245798B822@BGSMSX101.gar.corp.intel.com> In-Reply-To: <95C5C2B113DE604FB208120C742E98245798B822@BGSMSX101.gar.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDMxNTM2MGUtNWJhOC00NzVmLTlhOWMtMjU1NDkzYjNkZTRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoienc0QzJ0SjFISGk2WE54cCt5MkhMVmZKa2EyK2U4WEt0NXhiN3lQaVVNTmpIQ2dvSDFcL1k4OWhpXC9CUjNOV2NTIn0= dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ashraf: This is new commit bases on original one. Please update patch title and = commit message.=20 Thanks Liming > -----Original Message----- > From: Javeed, Ashraf > Sent: Friday, January 10, 2020 12:00 PM > To: devel@edk2.groups.io; Javeed, Ashraf > Cc: Kinney, Michael D ; Gao, Liming ; Ni, Ray > Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V8] Mde= Pkg/Protocols: New PCI Express Platform Protocol, EFI > encodings >=20 > Hi, > You can also review this patch into the below edk2-staging repo:- > https://github.com/ashrafj/edk2-staging/commit/84ec9f060bab7d5ec97b36367= e87124820694934 >=20 > Thanks > Ashraf >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Javeed, > > Ashraf > > Sent: Friday, January 10, 2020 9:24 AM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D ; Gao, Liming > > ; Ni, Ray > > Subject: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V8] > > MdePkg/Protocols: New PCI Express Platform Protocol, EFI encodings > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1954 > > > > Three interfaces added to PCI Express Platform Protocol:- > > (1) GetDevicePolicy() -> to retrieve device-specific platform policies > > (2) NotifyDeviceState() -> to notify platform about device PCI Express > > configuration state > > (3) GetPolicy() -> to retrieve platform policy about the PCI Express > > feature list > > PCI Express Override Protocol is made alias to PCI Express Platform Pr= otocol. > > EFI encodings introduced for the following PCI Express features, are: > > 1. Maximum Payload Size (MPS) > > 2. Maximum Read Request Size (MRRS) > > 3. Extended Tag > > 4. Relax Order Enable > > 5. No Snoop Enable > > 6. ASPM support > > 7. Common Clock Configuration > > 8. Extended SYNC > > 9. Atomic Op > > 10. LTR Enable > > 11. PTM support > > 12. CTO support > > 13. CPM > > 14. L1 PM Substates > > > > New source files with unique definitions are: > > MdePkg/Include/Protocol/PciExpressPlatform.h, > > MdePkg/Include/Protocol/PciExpressOverride.h > > > > Signed-off-by: Ashraf Javeed > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Ray Ni > > --- > > > > In V8: Code Syntax correction made. > > > > In V7: Revised ECR to define additional interface GetPolicy() in the P= CI Express > > Platform Protocol / PCI Express Override Protocol, Renamed > > EFI_PCI_EXPRESS_PLATFORM_POLICY to EFI_PCI_EXPRESS_DEVICE_POLICY, > > Removed the reserved fields from the EFI_PCI_EXPRESS_DEVICE_POLICY, ad= ded > > input parameter to give the length of input buffer in GetDevicePolicy(= ), and > > NotifyDeviceState(), introduced new data type > > EFI_PCI_EXPRESS_PLATFORM_POLICY for the interface GetPolicy(). > > > > In V6: renamed the protocol definition source files, remove PCD commen= ts, and > > renamed NotifyDeviceConfiguration -> NotifyDeviceState > > > > In V5: Revised ECR to define new PCI Platform Protocol to support the = PCI > > Express capability features:- EFI_PCI_EXPRESS_PLATFORM_PROTOCOL, > > EFI_PCI_EXPRESS_OVERRIDE_PROTOCOL. > > Added new interface -> NotifyDeviceConfiguration Added new EFI encodin= gs / > > data types for PCIe features:- CPM, L1 PM substates. > > Enhance the definition of the PCIe feature AtomicOp to support additio= nal > > attribute - Egress blocking of the port. > > > > In V4: Redefinition of the existing interfaces in the EFI_PCI_PLATFORM= _- > > PROTOCOL2, to avoid type casting and to avoid further future change > > > > In V3: License update in the header sections of source files > > > > In V2: Correction made to header sections of source files > > --- > > MdePkg/Include/Protocol/PciExpressPlatform.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/MdePkg/Include/Protocol/PciExpressPlatform.h > > b/MdePkg/Include/Protocol/PciExpressPlatform.h > > index 8a28418..dc58268 100644 > > --- a/MdePkg/Include/Protocol/PciExpressPlatform.h > > +++ b/MdePkg/Include/Protocol/PciExpressPlatform.h > > @@ -643,11 +643,11 @@ typedef struct { > > **/ > > typedef > > EFI_STATUS > > -(EFIAPI * EFI_PCI_EXPRESS_GET_POLICY) { > > +(EFIAPI * EFI_PCI_EXPRESS_GET_POLICY) ( > > IN CONST EFI_PCI_EXPRESS_PLATFORM_PROTOCOL *This, > > IN UINTN Size, > > IN OUT EFI_PCI_EXPRESS_PLATFORM_POLICY *PlatformPolicy > > -}; > > +); > > > > /// > > /// This protocol provides the interface between the PCI bus driver/P= CI Host > > -- > > 2.21.0.windows.1 > > > > > >=20