From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by mx.groups.io with SMTP id smtpd.web12.14829.1588622894567654996 for ; Mon, 04 May 2020 13:08:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=ppQRW39s; spf=pass (domain: oracle.com, ip: 156.151.31.86, mailfrom: nikita.leshchenko@oracle.com) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 044K7Ymb075147; Mon, 4 May 2020 20:08:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2020-01-29; bh=q4kq2PsozVKzy8qqAQ5vtkD8qzqTDWkOf/s6xjokBG4=; b=ppQRW39sw7O7DEOot3mIsQKN0FBUf00bwRFCyVI9gS6xMf3obr6CQh/mkR+q0LN4jeNf rMpu+YRrfgzGKRdc66tGrgJnKuBpkbZW1EFccYpB6o8MKrHQDyoaHn7nCCcTG9hmC+iL xk0wMww0pYQpSlvgJ0PlvcLmu8jaX0xdws/I4m+zxdc6o/QSuumo18SXaVOmR2NVD3cW qiFePO0sT7tds22XZe32kLjckvnkr4f9tBXjd/yY86ALsHHts9kfM+Luh25WzY5n19jr jJT0YY0f+fXvj7/6klGK173NCvJNTjz9rRH1qyScu1q59ol4nVdQwu3NPRFqrAoALKLa jQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 30s09r152b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 04 May 2020 20:08:10 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 044K7cYA195935; Mon, 4 May 2020 20:08:10 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3030.oracle.com with ESMTP id 30t1r34aur-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 04 May 2020 20:08:10 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 044K88df016812; Mon, 4 May 2020 20:08:08 GMT Received: from [10.30.3.6] (/213.57.127.2) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 04 May 2020 13:08:08 -0700 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: [edk2-devel] [PATCH v5 11/12] OvmfPkg/MptScsiDxe: Implement the PassThru method From: "Nikita Leshenko" In-Reply-To: Date: Mon, 4 May 2020 23:08:03 +0300 Cc: liran.alon@oracle.com, aaron.young@oracle.com, Jordan Justen , Ard Biesheuvel Message-Id: <4C80FE17-0DE2-42FB-ABF3-0A2DD0F9EF6E@oracle.com> References: <20200424175927.41210-1-nikita.leshchenko@oracle.com> <20200424175927.41210-12-nikita.leshchenko@oracle.com> To: devel@edk2.groups.io, lersek@redhat.com X-Mailer: Apple Mail (2.3445.9.1) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9611 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2005040158 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9611 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 malwarescore=0 mlxlogscore=999 phishscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2005040158 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable > On 30 Apr 2020, at 12:47, Laszlo Ersek wrote: >=20 > On 04/24/20 19:59, Nikita Leshenko wrote: >> Machines should be able to boot after this commit. Tested with differen= t >> Linux distributions (Ubuntu, CentOS) and different Windows >> versions (Windows 7, Windows 10, Server 2016). >>=20 >> Ref: https://urldefense.com/v3/__https://bugzilla.tianocore.org/show_bu= g.cgi?id=3D2390__;!!GqivPVa7Brio!NV5JGxsOY-LMe9c_r7p1Ks4Jy755ybGf-hewsLI7te= xgoPDpsKmcin6UpzFlRxCc3tuWtA$=20 >> Signed-off-by: Nikita Leshenko >> [..] >> + >> + } else if ((Reply & BIT31) !=3D 0) { >> + DEBUG ((DEBUG_INFO, "%a: Full reply returned\n", __FUNCTION__)); >=20 > (2) Is this a frequent event? If we expect this to happen frequently, > then it should be DEBUG_VERBOSE. Otherwise (=3D infrequent event), > DEBUG_INFO is fine. In practice this event happens on IO errors, so I assume it won't be frequ= ent, that's why I put it in INFO. >=20 >> [...] >> gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageEventLogBase|0x0|UINT= 32|0x8 >> gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFlashNvStorageEventLogSize|0x0|UINT= 32|0x9 >> gUefiOvmfPkgTokenSpaceGuid.PcdOvmfFirmwareFdSize|0x0|UINT32|0xa >>=20 >=20 > With (1) through (4) addressed: >=20 > Reviewed-by: Laszlo Ersek >=20 > (Well, (1) is a must, (2) through (4) are open for discussion, of course= .) Agree with (3) and (4). I think that the DEBUG_INFO is fine, but I don't m= ind changing it to VERBOSE. Nikita >=20 > Thanks! > Laszlo >=20 >=20 >=20 >=20