From: "Desimone, Ashley E" <ashley.e.desimone@intel.com>
To: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Pandya, Puja" <puja.pandya@intel.com>,
"Bjorge, Erik C" <erik.c.bjorge@intel.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Installer would lists every Python version as obsolete
Date: Tue, 17 Mar 2020 21:42:18 +0000 [thread overview]
Message-ID: <4CF3A9EB60ABDA47BE7821A4DA3A0A3353D58219@ORSMSX116.amr.corp.intel.com> (raw)
In-Reply-To: <20200316173248.1678-1-nathaniel.l.desimone@intel.com>
Reviewed-by: Ashley DeSimone <ashley.e.desimone@intel.com>
-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Sent: Monday, March 16, 2020 10:33 AM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Installer would lists every Python version as obsolete
If a VendorCustomizer is being used, the EdkRepo installer erroneously lists every version of Python as obsolete even though they are not.
Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
edkrepo_installer/EdkRepoInstaller/VendorCustomizer.cs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edkrepo_installer/EdkRepoInstaller/VendorCustomizer.cs b/edkrepo_installer/EdkRepoInstaller/VendorCustomizer.cs
index 622d7ad..da49006 100644
--- a/edkrepo_installer/EdkRepoInstaller/VendorCustomizer.cs
+++ b/edkrepo_installer/EdkRepoInstaller/VendorCustomizer.cs
@@ -250,7 +250,7 @@ namespace TianoCore.EdkRepoInstaller
NewObsoletedPythonVersions.Add(new PythonVersion(version));
}
PythonVersions = NewPythonVersions;
- ObsoletedPythonVersions = NewPythonVersions;
+ ObsoletedPythonVersions =
+ NewObsoletedPythonVersions;
};
}
}
--
2.24.0.windows.2
prev parent reply other threads:[~2020-03-17 21:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 17:32 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Installer would lists every Python version as obsolete Nate DeSimone
2020-03-16 17:32 ` [edk2-staging/EdkRepo] [PATCH] EdkRepo: Uninstaller does not uninstall packages with '_' in their name Nate DeSimone
2020-03-17 21:43 ` Desimone, Ashley E
2020-03-16 17:32 ` [edk2-staging/EdkRepo] [PATCH] EdkRepo: Use /S switch to pass command args in installer Nate DeSimone
2020-03-17 21:44 ` Desimone, Ashley E
2020-03-17 21:42 ` Desimone, Ashley E [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF3A9EB60ABDA47BE7821A4DA3A0A3353D58219@ORSMSX116.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox