From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.1801.1584481453656757190 for ; Tue, 17 Mar 2020 14:44:13 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: ashley.e.desimone@intel.com) IronPort-SDR: umyZDexXFwVPp8Wmi3yopkbvtBkzTpGyQlVOXytfKU9yzFGhvTmkI4RPmWJp7pHZzyHTRRrbKH +RalmxD5eMqQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2020 14:44:12 -0700 IronPort-SDR: xaeyk1oh7DjZeIzziyIboWCLEhSxGCJ8GjL+4vRcd4H7MrAVRtOUniHmC6mUYQr/vgzU12FdRE uAmc65UOCvFg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,565,1574150400"; d="scan'208";a="247965969" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by orsmga006.jf.intel.com with ESMTP; 17 Mar 2020 14:44:12 -0700 Received: from orsmsx116.amr.corp.intel.com ([169.254.7.196]) by ORSMSX110.amr.corp.intel.com ([169.254.10.144]) with mapi id 14.03.0439.000; Tue, 17 Mar 2020 14:44:12 -0700 From: "Desimone, Ashley E" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Pandya, Puja" , "Bjorge, Erik C" , Bret Barkelew Subject: Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Use /S switch to pass command args in installer Thread-Topic: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Use /S switch to pass command args in installer Thread-Index: AQHV+7j6mYgcDmvO3EqyPP6Dzu8lGahNUtSQ Date: Tue, 17 Mar 2020 21:44:12 +0000 Message-ID: <4CF3A9EB60ABDA47BE7821A4DA3A0A3353D58243@ORSMSX116.amr.corp.intel.com> References: <20200316173248.1678-1-nathaniel.l.desimone@intel.com> <20200316173248.1678-3-nathaniel.l.desimone@intel.com> In-Reply-To: <20200316173248.1678-3-nathaniel.l.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ashley DeSimone -----Original Message----- From: Desimone, Nathaniel L =20 Sent: Monday, March 16, 2020 10:33 AM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Use /S switch to pass comm= and args in installer Cc: Ashley DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Signed-off-by: Nate DeSimone --- edkrepo_installer/EdkRepoInstaller/App.xaml.cs | 4 ++-- edkrepo_installer/EdkRepoInstaller/InstallWorker.cs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/edkrepo_installer/EdkRepoInstaller/App.xaml.cs b/edkrepo_insta= ller/EdkRepoInstaller/App.xaml.cs index 58186c9..5d23624 100644 --- a/edkrepo_installer/EdkRepoInstaller/App.xaml.cs +++ b/edkrepo_installer/EdkRepoInstaller/App.xaml.cs @@ -185,7 +185,7 @@ namespace TianoCore.EdkRepoInstaller { InstallLogger.Log(string.Format("{0} is a third party = version of {1}. {0} is already installed.", DisplayName, ProductName)); InstallLogger.Log(string.Format("To install this versi= on of {1}, {0} must be uninstalled first.", DisplayName, ProductName)); - SilentProcess p =3D SilentProcess.StartConsoleProcessS= ilently("cmd.exe", string.Format("/c \"{0}\"", UninstallString)); + SilentProcess p =3D SilentProcess.StartConsoleProcessS= ilently("cmd.exe", string.Format("/S /C \"{0}\"", UninstallString)); p.WaitForExit(); Thread.Sleep(4000); } @@ -200,7 +200,7 @@ namespace TianoCore.EdkRepoInstaller ); if (Uninstall =3D=3D MessageBoxResult.Yes) { - SilentProcess p =3D SilentProcess.StartConsoleProc= essSilently("cmd.exe", string.Format("/c \"{0}\"", UninstallString)); + SilentProcess p =3D SilentProcess.StartConsoleProc= essSilently("cmd.exe", string.Format("/S /C \"{0}\"", UninstallString)); p.WaitForExit(); Thread.Sleep(1000); } diff --git a/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs b/edkrepo_= installer/EdkRepoInstaller/InstallWorker.cs index 5a358f9..c37189b 100644 --- a/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs +++ b/edkrepo_installer/EdkRepoInstaller/InstallWorker.cs @@ -672,7 +672,7 @@ namespace TianoCore.EdkRepoInstaller { InstallLogger.Log(string.Format("Uninstalling = {0}...", UninstallerPath)); string UninstallString =3D string.Format("\"{0= }\" /Uninstall /Passive", UninstallerPath); - SilentProcess p =3D SilentProcess.StartConsole= ProcessSilently("cmd.exe", string.Format("/c \"{0}\"", UninstallString)); + SilentProcess p =3D SilentProcess.StartConsole= ProcessSilently("cmd.exe", string.Format("/S /C \"{0}\"", UninstallString))= ; p.WaitForExit(); Thread.Sleep(4000); } --=20 2.24.0.windows.2