From: "Desimone, Ashley E" <ashley.e.desimone@intel.com>
To: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Pandya, Puja" <puja.pandya@intel.com>,
"Bjorge, Erik C" <erik.c.bjorge@intel.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add additional debug for checkout failures
Date: Wed, 18 Mar 2020 19:43:16 +0000 [thread overview]
Message-ID: <4CF3A9EB60ABDA47BE7821A4DA3A0A3353D59222@ORSMSX116.amr.corp.intel.com> (raw)
In-Reply-To: <20200318192921.1529-1-nathaniel.l.desimone@intel.com>
Reviewed-by: Ashley DeSimone <ashley.e.desimone@intel.com>
-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Sent: Wednesday, March 18, 2020 12:29 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add additional debug for checkout failures
Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
edkrepo/common/common_repo_functions.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/edkrepo/common/common_repo_functions.py b/edkrepo/common/common_repo_functions.py
index 4b580c0..288dd27 100644
--- a/edkrepo/common/common_repo_functions.py
+++ b/edkrepo/common/common_repo_functions.py
@@ -14,6 +14,7 @@ import sys
import unicodedata
import urllib.request
import subprocess
+import traceback
import git
from git import Repo
@@ -600,7 +601,9 @@ def checkout(combination_or_sha, verbose=False, override=False, log=None):
if combination_is_in_manifest(combo_or_sha, manifest):
manifest.write_current_combo(combo_or_sha)
except:
- print (CHECKOUT_COMBO_UNSUCCESFULL.format(combo_or_sha))
+ if verbose:
+ traceback.print_exc()
+ print (CHECKOUT_COMBO_UNSUCCESSFULL.format(combo_or_sha))
# Return to the initial combo, since there was an issue with cheking out the selected combo
checkout_repos(verbose, override, initial_repo_sources, workspace_path, manifest)
finally:
--
2.24.0.windows.2
next prev parent reply other threads:[~2020-03-18 19:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 19:29 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add additional debug for checkout failures Nate DeSimone
2020-03-18 19:43 ` Desimone, Ashley E [this message]
2020-03-18 22:43 ` Bjorge, Erik C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CF3A9EB60ABDA47BE7821A4DA3A0A3353D59222@ORSMSX116.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox