From: gordontcp@gmail.com
To: devel@edk2.groups.io
Subject: Capsule update with USBIO in FmpDxe.
Date: Tue, 26 Jul 2022 04:32:00 -0700 [thread overview]
Message-ID: <4CaW.1658835120122756488.3x88@groups.io> (raw)
[-- Attachment #1: Type: text/plain, Size: 3155 bytes --]
Hi all,
In \FmpDevicePkg\Library\FmpDeviceLibNull\FmpDeviceLib.c
There are comments for RegisterFmpInstaller:
/**
Used to pass the FMP install function to this lib. This allows the library to
have control of the handle that the FMP instance is installed on. This allows
the library to use DriverBinding protocol model to locate its device(s) in the
system.
@param[in] Func Function pointer to FMP install function.
@retval EFI_SUCCESS Library has saved function pointer and will call
function pointer on each DriverBinding Start.
@retval EFI_UNSUPPORTED Library doesn't use driver binding and only supports
a single instance.
@retval other error Error occurred. Don't install FMP
**/
EFI_STATUS
EFIAPI
RegisterFmpInstaller (
IN FMP_DEVICE_LIB_REGISTER_FMP_INSTALLER Func
)
{
//
// This is a system firmware update that does not use Driver Binding Protocol
//
return EFI_UNSUPPORTED;
}
However, since the ‘RegisterFmpInstaller’ of the example directly returns EFI_UNSUPPORTED , it does not demonstrate how to handle the DriverBinding protocol.
In addition, I refer to
the example of \MdeModulePkg\Bus\Usb\UsbMouseAbsolutePointerDxe adding the driverbinding protocol to locate the USBMouse device to the 'RegisterFmpInstaller' function. And set the return value of RegisterFmpInstaller to EFI_SUCCESS.
where RegisterFmpInstaller is in the following file:
edk2-platforms\Platform\Intel\Vlv2TbltDevicePkg\Feature\Capsule\Library\FmpDeviceLibSample
Then tested on Minnowboard.
Test command: CapsuleApp.efi Red.cap
The test results are as follows:
* During the Capsule update process, when FmpDeviceSetImageWithStatus is executed, USBMouseAbsolutePointerDriverBindingSupported has not been executed, that is, USB Device IO cannot be operated yet.
* After USBMouseAbsolutePointerDriverBindingSupporte d is executed, USBIO can be operated, but at this time FmpDeviceSetImageWithStatus has been executed, that is, capsule update is too late to process.
My questions are as follows:
* Is there an example of how RegisterFmpInstaller handles the driverbinding protocol?
* When processing the Capsule update (FmpDeviceSetImageWithStatus), the USBMouseAbsolutePointerDriverBindingSupported has not been executed. What should I do?
* The parameter in RegisterFmpInstaller is the function pointer ' FMP_DEVICE_LIB_REGISTER_FMP_INSTALLER Func ', and how should the parameter Handle in Func (ie InstallFmpInstance , see below) be passed from FmpDxe to FmpDeviceLib ?
Any suggestion is highly appreciated!
Thanks!
EFI_STATUS
EFIAPI
FmpDxeEntryPoint (
IN EFI_HANDLE ImageHandle,
IN EFI_SYSTEM_TABLE *SystemTable
)
{
….
Status = RegisterFmpInstaller(InstallFmpInstance);
…
}
EFI_STATUS
EFIAPI
InstallFmpInstance (
IN EFI_HANDLE Handle
)
{….
}
EFI_STATUS
EFIAPI
RegisterFmpInstaller(
IN FMP_DEVICE_LIB_REGISTER_FMP_INSTALLER Func
)
{
// Because this is a sample lib with very simple fake device we don't use
// the driverbinding protocol to locate our device.
//
return EFI_UNSUPPORTED;
}
[-- Attachment #2: Type: text/html, Size: 11172 bytes --]
next reply other threads:[~2022-07-26 11:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 11:32 gordontcp [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-07-29 3:28 Capsule update with USBIO in FmpDxe gordontcp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CaW.1658835120122756488.3x88@groups.io \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox