From: Andrew Fish <afish@apple.com>
To: Kurt Kennett <Kurt.Kennett@microsoft.com>
Cc: edk2-devel <edk2-devel@lists.01.org>
Subject: Re: Setting BuildOptions by module type does not seem to work
Date: Mon, 15 Aug 2016 10:29:33 -0700 [thread overview]
Message-ID: <4FA3496D-C050-40FA-8CB1-E3603E431E79@apple.com> (raw)
In-Reply-To: <BY2PR03MB5226BC44AD7AA6B97B342FD9C120@BY2PR03MB522.namprd03.prod.outlook.com>
> On Aug 15, 2016, at 9:34 AM, Kurt Kennett <Kurt.Kennett@microsoft.com> wrote:
>
> No, I had not tried that. I tried it now and it does not seem to work.
>
> I have:
>
> [BuildOptions.AARCH64.common]
> *_VS2015x86_AARCH64_DLINK_FLAGS = /BORK
>
> [BuildOptions.AARCH64.common.DXE_RUNTIME_DRIVER]
> *_VS2015x86_AARCH64_DLINK_FLAGS = /PLOR
>
> [BuildOptions.AARCH64.common.EDKII.DXE_RUNTIME_DRIVER]
> *_VS2015x86_AARCH64_DLINK_FLAGS = /BONK
>
> And the only one that makes it to the command line is the /BORK one.
>
> (The tools do not complain about the specification of options as above).
>
I'm guessing the syntax checking is not very good?
[BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER]
[BuildOptions.AARCH64.common.EDKII.DXE_RUNTIME_DRIVER]
I see the [BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] form used in other places, but you have an extra .common?
Thanks,
Andrew Fish
> K2
>
> -----Original Message-----
> From: afish@apple.com [mailto:afish@apple.com]
> Sent: Monday, August 15, 2016 9:22 AM
> To: Kurt Kennett <Kurt.Kennett@microsoft.com>
> Cc: edk2-devel <edk2-devel@lists.01.org>
> Subject: Re: [edk2] Setting BuildOptions by module type does not seem to work
>
>
>> On Aug 15, 2016, at 9:10 AM, Kurt Kennett <Kurt.Kennett@microsoft.com> wrote:
>>
>> DSC spec (January 2016 1.26) says I can do this:
>>
>> (Section 3.6 pp 76)
>>
>> ...
>> * [BuildOptions.$(arch).CodeBase.Edk2ModuleType]
>> ...
>>
>> And this works fine:
>>
>> [BuildOptions.AARCH64.common]
>> *_VS2015x86_*_DLINK_FLAGS = /BORK
>>
>> But when I also do:
>>
>> [BuildOptions.AARCH64.common.DXE_RUNTIME_DRIVER]
>> *_VS2015x86_*_DLINK_FLAGS = /PLOR
>>
>> The link flags are not affected on the command line - they get the /BORK for all module types, but not the /PLOR for DXE_RUNTIME_DRIVERs.
>>
>
> Kurt,
>
> Have you tried [BuildOptions.AARCH64.EDKII.DXE_RUNTIME_DRIVER]? Do you need EDK compatibility?
>
> I'm guessing that works given:
> ~/work/src/edk2(master)>git grep "BuildOptions." -- *.dsc | grep DXE_RUNTIME_DRIVER OvmfPkg/OvmfPkgIa32.dsc:49:[BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER]
> OvmfPkg/OvmfPkgIa32X64.dsc:54:[BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER]
> OvmfPkg/OvmfPkgX64.dsc:54:[BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER]
> QuarkPlatformPkg/Quark.dsc:885:[BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER]
>
>
>> I'm not familiar with the DSC processing tools source. Anybody know where to look to see why not?
>>
>
> It starts here: https://github.com/tianocore/edk2/blob/master/BaseTools/Source/Python/build/build.py and uses some code from: https://github.com/tianocore/edk2/tree/master/BaseTools/Source/Python/Common
>
> Thanks,
>
> Andrew Fish
>
>> K2
>>
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2016-08-15 17:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 16:10 Setting BuildOptions by module type does not seem to work Kurt Kennett
2016-08-15 16:21 ` Andrew Fish
2016-08-15 16:34 ` Kurt Kennett
2016-08-15 17:29 ` Andrew Fish [this message]
2016-08-15 17:55 ` Kurt Kennett
2016-08-16 2:16 ` Gao, Liming
2016-08-16 14:49 ` Kurt Kennett
2016-08-16 15:15 ` Andrew Fish
2016-08-16 15:22 ` Kurt Kennett
2016-08-16 15:47 ` Andrew Fish
2016-08-16 16:21 ` Gao, Liming
2016-08-16 16:27 ` Andrew Fish
2016-08-16 16:50 ` Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA3496D-C050-40FA-8CB1-E3603E431E79@apple.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox