From: "Peter Grehan" <grehan@freebsd.org>
To: Rebecca Cran <rebecca@bsdio.com>, devel@edk2.groups.io
Cc: Jordan Justen <jordan.l.justen@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: Re: [PATCH 1/1] OvmfPkg/Bhyve: Add support for the AMD host bridge
Date: Tue, 24 Nov 2020 08:26:54 +1000 [thread overview]
Message-ID: <4ab79040-2ff4-dd91-0545-4c5504df85bf@freebsd.org> (raw)
In-Reply-To: <20201123050502.96793-1-rebecca@bsdio.com>
Reviewed-by: Peter Grehan <grehan@freebsd.org>
> On bhyve, either an Intel or AMD host bridge can be specified, with the
> default being Intel.
> Both are identical, except the AMD one uses a PCI vendor ID of AMD.
>
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
> OvmfPkg/Bhyve/PlatformPei/Platform.c | 3 ++-
> OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c | 6 ++++--
> 2 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/OvmfPkg/Bhyve/PlatformPei/Platform.c b/OvmfPkg/Bhyve/PlatformPei/Platform.c
> index 11658d478c3b..9f1900626d6b 100644
> --- a/OvmfPkg/Bhyve/PlatformPei/Platform.c
> +++ b/OvmfPkg/Bhyve/PlatformPei/Platform.c
> @@ -349,7 +349,8 @@ MiscInitialization (
> // Determine platform type and save Host Bridge DID to PCD
> //
> switch (mHostBridgeDevId) {
> - case 0x1275: // BHYVE
> + case 0x7432: // BHYVE (AMD hostbridge)
> + case 0x1275: // BHYVE (Intel hostbridge)
> case INTEL_82441_DEVICE_ID:
> PmCmd = POWER_MGMT_REGISTER_PIIX4 (PCI_COMMAND_OFFSET);
> Pmba = POWER_MGMT_REGISTER_PIIX4 (PIIX4_PMBA);
> diff --git a/OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c b/OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c
> index 3b94630ac732..eaade4adeae2 100644
> --- a/OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c
> +++ b/OvmfPkg/Library/PlatformBootManagerLibBhyve/BdsPlatform.c
> @@ -1066,7 +1066,8 @@ SetPciIntLine (
> // and should match SeaBIOS src/fw/pciinit.c *_pci_slot_get_irq()
> //
> switch (mHostBridgeDevId) {
> - case 0x1275: // BHYVE
> + case 0x7432: // BHYVE (AMD hostbridge)
> + case 0x1275: // BHYVE (Intel hostbridge)
> case INTEL_82441_DEVICE_ID:
> Idx -= 1;
> break;
> @@ -1143,7 +1144,8 @@ PciAcpiInitialization (
> //
> mHostBridgeDevId = PcdGet16 (PcdOvmfHostBridgePciDevId);
> switch (mHostBridgeDevId) {
> - case 0x1275: // BHYVE
> + case 0x7432: // BHYVE (AMD hostbridge)
> + case 0x1275: // BHYVE (Intel hostbridge)
> case INTEL_82441_DEVICE_ID:
> Pmba = POWER_MGMT_REGISTER_PIIX4 (PIIX4_PMBA);
> //
>
next prev parent reply other threads:[~2020-11-23 22:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 5:05 [PATCH 1/1] OvmfPkg/Bhyve: Add support for the AMD host bridge Rebecca Cran
2020-11-23 22:26 ` Peter Grehan [this message]
2020-11-24 0:05 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ab79040-2ff4-dd91-0545-4c5504df85bf@freebsd.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox