From: "Laszlo Ersek" <lersek@redhat.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Guptha, Soumya K" <soumya.k.guptha@intel.com>,
"leif@nuviainc.com" <leif@nuviainc.com>,
"afish@apple.com" <afish@apple.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: Patch List for 202002 stable tag
Date: Wed, 19 Feb 2020 09:53:52 +0100 [thread overview]
Message-ID: <4af0b7a1-c094-89b1-0450-9d7673488c83@redhat.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9EBDAD5@ORSMSX113.amr.corp.intel.com>
On 02/18/20 21:42, Kinney, Michael D wrote:
> Hi Laszlo,
>
> I agree with your assessments.
>
> One comment below.
>
> Mike
>
>> -----Original Message-----
>> From: Laszlo Ersek <lersek@redhat.com>
>> Sent: Tuesday, February 18, 2020 12:04 PM
>> To: Gao, Liming <liming.gao@intel.com>; Guptha, Soumya K
>> <soumya.k.guptha@intel.com>; Kinney, Michael D
>> <michael.d.kinney@intel.com>; leif@nuviainc.com; afish@apple.com
>> Cc: devel@edk2.groups.io
>> Subject: Re: Patch List for 202002 stable tag
>>> https://edk2.groups.io/g/devel/message/54510 [PATCH v6 0/2]
>>> Enhancement and Fixes to BaseHashApiLib
>>
>> Hm. I feel like I need some convincing that patch#1 --
>> "CryptoPkg/BaseHashApiLib: Align BaseHashApiLib with TPM 2.0
>> Implementation" -- is *also* a bugfix (like patch#2).
>>
>> That question matters because the reviews:
>>
>> - https://edk2.groups.io/g/devel/message/54513
>> - https://edk2.groups.io/g/devel/message/54567
>>
>> were not posted before the SFF.
>>
>> ... I guess it's OK.
>
> The description of the bug does not emphasis that this really is a bug
> fix. There were additional review comments from the CryptoPkg
> reviewers after the initial review/commit of this feature. These
> changes address that feedback. The alignment with TPM 2.0 is to use
> an existing set of defines for the hash algorithms instead of define
> yet another set of defines. Details in this thread:
>
> https://edk2.groups.io/g/devel/topic/70960524#53733
Thanks!
Laszlo
next prev parent reply other threads:[~2020-02-19 8:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 14:08 Patch List for 202002 stable tag Liming Gao
2020-02-18 20:04 ` Laszlo Ersek
2020-02-18 20:42 ` Michael D Kinney
2020-02-19 8:53 ` Laszlo Ersek [this message]
2020-02-19 15:39 ` Liming Gao
2020-02-19 18:09 ` Vitaly Cheptsov
2020-02-20 1:17 ` Liming Gao
2020-02-20 1:35 ` Gao, Zhichao
2020-02-20 3:13 ` Ni, Ray
2020-02-20 6:58 ` Liming Gao
2020-02-20 7:07 ` Vitaly Cheptsov
[not found] ` <15F50A1858BD174A.18319@groups.io>
2020-02-21 8:22 ` [edk2-devel] " Liming Gao
[not found] ` <15F55D425BF8837D.15709@groups.io>
2020-02-27 16:06 ` Liming Gao
2020-02-27 16:23 ` Leif Lindholm
2020-02-27 17:25 ` Laszlo Ersek
2020-02-28 4:13 ` Liming Gao
2020-02-28 12:48 ` Leif Lindholm
2020-03-03 8:29 ` Liming Gao
2020-03-03 11:37 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4af0b7a1-c094-89b1-0450-9d7673488c83@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox