From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.9477.1582102449748098184 for ; Wed, 19 Feb 2020 00:54:09 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SPTgWmsj; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582102448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tn20RQAJbob4TKDJ97JXcA+QnHS+f6gvzG0XQRHmMYE=; b=SPTgWmsjeETHyHu3+zd2mRuynQgG8rqWvsA0ZvXYeqyzdQXjOTd6MtYZ2L8HaLWW22reY6 wNmUF+gi+XKJfOzvzwDdXAWYOtc7C/hyOSA5D8kbgEE/YpjoE2NMaeZUtDjI5l/CAXStHN YSpbHWd1etvevMdqcbhkviTPbBOf3hw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-76-LvTpwEZ1ORa1USKqf1idHA-1; Wed, 19 Feb 2020 03:53:56 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D295713EA; Wed, 19 Feb 2020 08:53:54 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-228.ams2.redhat.com [10.36.117.228]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D0266E3EE; Wed, 19 Feb 2020 08:53:53 +0000 (UTC) Subject: Re: Patch List for 202002 stable tag To: "Kinney, Michael D" , "Gao, Liming" , "Guptha, Soumya K" , "leif@nuviainc.com" , "afish@apple.com" Cc: "devel@edk2.groups.io" References: <7f58502307c643999e73ee73673f5fae@intel.com> From: "Laszlo Ersek" Message-ID: <4af0b7a1-c094-89b1-0450-9d7673488c83@redhat.com> Date: Wed, 19 Feb 2020 09:53:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: LvTpwEZ1ORa1USKqf1idHA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 02/18/20 21:42, Kinney, Michael D wrote: > Hi Laszlo, > > I agree with your assessments. > > One comment below. > > Mike > >> -----Original Message----- >> From: Laszlo Ersek >> Sent: Tuesday, February 18, 2020 12:04 PM >> To: Gao, Liming ; Guptha, Soumya K >> ; Kinney, Michael D >> ; leif@nuviainc.com; afish@apple.com >> Cc: devel@edk2.groups.io >> Subject: Re: Patch List for 202002 stable tag >>> https://edk2.groups.io/g/devel/message/54510 [PATCH v6 0/2] >>> Enhancement and Fixes to BaseHashApiLib >> >> Hm. I feel like I need some convincing that patch#1 -- >> "CryptoPkg/BaseHashApiLib: Align BaseHashApiLib with TPM 2.0 >> Implementation" -- is *also* a bugfix (like patch#2). >> >> That question matters because the reviews: >> >> - https://edk2.groups.io/g/devel/message/54513 >> - https://edk2.groups.io/g/devel/message/54567 >> >> were not posted before the SFF. >> >> ... I guess it's OK. > > The description of the bug does not emphasis that this really is a bug > fix. There were additional review comments from the CryptoPkg > reviewers after the initial review/commit of this feature. These > changes address that feedback. The alignment with TPM 2.0 is to use > an existing set of defines for the hash algorithms instead of define > yet another set of defines. Details in this thread: > > https://edk2.groups.io/g/devel/topic/70960524#53733 Thanks! Laszlo