From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Rebecca Cran <rebecca@bsdio.com>, Marcin Wojtas <mw@semihalf.com>,
devel@edk2.groups.io
Cc: leif@nuviainc.com, jaz@semihalf.com, kostap@marvell.com,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [edk2-platforms PATCH] Silicon/Marvell: Fix ArmSoftFloatLib resolution for ARM builds
Date: Mon, 4 Jan 2021 18:06:08 +0100 [thread overview]
Message-ID: <4afb1fd1-6ce7-5116-0d19-acdeb413e028@arm.com> (raw)
In-Reply-To: <12952a14-c9d2-2d74-1472-524b3c33f263@bsdio.com>
On 12/29/20 7:40 PM, Rebecca Cran wrote:
> On 12/29/20 11:31 AM, Marcin Wojtas wrote:
>> As the SignedCapsulePkg requires ArmSoftFloatLib resolution
>> for ARM builds, add missing dependency for all Marvell
>> platforms.
>>
>> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>> Reported-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
>> b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
>> index 017c6287f7..e8e7300441 100644
>> --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
>> +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
>> @@ -211,6 +211,9 @@
>> # Add support for GCC stack protector
>> NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf
>> +[LibraryClasses.ARM]
>> + ArmSoftFloatLib|ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
>> +
>
> Reviewed-by: Rebecca Cran <rebecca@bsdio.com>
>
> Thanks - that was good timing!
>
Pushed as eec4526f3bc2..a34e27a1fa79
Thanks!
prev parent reply other threads:[~2021-01-04 17:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 18:31 [edk2-platforms PATCH] Silicon/Marvell: Fix ArmSoftFloatLib resolution for ARM builds Marcin Wojtas
2020-12-29 18:40 ` Rebecca Cran
2021-01-04 17:06 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4afb1fd1-6ce7-5116-0d19-acdeb413e028@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox