From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.43]) by mx.groups.io with SMTP id smtpd.web12.6606.1639750576816142901 for ; Fri, 17 Dec 2021 06:16:17 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=a1Jy3nmU; spf=pass (domain: arm.com, ip: 40.107.7.43, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7hDtVDLzaF4Z089R5aT3+3QDhLwWRMP6AbVG9GMnwp4=; b=a1Jy3nmUDALEG65kaVsBol2H8Zm4WhA8Y1cYpMFc6KvRu0OS7gmZEO6YplcvVBCdHkaxUpV9z5yg9DsC15FoxAH+Cj0mYW/cYfLxe6DFh9DBqZog3clWCBze5rmZwsSjRnM2Q2KKiz9wEtpA8rPbtAEXdaNG7a70pBmU2sOmzFU= Received: from AS8P189CA0007.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::23) by AS8PR08MB5880.eurprd08.prod.outlook.com (2603:10a6:20b:29f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.15; Fri, 17 Dec 2021 14:16:14 +0000 Received: from VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:31f:cafe::d8) by AS8P189CA0007.outlook.office365.com (2603:10a6:20b:31f::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend Transport; Fri, 17 Dec 2021 14:16:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT027.mail.protection.outlook.com (10.152.18.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14 via Frontend Transport; Fri, 17 Dec 2021 14:16:13 +0000 Received: ("Tessian outbound 9a8c656e7c94:v110"); Fri, 17 Dec 2021 14:16:13 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 4d6257e27363834c X-CR-MTA-TID: 64aa7808 Received: from 777056bcafc8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 69AC778E-AAD1-4AEE-8B26-FE357372269A.1; Fri, 17 Dec 2021 14:16:02 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 777056bcafc8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 17 Dec 2021 14:16:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eI9gdDD3WzfYP5LPKy45BziTWwDgE5yF16AF2VHGN/JMLr+bv8OJR2q5qcWT136R9R9nK6pZgG3l8ctNQoBjTakD5CV/sOmxCct/nKGAnRUwDieq0x8dtH9ZpLLep7fAxhIFIL5EumlFXNDejqVrMe9LVAZ/tbM1Y1/3pv3bQaSwZ68Ev9W551QiMK0aooUc0RTSVytQhKlwwLQsOSJYsfPf0KFhO5jw4Rzfpb6+dLyFzJl1/jXeSXVaLkcTggDTfSHsLUG+I2WwNVHYZCAUaeMA3adMUEauZDbjZW3aIC6BGCIIaJa4y766WO8RCqr2a2ApmHEgmUe0WfK+BuPlmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7hDtVDLzaF4Z089R5aT3+3QDhLwWRMP6AbVG9GMnwp4=; b=fcFcK9i/vYTiuif7W64ze08lJXu9wDzOu9lWxGorYV/aQg7vmUzR1KIEwlJ9ESk/3MBB/FDmFEtWt1lFlMWCWWjJPlmfw4wQcCHyAqmdhWjrwr/gZ30ZQVV1MUAGe5U1l9DhG8gbqHuLu4rczXHaZgPgP0Yczvywf5UtpnITViGRu/plK57GQH34DCPz596WGPBEpN6kb7j3XuZa+H8j5U9iqK0/XGwAjFUy6Xu8HVKoRFdrO4Pbr/SN+co5dDyBKQEqWo8yTHMIa1k/z3OqnzDO2YHgK1JnCh/cTaAcu9CaJwJ3iu4oIxJyXN4QcOZYomhLzrVOy2IZxEzLkRJizg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7hDtVDLzaF4Z089R5aT3+3QDhLwWRMP6AbVG9GMnwp4=; b=a1Jy3nmUDALEG65kaVsBol2H8Zm4WhA8Y1cYpMFc6KvRu0OS7gmZEO6YplcvVBCdHkaxUpV9z5yg9DsC15FoxAH+Cj0mYW/cYfLxe6DFh9DBqZog3clWCBze5rmZwsSjRnM2Q2KKiz9wEtpA8rPbtAEXdaNG7a70pBmU2sOmzFU= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB3286.eurprd08.prod.outlook.com (2603:10a6:209:40::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Fri, 17 Dec 2021 14:15:57 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::bdcf:cfa6:b2bb:38ac%6]) with mapi id 15.20.4755.021; Fri, 17 Dec 2021 14:15:57 +0000 Subject: Re: [PATCH edk2-platforms v1 10/10] Platform/ARM: Fix Ecc error 5005 To: Pierre.Gondois@arm.com, devel@edk2.groups.io, nd References: <20211124162330.236813-1-Pierre.Gondois@arm.com> <20211124162330.236813-11-Pierre.Gondois@arm.com> From: "Sami Mujawar" Message-ID: <4b08e8f7-7001-1765-462e-334d2253690b@arm.com> Date: Fri, 17 Dec 2021 14:16:04 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20211124162330.236813-11-Pierre.Gondois@arm.com> X-ClientProxiedBy: LO2P265CA0225.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::21) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 Received: from [10.1.196.43] (217.140.106.50) by LO2P265CA0225.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=) via Frontend Transport; Fri, 17 Dec 2021 14:15:56 +0000 X-MS-Office365-Filtering-Correlation-Id: 55a6bf42-9974-4a2a-7ee2-08d9c167c86d X-MS-TrafficTypeDiagnostic: AM6PR08MB3286:EE_|VE1EUR03FT027:EE_|AS8PR08MB5880:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:6430;OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: R14J4o1J4vSA4x/CNThdSLKvlmC5B06sCS/rXot0PShXy478zKeJNKFSO8gTb9eVpRpuDwDs7DWffn5apdVurFUteECXTKM0dIhcJCOwJb6pYnQG+2ESIu5XzlCI6VdAwBcUV2LEZOxMnUtnHmyhoJQbr1e0myHunBS7FIDezbZy0aauooPoUzGF0d8QCtN0xu+SQKfFs7CckWJvaqqLy3JFXm+807ULOhzgp0/flUUY8g7u7YsJQseVQEOwuv5o0X/l9jBQSUZ3VjOxbuLdHjsnd75OlmAF/39UlNtnHZAjKpsVAYi24KwRXnKUNU3CsYB/z4yFM3bQznLPiSiO4TblLR0xEbz9VqlnuHkLRLFkq5TOHVGcaxiw2ozjKcvC4dDy3hDgXCKLZHDnq9hOOOJMSOqxMhYSeL57oR96TzgMbYyu/9uwVGsogmMzxfSGnM2OxKLfBnKy0WzIdhfpTqJDPkpALi2xlOu63Tn38/xhBqp6oKViYWWLgfsxcAZbJmkIRoDFRqppn7w9cMt0VpEi9Bqr/I14aEyideUUTkE4RmCDtQYojbnp7YJNANZfhEACtXOmGZAxwvaA39mgD0BZcrHaGuE/OU8NDeUd0m7j3ZmM0OzkWRcfWKuRZqTMEpqva1AjfybbMil6BtDZMtecYgsQy3fbIzZeCjimUX+2YxOF+13zROnEQ57gj6VbcckwxeH7KyNllxCOWlKfv52o6Gq+x/dJWpkS56Wx5SlTwLWXbpxFfRDC8pZPEQcQAmFGYTzH8EEX+C/E8zbsqg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(66946007)(38100700002)(66556008)(6862004)(316002)(8936002)(16576012)(508600001)(37006003)(66476007)(956004)(86362001)(2616005)(8676002)(31686004)(52116002)(6486002)(6666004)(31696002)(44832011)(5660300002)(53546011)(186003)(2906002)(26005)(36756003)(6636002)(38350700002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3286 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a72e7c05-ebed-4d3e-b8a5-08d9c167be3a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lg1WvLLTuw0uy+lkZE5pPIlNEsopfOBOsvR3snW9/bgViep+Flsrp/KVs5nExrzWe3ao87pvGx7N10TngExDhx1wAfdmXrOvCaTV+Yl8miPrC8n/vd357g2yLkhGPecQSsRJ3/JmNAEvwMt1+cq+E0Knj0AKPyj8hNGNdsQ2+UuZ/cTupKxGJQajQrc0/tG+/vM5x6NKAQQTG6j1inaCTZBr2ZudbtS9OCA/x+8NGZ+FuteNwDXguqyOeThFzFmG8VnwzUALl3AOHm0N5hW9nbB7I+Lqhtag+Om7Fs2NYy0mwnjgTj2zehJr0jZaYVIjfXoay/X+k0R4uUcpWtmvyuMb0FgvWbCjbhY04KcYDBXT1Sbc4FoACnvzydkt49SzDydpyThZfrOt/NIuaafsSUG2oyl0M769sd5Fj5WGYB2qnKJbZPS83/fQyQEhhviZCakphCYmp2li/eufbiH+TwfzTIxMpOUe+o1ChZ95kAnDTz0u1pYHTPXyCOe1PQy8DKTtFgwO6hq0kxLkn2VynPmaZNPiMiIuAEZAVQlw6xfDHQSRUFbCAF+/ru6BQ/xQscKu095QcziFvr8W4IfoHXTz4zs57h3BTO9pWXZ7oMSvzZpTKM/HAZj5DlosN2HGSB5/EQPRddWFCgwye5sIcfzpi5M09JCzgI6EmzqoxiWnrgg3GZo2vFRcfIyAtSH5gDwUHeRF/10mcnUlY+F/rbFV5lQLoSPjfC4kLl604CM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(46966006)(36840700001)(83380400001)(186003)(26005)(316002)(81166007)(36860700001)(956004)(2616005)(336012)(53546011)(70206006)(70586007)(6486002)(5660300002)(356005)(82310400004)(31696002)(44832011)(86362001)(6636002)(31686004)(8676002)(6862004)(6666004)(36756003)(8936002)(47076005)(37006003)(508600001)(16576012)(2906002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Dec 2021 14:16:13.6953 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55a6bf42-9974-4a2a-7ee2-08d9c167c86d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB5880 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-GB Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/11/2021 04:23 PM, Pierre.Gondois@arm.com wrote: > From: Pierre Gondois > > This patch fixes the following Ecc reported error: > The body of a function should be contained by open > and close braces that must be in the first column. > > Signed-off-by: Pierre Gondois > --- > .../ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassTh= ru.c b/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c > index 0ec53782835b..c54291220348 100644 > --- a/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c > +++ b/Platform/ARM/JunoPkg/Drivers/SataSiI3132Dxe/SiI3132AtaPassThru.c > @@ -23,7 +23,8 @@ GetSataDevice ( > IN SATA_SI3132_INSTANCE* SataInstance, > IN UINT16 Port, > IN UINT16 PortMultiplierPort > -) { > + ) > +{ > LIST_ENTRY *List; > SATA_SI3132_PORT *SataPort; > SATA_SI3132_DEVICE *SataDevice; > -- > 2.25.1 IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.