From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by mx.groups.io with SMTP id smtpd.web12.11066.1582113380278329705 for ; Wed, 19 Feb 2020 03:56:20 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=fgDzdiyc; spf=none, err=permanent DNS error (domain: akeo.ie, ip: 209.85.221.67, mailfrom: pete@akeo.ie) Received: by mail-wr1-f67.google.com with SMTP id z7so127401wrl.13 for ; Wed, 19 Feb 2020 03:56:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Sa5JtuGBGhHx53ZZI/UbX3XasdpXlq1beUVFmy9GvRg=; b=fgDzdiyceHFyUYO03YHYx3fK2UWoc1CueEly0qUnXKHfSxB73qUgISvhGvZ7I5Go7t 4Uzk9T1qjWDvZCquRtOLKFIUl/5GCV8N3/vDKvjoezArbRBTfkWzTzxw2RYX92lBBRdc uNeTt4z/SiuT4hooUT5bu9jEK0m0lx6pI+bYKF8KP2LO5YXgztwOcjhCICQldQsN3sWm Cp3kAJhsLdvdMcheJRDyDc9hvYymfXRVUqGi0gwYNYpow4kR+r0BJtoSMXUgg8mgsJEP /UWfwW69w3DzuwbnWtBfcZ/YdytfVKyVR+gwJrOJPztjSTknmlapUNOxQkFf2pGtQrfx urHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Sa5JtuGBGhHx53ZZI/UbX3XasdpXlq1beUVFmy9GvRg=; b=sgaCYPxjKDK+oo98P2vB2eJT7KmdNkKlD1C0bwfYCv0KdAFV7t4UMOlwaxPQS9wBbp 9QSPuKtCRN897hni5Bq+npiO8UZQNWICuqCMYxnaqknJO1BvRy91mN9e5mTU9xrvtcHk T9RbefdmLRE/HZ/ZbEppebf/+jxtQFiJxskAQBOSrebiZ8DOfZTawsorBMYGMWrpitTX MnBfNuUq/I/ejsFn8Da9cQXss317fLjlvEfhVD7XW27TH3GPupKzHFjQj3PmFLaRQmIx UVmz5QDR3/Qzty0fHRWcuPic2FjFBHUxV4fc0wL3t70knQ/0afTSV136eIwWZPtHjpvb 1A8Q== X-Gm-Message-State: APjAAAVtDURXffsuqTUfLgSLoxF1hfIwICHbbkGEYdCuAJawMWzQ/6HP e/ngY/U1pcZdZSiGjU3jz+tAaQ== X-Google-Smtp-Source: APXvYqy9Rnm7i2wALQEy39DPAOTW6DtCHP2eGFXIE7EZwq5BbzkezsbNB3/OBGFhOVh9UVNZUHrk1A== X-Received: by 2002:adf:b64b:: with SMTP id i11mr37655395wre.58.1582113378675; Wed, 19 Feb 2020 03:56:18 -0800 (PST) Return-Path: Received: from [10.0.0.122] ([84.203.84.173]) by smtp.googlemail.com with ESMTPSA id g2sm2637225wrw.76.2020.02.19.03.56.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Feb 2020 03:56:18 -0800 (PST) Subject: Re: [PATCH edk2-platforms 1/1] Platform: Add SerialUartClockLib for all platforms To: Pankaj Bansal , Yi Qian , Ard Biesheuvel , Marcin Wojtas , Zailiang Sun , Kelly Steele , Liming Gao , Nate DeSimone , Chasel Chiu , Michael D Kinney , Leif Lindholm , Meenakshi Aggarwal , Varun Sethi Cc: devel@edk2.groups.io, Pankaj Bansal References: <20200219140010.24053-1-pankaj.bansal@oss.nxp.com> From: "Pete Batard" Message-ID: <4b13083b-9460-3fcc-c7d7-1e22c50cdc79@akeo.ie> Date: Wed, 19 Feb 2020 11:56:16 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200219140010.24053-1-pankaj.bansal@oss.nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Hi Pankaj, Please see two comments inline: On 2020.02.19 14:00, Pankaj Bansal wrote: > From: Pankaj Bansal > > BaseSerialPortLib16550 has been modified to use SerialUartClockLib. > Therefore, add the default implementation of SerialUartClockLib for > all the platforms using BaseSerialPortLib16550. > > Signed-off-by: Pankaj Bansal > --- > > Notes: > [Dependency] > [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support > Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 1 + > Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 + > Platform/Intel/QuarkPlatformPkg/Quark.dsc | 1 + > Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 1 + > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 6 ++++++ > Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 6 ++++++ > Platform/RaspberryPi/RPi3/RPi3.dsc | 1 + > Platform/RaspberryPi/RPi4/RPi4.dsc | 1 + > Platform/Socionext/DeveloperBox/DeveloperBox.dsc | 1 + > Platform/Socionext/DeveloperBox/DeveloperBoxMm.dsc | 1 + > Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc | 1 + > Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 + > 12 files changed, 22 insertions(+) > > diff --git a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc > index b83e72b48c47..90cd72aff0d5 100644 > --- a/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc > +++ b/Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc > @@ -74,6 +74,7 @@ [LibraryClasses.common] > PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/PeiServicesTablePointerLibIdt.inf > PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseReportStatusCodeLibNull.inf > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplate.inf > diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > index 23ab53dbfe12..172ba6822419 100644 > --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > @@ -20,6 +20,7 @@ [LibraryClasses.common] > DxeCoreEntryPoint|MdePkg/Library/DxeCoreEntryPoint/DxeCoreEntryPoint.inf > UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf > UefiApplicationEntryPoint|MdePkg/Library/UefiApplicationEntryPoint/UefiApplicationEntryPoint.inf > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf > > diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc b/Platform/Intel/QuarkPlatformPkg/Quark.dsc > index a02adb64e695..b275298a5ddb 100644 > --- a/Platform/Intel/QuarkPlatformPkg/Quark.dsc > +++ b/Platform/Intel/QuarkPlatformPkg/Quark.dsc > @@ -213,6 +213,7 @@ [LibraryClasses] > # > IohLib|QuarkSocPkg/QuarkSouthCluster/Library/IohLib/IohLib.inf > I2cLib|QuarkSocPkg/QuarkSouthCluster/Library/I2cLib/I2cLib.inf > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatformHookLibNull.inf > > diff --git a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > index 3dbf616c664d..cffd777a6721 100644 > --- a/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > +++ b/Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc > @@ -185,6 +185,7 @@ [LibraryClasses] > # > IohLib|QuarkSocPkg/QuarkSouthCluster/Library/IohLib/IohLib.inf > I2cLib|QuarkSocPkg/QuarkSouthCluster/Library/I2cLib/I2cLib.inf > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatformHookLibNull.inf > > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > index 463b952e6582..91b2754ea509 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > @@ -184,6 +184,7 @@ [LibraryClasses.common] > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf > !else > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > !endif > > @@ -200,6 +201,7 @@ [LibraryClasses.common] > !if $(SOURCE_DEBUG_ENABLE) == TRUE > PeCoffExtraActionLib|SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraActionLibDebug.inf > DebugCommunicationLib|SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.inf > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > !else > PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf > @@ -280,6 +282,7 @@ [LibraryClasses.IA32.PEIM, LibraryClasses.IA32.PEI_CORE, LibraryClasses.IA32.SEC > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf > !else > DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > !endif > > @@ -779,6 +782,7 @@ [Components.IA32] > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf > PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatformHookLibNull.inf > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > } > !endif > @@ -933,6 +937,7 @@ [Components.IA32] > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf { > > NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > } > Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbSmm.inf > @@ -1223,6 +1228,7 @@ [Components.IA32] > > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > } > !endif > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > index ee18b45c9712..749a2dd4948b 100644 > --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > @@ -186,6 +186,7 @@ [LibraryClasses.common] > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf > !else > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > !endif > > @@ -202,6 +203,7 @@ [LibraryClasses.common] > !if $(SOURCE_DEBUG_ENABLE) == TRUE > PeCoffExtraActionLib|SourceLevelDebugPkg/Library/PeCoffExtraActionLibDebug/PeCoffExtraActionLibDebug.inf > DebugCommunicationLib|SourceLevelDebugPkg/Library/DebugCommunicationLibSerialPort/DebugCommunicationLibSerialPort.inf > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > !else > PeCoffExtraActionLib|MdePkg/Library/BasePeCoffExtraActionLibNull/BasePeCoffExtraActionLibNull.inf > @@ -282,6 +284,7 @@ [LibraryClasses.IA32.PEIM, LibraryClasses.IA32.PEI_CORE, LibraryClasses.IA32.SEC > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf > !else > DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > !endif > > @@ -781,6 +784,7 @@ [Components.IA32] > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAgentLib.inf > PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatformHookLibNull.inf > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > } > !endif > @@ -948,6 +952,7 @@ [Components.X64] > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmm.inf { > > NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > } > Vlv2TbltDevicePkg/FvbRuntimeDxe/FvbSmm.inf > @@ -1238,6 +1243,7 @@ [Components.X64] > > DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.inf > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > } > !endif > diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc > index 2368b04f40a4..d2c4bfc1a1a8 100644 > --- a/Platform/RaspberryPi/RPi3/RPi3.dsc > +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc > @@ -117,6 +117,7 @@ [LibraryClasses.common] > PciCf8Lib|MdePkg/Library/BasePciCf8Lib/BasePciCf8Lib.inf > PciLib|MdePkg/Library/BasePciLibCf8/BasePciLibCf8.inf > PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatformHookLibNull.inf > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf This will fail with current ed2-platform because of: https://github.com/tianocore/edk2-platforms/commit/2fc6eb4b707c16a10fa42f0d8e385d52e656a8e8 The RPi platforms recently removed the use of BaseSerialPortLib16550 and it appears your commit was designed for an older version of edk2-platform... > > # Cryptographic libraries > diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc > index b3a114b6e0ed..bd1eb9c15773 100644 > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc > @@ -126,6 +126,7 @@ [LibraryClasses.common] > PciCf8Lib|MdePkg/Library/BasePciCf8Lib/BasePciCf8Lib.inf > PciLib|MdePkg/Library/BasePciLibCf8/BasePciLibCf8.inf > PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatformHookLibNull.inf > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf Likewise because of https://github.com/tianocore/edk2-platforms/commit/41c1d9ba33046637ef0f5d96ed75e884e28d67fd Because we're no longer using BaseSerialPortLib16550 you should just ignore the RPi platforms. Regards, /Pete > !endif > > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > index 9f8cb68cdd26..281de3197d0c 100644 > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc > @@ -32,6 +32,7 @@ [LibraryClasses] > !if $(DEBUG_ON_UART1) == FALSE > SerialPortLib|ArmPlatformPkg/Library/PL011SerialPortLib/PL011SerialPortLib.inf > !else > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatformHookLibNull.inf > PciLib|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.dsc b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.dsc > index 00f6d4496377..ef3ed0f20911 100644 > --- a/Platform/Socionext/DeveloperBox/DeveloperBoxMm.dsc > +++ b/Platform/Socionext/DeveloperBox/DeveloperBoxMm.dsc > @@ -35,6 +35,7 @@ [LibraryClasses] > StandaloneMmDriverEntryPoint|MdePkg/Library/StandaloneMmDriverEntryPoint/StandaloneMmDriverEntryPoint.inf > StandaloneMmMmuLib|ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf > > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatformHookLibNull.inf > PciLib|MdePkg/Library/BasePciLibPciExpress/BasePciLibPciExpress.inf > diff --git a/Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc b/Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc > index e743a5e272e4..2e4bf8c1259c 100644 > --- a/Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc > +++ b/Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc > @@ -105,6 +105,7 @@ [LibraryClasses] > # Quark South Cluster > # > IohLib|QuarkSocPkg/QuarkSouthCluster/Library/IohLib/IohLib.inf > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatformHookLibNull.inf > # > diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > index 42f8bbba926c..4cf6429d7476 100644 > --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc > @@ -87,6 +87,7 @@ [LibraryClasses.common] > UefiScsiLib|MdePkg/Library/UefiScsiLib/UefiScsiLib.inf > > # Serial port libraries > + SerialUartClockLib|MdeModulePkg/Library/BaseSerialUartClockLib/BaseSerialUartClockLib.inf > SerialPortLib|MdeModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550.inf > PlatformHookLib|MdeModulePkg/Library/BasePlatformHookLibNull/BasePlatformHookLibNull.inf > >