public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Jiaxin Wu <Jiaxin.wu@intel.com>, edk2-devel@lists.01.org
Cc: Ye Ting <ting.ye@intel.com>, Fu Siyuan <siyuan.fu@intel.com>
Subject: Re: [Patch 6/6] NetworkPkg/UefiPxeBcDxe: Add the clarification compared to UefiPxeBcDxe in MdeModulePkg.
Date: Tue, 25 Sep 2018 12:30:32 +0200	[thread overview]
Message-ID: <4b3c4673-51ac-2be6-a57d-3437593c9089@redhat.com> (raw)
In-Reply-To: <20180925034445.14896-7-Jiaxin.wu@intel.com>

On 09/25/18 05:44, Jiaxin Wu wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205
> 
> This patch is to add the driver usage/difference clarification
> compared to UefiPxeBcDxe in MdeModulePkg.
> 
> Cc: Ye Ting <ting.ye@intel.com>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
> ---
>  NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf b/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> index e2a0eb44b1..f2ec34df93 100644
> --- a/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> +++ b/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf
> @@ -1,12 +1,17 @@
>  ## @file
>  #  Access PXE-compatible devices for network access and network booting.
>  #
>  #  This driver provides PXE Base Code Protocol which is used to accessing
> -#  PXE-compatible device for network access or booting. It could work together
> -#  with an IPv4 stack, an IPv6 stack or both.
> +#  PXE-compatible device for network access or booting. This driver supports 
> +#  both IPv4 and IPv6 network stack.
>  #
> +#  Notes: 
> +#  1) This driver can't co-work with the UefiPxeBcDxe driver in MdeModulePkg. 
> +#  2) This driver includes more bugs fix and supports more features (e.g. IPv6, 
> +#     MTFTP windowsize) than the UefiPxeBcDxe driver in MdeModulePkg. So, we 
> +#     recommand to use this driver even both of them can be used.
>  #
>  #  Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.<BR>
>  #
>  #  This program and the accompanying materials
>  #  are licensed and made available under the terms and conditions of the BSD License
> 

Same comments as for patch #4. With those updates:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks,
Laszlo


  reply	other threads:[~2018-09-25 10:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-25  3:44 [Patch 0/6] Add the clarification for TCP/ISCSI/PXE drivers Jiaxin Wu
2018-09-25  3:44 ` [Patch 1/6] MdeModulePkg/Tcp4Dxe: Add the clarification compared to TcpDxe in NetworkPkg Jiaxin Wu
2018-09-25 10:06   ` Laszlo Ersek
2018-09-25 10:09   ` Laszlo Ersek
2018-09-25  3:44 ` [Patch 2/6] MdeModulePkg/IScsiDxe: Add the clarification compared to IScsiDxe " Jiaxin Wu
2018-09-25 10:10   ` Laszlo Ersek
2018-09-25  3:44 ` [Patch 3/6] MdeModulePkg/UefiPxeBcDxe: Add the clarification compared to UefiPxeBcDxe " Jiaxin Wu
2018-09-25 10:24   ` Laszlo Ersek
2018-09-25  3:44 ` [Patch 4/6] NetworkPkg/TcpDxe: Add the clarification compared to Tcp4Dxe in MdeModulePkg Jiaxin Wu
2018-09-25 10:26   ` Laszlo Ersek
2018-09-25  3:44 ` [Patch 5/6] NetworkPkg/IScsiDxe: Add the clarification compared to IScsiDxe " Jiaxin Wu
2018-09-25 10:29   ` Laszlo Ersek
2018-09-25  3:44 ` [Patch 6/6] NetworkPkg/UefiPxeBcDxe: Add the clarification compared to UefiPxeBcDxe " Jiaxin Wu
2018-09-25 10:30   ` Laszlo Ersek [this message]
2018-09-26  0:41     ` Wu, Jiaxin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b3c4673-51ac-2be6-a57d-3437593c9089@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox