From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7E5BF21155D4D for ; Tue, 25 Sep 2018 03:30:40 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CEBCC3002860; Tue, 25 Sep 2018 10:30:34 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-71.rdu2.redhat.com [10.10.120.71]) by smtp.corp.redhat.com (Postfix) with ESMTP id A987F19940; Tue, 25 Sep 2018 10:30:33 +0000 (UTC) To: Jiaxin Wu , edk2-devel@lists.01.org Cc: Ye Ting , Fu Siyuan References: <20180925034445.14896-1-Jiaxin.wu@intel.com> <20180925034445.14896-7-Jiaxin.wu@intel.com> From: Laszlo Ersek Message-ID: <4b3c4673-51ac-2be6-a57d-3437593c9089@redhat.com> Date: Tue, 25 Sep 2018 12:30:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180925034445.14896-7-Jiaxin.wu@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Tue, 25 Sep 2018 10:30:34 +0000 (UTC) Subject: Re: [Patch 6/6] NetworkPkg/UefiPxeBcDxe: Add the clarification compared to UefiPxeBcDxe in MdeModulePkg. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 10:30:40 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 09/25/18 05:44, Jiaxin Wu wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1205 > > This patch is to add the driver usage/difference clarification > compared to UefiPxeBcDxe in MdeModulePkg. > > Cc: Ye Ting > Cc: Fu Siyuan > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wu Jiaxin > --- > NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf b/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > index e2a0eb44b1..f2ec34df93 100644 > --- a/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > +++ b/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf > @@ -1,12 +1,17 @@ > ## @file > # Access PXE-compatible devices for network access and network booting. > # > # This driver provides PXE Base Code Protocol which is used to accessing > -# PXE-compatible device for network access or booting. It could work together > -# with an IPv4 stack, an IPv6 stack or both. > +# PXE-compatible device for network access or booting. This driver supports > +# both IPv4 and IPv6 network stack. > # > +# Notes: > +# 1) This driver can't co-work with the UefiPxeBcDxe driver in MdeModulePkg. > +# 2) This driver includes more bugs fix and supports more features (e.g. IPv6, > +# MTFTP windowsize) than the UefiPxeBcDxe driver in MdeModulePkg. So, we > +# recommand to use this driver even both of them can be used. > # > # Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
> # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > Same comments as for patch #4. With those updates: Reviewed-by: Laszlo Ersek Thanks, Laszlo