From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 893A7740034 for ; Mon, 7 Aug 2023 09:53:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6hyyKTkHEk5AAhDoS6HFaQf+bG096K6GiV/OcwPcbM0=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1691402008; v=1; b=Drh46Kn6EKBcr5wxneGcaPQAB/oWLqToZpM9ekomN6ovw5gn57CRy1A2F4MJmghVXiklqMHw evx45IV9n3e0upKXi/JoCdkWxjb1VPYiA61qILbazQP/eLvOdfCxmrTgsOrn58kwyHlo/1uC5yH 2aEuP/e/bLoizpjA6xlIlCd0= X-Received: by 127.0.0.2 with SMTP id 7kUgYY7687511xapf1g4uhqj; Mon, 07 Aug 2023 02:53:28 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.30587.1691402007320024814 for ; Mon, 07 Aug 2023 02:53:27 -0700 X-Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-691-_nJmMrgdP4KAERAktmC4bQ-1; Mon, 07 Aug 2023 05:53:23 -0400 X-MC-Unique: _nJmMrgdP4KAERAktmC4bQ-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4469B3C025CE; Mon, 7 Aug 2023 09:53:22 +0000 (UTC) X-Received: from [10.39.192.88] (unknown [10.39.192.88]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8AAC240C2076; Mon, 7 Aug 2023 09:53:19 +0000 (UTC) Message-ID: <4b6ce9a4-97bc-f780-73dd-a589852feec0@redhat.com> Date: Mon, 7 Aug 2023 11:53:18 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests To: Ard Biesheuvel , "Kinney, Michael D" Cc: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" , "osteffen@redhat.com" , "Feng, Bob C" , Gerd Hoffmann , "Yao, Jiewen" , "Justen, Jordan L" , "Gao, Liming" , Rebecca Cran , Sean Brogan , "Chen, Christine" References: <20230803114425.318246-1-osteffen@redhat.com> <001ed4ff-89fa-c7bf-3a29-305a28b94b41@linux.microsoft.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: HGfvsl1ADtC2ReyDuAybUWpfx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Drh46Kn6; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 8/3/23 23:25, Ard Biesheuvel wrote: > On Thu, 3 Aug 2023 at 21:21, Kinney, Michael D > wrote: >> >> Hi Ard, >> >> This is the email with the analysis and the flag >> setting required for SMP to work with SMM enabled for >> IA32/X64 QEMU. >> >> https://edk2.groups.io/g/devel/message/102364 >> >> >> I tried latest version of QEMU earlier in the Summer >> and did not see any improvements. >> >=20 > Ah thanks, I had forgotten all about that rabbit hole you went down :-) Sorry Mike, I had also forgotten about that problem. >=20 > So let's respin this with -smp 4 --accel=3Dtcg,thread=3Dsingle. It is > still an improvement to exercise the MP code even if it doesn't > strictly execute concurrently. (It will be very hard to > catch/reproduce true concurrency issues in TCG anyway) I think that's a good workaround. Thanks Laszlo >=20 > Oliver, mind spinning a v2? >=20 > Thanks, >=20 >=20 >=20 >>> -----Original Message----- >>> From: Ard Biesheuvel >>> Sent: Thursday, August 3, 2023 9:54 AM >>> To: devel@edk2.groups.io; mikuback@linux.microsoft.com >>> Cc: osteffen@redhat.com; Feng, Bob C ; Gerd >>> Hoffmann ; Yao, Jiewen ; >>> Justen, Jordan L ; Gao, Liming >>> ; Kinney, Michael D >>> ; Rebecca Cran ; Sean >>> Brogan ; Chen, Christine >>> ; Laszlo Ersek >>> Subject: Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SM= P >>> in tests >>> >>> On Thu, 3 Aug 2023 at 16:37, Michael Kubacki >>> wrote: >>>> >>>> For the series. >>>> >>>> Reviewed-by: Michael Kubacki >>>> >>> >>> Thanks >>> >>> I've pushed this to the CI but Platform_CI OVMF_IA32X64_FULL_DEBUG >>> keeps timing out for me >>> >>> https://github.com/tianocore/edk2/pull/4718 >>> >>> Might it help if we restrict SMP to a subset of the builds? And would >>> it help if we added "--accel=3Dtcg,thread=3Dmulti" ? >>> >>> >>> >>>> On 8/3/2023 7:44 AM, Oliver Steffen wrote: >>>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4324 >>>>> PR: https://github.com/tianocore/edk2/pull/4711 >>>>> >>>>> This series switches the OVMF CI jobs on Windows to a recent Qemu >>>>> version and re-enables SMP in the Qemu "Run to shell" CI jobs. >>>>> The Qemu tests run a little bit slower in SMP mode and sometimes >>>>> hit the time limit of 2 minutes, thus this limit is increased to 4 >>>>> minutes. >>>>> >>>>> Together with 81cb0371f9db ("CI: Use latest image for Linux jobs >>> (Qemu >>>>> 8, gcc 12)" this series is sufficient to close Bug 4324. >>>>> >>>>> >>>>> Gerd Hoffmann (1): >>>>> OvmfPkg/PlatformCI: Boot OVMF in SMP mode. >>>>> >>>>> Oliver Steffen (3): >>>>> OvmfPkg/PlatformCI: Use recent Qemu on Windows >>>>> OvmfPkg/PlatformCI VS2019: Disable workaround for cpuhp bugfix >>>>> CI: Increase time limit of "Run to shell" task to 4 minutes >>>>> >>>>> .../templates/platform-build-run-steps.yml | 2 +- >>>>> .../PlatformCI/.azurepipelines/Windows-VS2019.yml | 4 ++-- >>>>> OvmfPkg/PlatformCI/PlatformBuildLib.py | 13 +-------- >>> ---- >>>>> 3 files changed, 4 insertions(+), 15 deletions(-) >>>>> >>>> >>>> >>>>=20 >>>> >>>> >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107615): https://edk2.groups.io/g/devel/message/107615 Mute This Topic: https://groups.io/mt/100524063/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-