public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Dandan Bi <dandan.bi@intel.com>, edk2-devel@lists.01.org
Cc: Eric Dong <eric.dong@intel.com>, Ruiyu Ni <ruiyu.ni@intel.com>
Subject: Re: [patch] UefiCpuPkg/CpuCommonFeaturesLib: Fix coding style issue
Date: Wed, 7 Mar 2018 10:07:24 +0100	[thread overview]
Message-ID: <4b88ea84-978b-ba82-a87a-4554830f1715@redhat.com> (raw)
In-Reply-To: <1520402018-7012-1-git-send-email-dandan.bi@intel.com>

On 03/07/18 06:53, Dandan Bi wrote:
> Boolean values do not need to use explicit comparisons
> to TRUE or FALSE.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
> index cc64dbb..27ca911 100644
> --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
> +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
> @@ -138,11 +138,11 @@ McaInitialize (
>    )
>  {
>    MSR_IA32_MCG_CAP_REGISTER  McgCap;
>    UINT32                     BankIndex;
>  
> -  if (State == TRUE) {
> +  if (State) {
>      McgCap.Uint64 = AsmReadMsr64 (MSR_IA32_MCG_CAP);
>      for (BankIndex = 0; BankIndex < (UINT32) McgCap.Bits.Count; BankIndex++) {
>        CPU_REGISTER_TABLE_WRITE64 (
>          ProcessorNumber,
>          Msr,
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


      parent reply	other threads:[~2018-03-07  9:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-07  5:53 [patch] UefiCpuPkg/CpuCommonFeaturesLib: Fix coding style issue Dandan Bi
2018-03-07  5:53 ` [patch] SecurityPkg/SmmTcg2PhysicalPresenceLib: " Dandan Bi
2018-03-07  7:42   ` Zhang, Chao B
2018-03-07  5:55 ` [patch] UefiCpuPkg/CpuCommonFeaturesLib: " Ni, Ruiyu
2018-03-07  9:07 ` Laszlo Ersek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b88ea84-978b-ba82-a87a-4554830f1715@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox