From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lersek@redhat.com>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com;
 receiver=edk2-devel@lists.01.org 
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id D8D0722135D51
 for <edk2-devel@lists.01.org>; Wed,  7 Mar 2018 01:01:11 -0800 (PST)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com
 [10.11.54.3])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 3830F40201A9;
 Wed,  7 Mar 2018 09:07:26 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-143.rdu2.redhat.com
 [10.10.120.143])
 by smtp.corp.redhat.com (Postfix) with ESMTP id 78C1D10E60D7;
 Wed,  7 Mar 2018 09:07:25 +0000 (UTC)
To: Dandan Bi <dandan.bi@intel.com>, edk2-devel@lists.01.org
Cc: Eric Dong <eric.dong@intel.com>, Ruiyu Ni <ruiyu.ni@intel.com>
References: <1520402018-7012-1-git-send-email-dandan.bi@intel.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <4b88ea84-978b-ba82-a87a-4554830f1715@redhat.com>
Date: Wed, 7 Mar 2018 10:07:24 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <1520402018-7012-1-git-send-email-dandan.bi@intel.com>
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.6]); Wed, 07 Mar 2018 09:07:26 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]);
 Wed, 07 Mar 2018 09:07:26 +0000 (UTC) for IP:'10.11.54.3'
 DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:''
Subject: Re: [patch] UefiCpuPkg/CpuCommonFeaturesLib: Fix coding style issue
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Mar 2018 09:01:12 -0000
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 03/07/18 06:53, Dandan Bi wrote:
> Boolean values do not need to use explicit comparisons
> to TRUE or FALSE.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
> index cc64dbb..27ca911 100644
> --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
> +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
> @@ -138,11 +138,11 @@ McaInitialize (
>    )
>  {
>    MSR_IA32_MCG_CAP_REGISTER  McgCap;
>    UINT32                     BankIndex;
>  
> -  if (State == TRUE) {
> +  if (State) {
>      McgCap.Uint64 = AsmReadMsr64 (MSR_IA32_MCG_CAP);
>      for (BankIndex = 0; BankIndex < (UINT32) McgCap.Bits.Count; BankIndex++) {
>        CPU_REGISTER_TABLE_WRITE64 (
>          ProcessorNumber,
>          Msr,
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>