public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	"Brian J. Johnson" <brian.johnson@hpe.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	Leif Lindholm <leif@nuviainc.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	Jian J Wang <jian.j.wang@intel.com>,
	"Wu, Hao A" <hao.a.wu@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
	Zhichao Gao <zhichao.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH v3 6/6] OvmfPkg IA32: add support for loading X64 images
Date: Thu, 27 Feb 2020 12:10:50 +0100	[thread overview]
Message-ID: <4b8960a3-abb2-7661-9a53-2382dacdc675@redhat.com> (raw)
In-Reply-To: <CAKv+Gu94szrBLSPA2tdXKXqE-5JjkL0B7+9KckzPcmuPUzxMbQ@mail.gmail.com>

On 02/26/20 22:40, Ard Biesheuvel wrote:
> On Wed, 26 Feb 2020 at 21:32, Brian J. Johnson <brian.johnson@hpe.com> wrote:
>>

>> I'm not an official reviewer, but I'd feel better about this patch if
>> you added a condition to exit the "while (PeCompat->Type != 0)" loop if
>> PeCompat ever gets pointed outside of the section.  Otherwise a
>> malformed or corrupted .compat section could send you off dereferencing
>> anything at all.
>>
> 
> Good point, I'll look into that.

You can keep my Acked-by if this is going to be the only change for this
patch, in v4.

Thanks
Laszlo


  reply	other threads:[~2020-02-27 11:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26 19:43 [PATCH v3 0/6] OvmfPkg: implement initrd shell command and mixed mode loader Ard Biesheuvel
2020-02-26 19:43 ` [PATCH v3 1/6] OvmfPkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID Ard Biesheuvel
2020-02-26 19:43 ` [PATCH v3 2/6] OvmfPkg: add 'initrd' shell command to expose Linux initrd via device path Ard Biesheuvel
2020-02-27 10:59   ` [edk2-devel] " Laszlo Ersek
2020-02-26 19:43 ` [PATCH v3 3/6] ArmVirtPkg: add the 'initrd' dynamic shell command Ard Biesheuvel
2020-02-26 19:43 ` [PATCH v3 4/6] OvmfPkg: " Ard Biesheuvel
2020-02-27 11:06   ` [edk2-devel] " Laszlo Ersek
2020-02-27 11:07     ` Ard Biesheuvel
2020-02-26 19:43 ` [PATCH v3 5/6] MdeModulePkg/DxeCore: defer PE/COFF emulator registration to StartImage Ard Biesheuvel
2020-02-27 17:10   ` Ard Biesheuvel
2020-02-28 12:02     ` [edk2-devel] " Liming Gao
2020-02-26 19:43 ` [PATCH v3 6/6] OvmfPkg IA32: add support for loading X64 images Ard Biesheuvel
2020-02-26 20:32   ` [edk2-devel] " Brian J. Johnson
2020-02-26 21:40     ` Ard Biesheuvel
2020-02-27 11:10       ` Laszlo Ersek [this message]
2020-02-27 19:40 ` [PATCH v3 0/6] OvmfPkg: implement initrd shell command and mixed mode loader Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b8960a3-abb2-7661-9a53-2382dacdc675@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox