From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.6393.1592396891803195682 for ; Wed, 17 Jun 2020 05:28:11 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 702FC1045; Wed, 17 Jun 2020 05:28:11 -0700 (PDT) Received: from [192.168.1.69] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 98D3C3F71F; Wed, 17 Jun 2020 05:28:10 -0700 (PDT) Subject: Re: [PATCH] ArmPkg/PlatformBootManagerLib: regenerate boot options on boot failure To: Leif Lindholm Cc: devel@edk2.groups.io, Pete Batard , Andrei Warkentin , Samer El-Haj-Mahmoud References: <20200616174834.1110310-1-ard.biesheuvel@arm.com> <20200617111235.GJ6739@vanye> <6a089a72-00cb-f8ce-16d7-50cefed9b47d@arm.com> <20200617121641.GM6739@vanye> From: "Ard Biesheuvel" Message-ID: <4bb1b99c-fa5a-ea9d-d786-32b16bb1604c@arm.com> Date: Wed, 17 Jun 2020 14:28:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200617121641.GM6739@vanye> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 6/17/20 2:16 PM, Leif Lindholm wrote: > On Wed, Jun 17, 2020 at 13:32:36 +0200, Ard Biesheuvel wrote: >> On 6/17/20 1:12 PM, Leif Lindholm wrote: >>> On Tue, Jun 16, 2020 at 19:48:34 +0200, Ard Biesheuvel wrote: >>>> One of the side effects of the recent changes to PlatformBootManagerLib >>>> changes to avoid connecting all devices on every boot is that we no >>>> longer default to network boot on a virgin boot, but end up in the >>>> UiApp menu. At this point, the autogenerated boot options that we used >>>> to rely on will be instantiated too, >>> >>> The passive voice is confusing me a bit here - who does the updating, >>> and when specifically? >>> >> >> Originally, the ArmPkg PlatformBmLib would always refresh all boot options, >> but now, only the UiApp does that upon entry, at which point your sitting in >> the menu idly, and so automated network boot no longer works. > > Sure. But the message should contain some description of agency. > > Something like: > "On entry, the UiApp instantiates the autogenerated boot options that > we used to rely on - but it does not consume them. This breaks the > unattended..." > OK > I assume the UiApp only ever *adds* entries, which is why checking > number of entries is sufficient? > It only manages entries that it instantiated itself, but it may also remove entries if the underlying hardware has disappeared. > With that/if so: > Reviewed-by: Leif Lindholm > > / > Leif >