From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.128.66; helo=mail-wm1-f66.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 109CD2194D3B9 for ; Wed, 6 Feb 2019 14:38:16 -0800 (PST) Received: by mail-wm1-f66.google.com with SMTP id r17so429038wmh.5 for ; Wed, 06 Feb 2019 14:38:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UoQ0MW2kUDPmqgq+heEN11ZHbBznlpd2h+tRSuj+GUU=; b=kUojrc/pxmXxwdVdXbekCC5Cmjvr4QxDJGmhWgGWzMkXcwwm5lz4opgCKWEu3NfQNq QMbm8wpflLuuZrR6hRA2z9luIEjiH8aNQPBpQH4sYwNIrsRS46rQOLWlqyfULMAsYcUr A67u3x0dAu95fZO6+j3Si7AZqYlo4BhvV8cqwSgAPngIxr6SGBwCczH0caC4LdY4ujEV zKwfP2DnsHkxJjPcTuemXEXQh1Oz1mlM4Te/V070flmAyf0xP/Y81nQiaPHYhMJ5fhpR DIHA8fx3SjK+NUehuSM/IQ++Pa2QRp1oErrMaYGu9+9kMe6lN1zrTlT/mCRgJSMYIACR 5Ymg== X-Gm-Message-State: AHQUAuYQZMl4I4YehgUAdZjUyK1G+YkOlzRgkAYOVgHcSP+En9q5j4VB hlzT+AyHxuVfqwnxPzNaVozTcr8qQ8k= X-Google-Smtp-Source: AHgI3IYoCrQFUZl6qwB1GcD61dP5JYkwZ2ifqx4XjOYQrmwok6YOIm4xTVsE0SKJ8t1Ui3lCMIs8/Q== X-Received: by 2002:a1c:7dd6:: with SMTP id y205mr4521782wmc.121.1549492694174; Wed, 06 Feb 2019 14:38:14 -0800 (PST) Received: from [192.168.1.103] (10.red-83-35-153.dynamicip.rima-tde.net. [83.35.153.10]) by smtp.gmail.com with ESMTPSA id q24sm10678wmq.16.2019.02.06.14.38.13 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 06 Feb 2019 14:38:13 -0800 (PST) To: Antoine Coeur , edk2-devel@lists.01.org References: From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <4bbe310f-f4ba-74ea-c99f-3fe61eec1a8c@redhat.com> Date: Wed, 6 Feb 2019 23:38:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH v2] ArmPlatformPkg: Fix various typos X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Feb 2019 22:38:16 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/6/19 4:46 PM, Antoine Coeur wrote: > Fix various typos in ArmPlatformPkg. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Coeur > --- > ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c | 4 ++-- > ArmPlatformPkg/Include/Library/ArmPlatformLib.h | 2 +- > ArmPlatformPkg/Include/Library/PL011UartLib.h | 2 +- > ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c | 2 +- > ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c | 2 +- > ArmPlatformPkg/PlatformPei/PlatformPeim.c | 2 +- > ArmPlatformPkg/PrePeiCore/PrePeiCore.c | 2 +- > ArmPlatformPkg/PrePi/PrePi.c | 2 +- > 8 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c > index af40a4c884..73d389c811 100644 > --- a/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c > +++ b/ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashDxe.c > @@ -1115,7 +1115,7 @@ NorFlashWriteSingleBlock ( > @retval EFI_SUCCESS The data was read correctly from the device. > @retval EFI_DEVICE_ERROR The device reported an error while performing the read. > @retval EFI_NO_MEDIA There is no media in the device. > - @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device. > + @retval EFI_MEDIA_CHANGED The MediaId does not match the current device. We could argue if this one is strictly a *typo* ;) > @retval EFI_INVALID_PARAMETER The read request contains device addresses that are not > valid for the device. > > @@ -1160,7 +1160,7 @@ NorFlashDiskIoReadDisk ( > @retval EFI_WRITE_PROTECTED The device can not be written to. > @retval EFI_DEVICE_ERROR The device reported an error while performing the write. > @retval EFI_NO_MEDIA There is no media in the device. > - @retval EFI_MEDIA_CHNAGED The MediaId does not matched the current device. > + @retval EFI_MEDIA_CHANGED The MediaId does not match the current device. > @retval EFI_INVALID_PARAMETER The write request contains device addresses that are not > valid for the device. > > diff --git a/ArmPlatformPkg/Include/Library/ArmPlatformLib.h b/ArmPlatformPkg/Include/Library/ArmPlatformLib.h > index 3ad4c16066..fd264b31f7 100644 > --- a/ArmPlatformPkg/Include/Library/ArmPlatformLib.h > +++ b/ArmPlatformPkg/Include/Library/ArmPlatformLib.h > @@ -20,7 +20,7 @@ > // > #include > // > -// The protocols, PPI and GUID defintions for this module > +// The protocols, PPI and GUID definitions for this module > // > #include > #include > diff --git a/ArmPlatformPkg/Include/Library/PL011UartLib.h b/ArmPlatformPkg/Include/Library/PL011UartLib.h > index 8cfc3d118a..495def8d7d 100644 > --- a/ArmPlatformPkg/Include/Library/PL011UartLib.h > +++ b/ArmPlatformPkg/Include/Library/PL011UartLib.h > @@ -118,7 +118,7 @@ PL011UartSetControl ( > . EFI_SERIAL_OUTPUT_BUFFER_EMPTY : equal to one if the > transmit buffer is empty, 0 otherwise. > . EFI_SERIAL_HARDWARE_LOOPBACK_ENABLE : equal to one if > - the hardware loopback is enabled (the ouput feeds the > + the hardware loopback is enabled (the output feeds the > receive buffer), 0 otherwise. > . EFI_SERIAL_SOFTWARE_LOOPBACK_ENABLE : equal to one if > a loopback is accomplished by software, 0 otherwise. > diff --git a/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c b/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c > index 61a34fda0b..60c06a63a4 100644 > --- a/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c > +++ b/ArmPlatformPkg/Library/PL011UartLib/PL011UartLib.c > @@ -327,7 +327,7 @@ PL011UartSetControl ( > . EFI_SERIAL_OUTPUT_BUFFER_EMPTY : equal to one if the > transmit buffer is empty, 0 otherwise. > . EFI_SERIAL_HARDWARE_LOOPBACK_ENABLE : equal to one if > - the hardware loopback is enabled (the ouput feeds the > + the hardware loopback is enabled (the output feeds the > receive buffer), 0 otherwise. > . EFI_SERIAL_SOFTWARE_LOOPBACK_ENABLE : equal to one if > a loopback is accomplished by software, 0 otherwise. Which makes me wonder what is the benefit of copying the same doc twice, in the header and the source? > diff --git a/ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c b/ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c > index 010f93add7..6f2a357b96 100644 > --- a/ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c > +++ b/ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c > @@ -15,7 +15,7 @@ > #include > > // > -// The protocols, PPI and GUID defintions for this module > +// The protocols, PPI and GUID definitions for this module > // > #include > #include > diff --git a/ArmPlatformPkg/PlatformPei/PlatformPeim.c b/ArmPlatformPkg/PlatformPei/PlatformPeim.c > index 14f301e947..4d9f3c2d54 100644 > --- a/ArmPlatformPkg/PlatformPei/PlatformPeim.c > +++ b/ArmPlatformPkg/PlatformPei/PlatformPeim.c > @@ -15,7 +15,7 @@ > #include > > // > -// The protocols, PPI and GUID defintions for this module > +// The protocols, PPI and GUID definitions for this module > // > #include > #include > diff --git a/ArmPlatformPkg/PrePeiCore/PrePeiCore.c b/ArmPlatformPkg/PrePeiCore/PrePeiCore.c > index 3a81e2e23f..be1d28a4d6 100644 > --- a/ArmPlatformPkg/PrePeiCore/PrePeiCore.c > +++ b/ArmPlatformPkg/PrePeiCore/PrePeiCore.c > @@ -44,7 +44,7 @@ CreatePpiList ( > PlatformPpiListSize = 0; > ArmPlatformGetPlatformPpiList (&PlatformPpiListSize, &PlatformPpiList); > > - // Copy the Common and Platform PPis in Temporrary Memory > + // Copy the Common and Platform PPis in Temporary Memory > ListBase = PcdGet64 (PcdCPUCoresStackBase); > CopyMem ((VOID*)ListBase, gCommonPpiTable, sizeof(gCommonPpiTable)); > CopyMem ((VOID*)(ListBase + sizeof(gCommonPpiTable)), PlatformPpiList, PlatformPpiListSize); > diff --git a/ArmPlatformPkg/PrePi/PrePi.c b/ArmPlatformPkg/PrePi/PrePi.c > index 245bdded1e..a9cd8b8f9d 100644 > --- a/ArmPlatformPkg/PrePi/PrePi.c > +++ b/ArmPlatformPkg/PrePi/PrePi.c > @@ -199,7 +199,7 @@ CEntryPoint ( > ArmCallSEV (); > } > } else { > - // Wait the Primay core has defined the address of the Global Variable region (event: ARM_CPU_EVENT_DEFAULT) > + // Wait the Primary core has defined the address of the Global Variable region (event: ARM_CPU_EVENT_DEFAULT) > ArmCallWFE (); > } > } > Reviewed-by: Philippe Mathieu-Daude