From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BDF1680286 for ; Mon, 20 Mar 2017 03:10:30 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1F5A2635C5; Mon, 20 Mar 2017 10:10:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1F5A2635C5 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1F5A2635C5 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-55.phx2.redhat.com [10.3.116.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8CC7062931; Mon, 20 Mar 2017 10:10:29 +0000 (UTC) To: "Zeng, Star" , edk2-devel-01 References: <20170317204731.31488-1-lersek@redhat.com> <20170317204731.31488-4-lersek@redhat.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B835B1D@shsmsx102.ccr.corp.intel.com> <322be6fe-5c1e-fc2d-c92f-3770ba32cdbf@redhat.com> <0C09AFA07DD0434D9E2A0C6AEB0483103B8360ED@shsmsx102.ccr.corp.intel.com> Cc: "Wu, Hao A" , "Tian, Feng" , Leif Lindholm , Ard Biesheuvel From: Laszlo Ersek Message-ID: <4bcf5894-9f6b-f70a-6dae-484cd0b3aadd@redhat.com> Date: Mon, 20 Mar 2017 11:10:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103B8360ED@shsmsx102.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 20 Mar 2017 10:10:31 +0000 (UTC) Subject: Re: [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Mar 2017 10:10:31 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 03/20/17 10:57, Zeng, Star wrote: > Yes, please. :) Thank you all; I pushed this one patch in separation, as commit 76874be3d411. Laszlo > > Thanks, > Star > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek > Sent: Monday, March 20, 2017 5:46 PM > To: Zeng, Star ; edk2-devel-01 > Cc: Wu, Hao A ; Tian, Feng ; Leif Lindholm ; Ard Biesheuvel > Subject: Re: [edk2] [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages > > On 03/20/17 03:16, Zeng, Star wrote: >> I am ok with this patch. > > Thanks -- should I add an R-b or A-b in your name? > > Thanks > Laszlo > >> >> Feng and Hao, do you have any comments? >> >> Thanks, >> Star >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Saturday, March 18, 2017 4:47 AM >> To: edk2-devel-01 >> Cc: Ard Biesheuvel ; Tian, Feng ; Wu, Hao A ; Leif Lindholm ; Zeng, Star >> Subject: [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages >> >> RamDiskDxe installs the RamDiskAcpiCheck() Ready To Boot callback function. If EFI_ACPI_TABLE_PROTOCOL and/or EFI_ACPI_SDT_PROTOCOL are not found, then informational messages are logged, and the RAM disks are not published to the (nonexistent) NFIT table. >> >> The logic is fine, but the info messages are not concatenated correctly from multiple string literals -- the second parts are passed as (unused) arguments to DEBUG(). Fix the typos. >> >> Cc: Ard Biesheuvel >> Cc: Feng Tian >> Cc: Hao Wu >> Cc: Leif Lindholm >> Cc: Star Zeng >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Laszlo Ersek >> --- >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c >> index d1dd13a8197b..b2bafc58bb71 100644 >> --- a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c >> +++ b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c >> @@ -74,7 +74,7 @@ RamDiskAcpiCheck ( >> if (EFI_ERROR (Status)) { >> DEBUG (( >> EFI_D_INFO, >> - "RamDiskAcpiCheck: Cannot locate the EFI ACPI Table Protocol,", >> + "RamDiskAcpiCheck: Cannot locate the EFI ACPI Table Protocol, " >> "unable to publish RAM disks to NFIT.\n" >> )); >> return; >> @@ -91,7 +91,7 @@ RamDiskAcpiCheck ( >> if (EFI_ERROR (Status)) { >> DEBUG (( >> EFI_D_INFO, >> - "RamDiskAcpiCheck: Cannot locate the EFI ACPI Sdt Protocol,", >> + "RamDiskAcpiCheck: Cannot locate the EFI ACPI Sdt Protocol, " >> "unable to publish RAM disks to NFIT.\n" >> )); >> mAcpiTableProtocol = NULL; >> -- >> 2.9.3 >> >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel >> > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >